From: Shuah Khan <skhan@linuxfoundation.org>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>,
christophe.leroy@csgroup.eu, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: kernel test robot <oliver.sang@intel.com>,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] selftests: vDSO: align stack for O2-optimized memcpy
Date: Fri, 27 Sep 2024 12:19:20 -0600 [thread overview]
Message-ID: <c38d9510-3cd6-4c8c-be45-f6f15334878a@linuxfoundation.org> (raw)
In-Reply-To: <ZvbqNZz547IGq7vy@zx2c4.com>
On 9/27/24 11:24, Jason A. Donenfeld wrote:
> Hi Shuah,
>
> On Tue, Sep 24, 2024 at 01:47:23PM +0200, Jason A. Donenfeld wrote:
>> When switching on -O2, gcc generates SSE2 instructions that assume a
>> 16-byte aligned stack, which the standalone test's start point wasn't
>> aligning. Fix this with the usual alignnent sequence.
I fixed this spelling when I apply. checkpatch is good at catching
these by the way.
>>
>> Fixes: ecb8bd70d51 ("selftests: vDSO: build tests with O2 optimization")
>> Reported-by: kernel test robot <oliver.sang@intel.com>
>> Closes: https://lore.kernel.org/oe-lkp/202409241558.98e13f6f-oliver.sang@intel.com
>> Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
>
> Just FYI, I'm expecting that this is a patch you take through your tree
> for 6.12, and hopefully before rc1, as automated testing is failing.
>
> Jason
Okay. Thanks for letting me know.
I will try to send this up for rc1 if at all possible.
Applied to linux-kselftest next
thanks,
-- Shuah
prev parent reply other threads:[~2024-09-27 18:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-24 8:08 [linus:master] [selftests] ecb8bd70d5: kernel-selftests.vDSO.vdso_standalone_test_x86.fail kernel test robot
2024-09-24 11:47 ` [PATCH] selftests: vDSO: align stack for O2-optimized memcpy Jason A. Donenfeld
2024-09-27 17:24 ` Jason A. Donenfeld
2024-09-27 18:19 ` Shuah Khan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c38d9510-3cd6-4c8c-be45-f6f15334878a@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=Jason@zx2c4.com \
--cc=christophe.leroy@csgroup.eu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=oliver.sang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®