From: Jie Luo <quic_luoj@quicinc.com>
To: Konrad Dybcio <konrad.dybcio@linaro.org>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
<andersson@kernel.org>, <agross@kernel.org>,
<mturquette@baylibre.com>, <sboyd@kernel.org>,
<robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
<conor+dt@kernel.org>, <catalin.marinas@arm.com>,
<will@kernel.org>, <p.zabel@pengutronix.de>
Cc: <linux-arm-msm@vger.kernel.org>, <linux-clk@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<quic_srichara@quicinc.com>
Subject: Re: [PATCH v9 4/4] clk: qcom: add clock controller driver for qca8386/qca8084
Date: Wed, 11 Oct 2023 20:40:52 +0800 [thread overview]
Message-ID: <c3914104-e2eb-44c1-4d5f-304c51b89c1a@quicinc.com> (raw)
In-Reply-To: <f97d167e-688e-428d-8463-5b315b9a9593@linaro.org>
On 10/11/2023 7:32 PM, Konrad Dybcio wrote:
>
>
> On 10/11/23 13:26, Jie Luo wrote:
>>
>>
>> On 10/11/2023 6:25 PM, Bryan O'Donoghue wrote:
>>> On 23/09/2023 12:21, Luo Jie wrote:
>>>> The clock controller driver of qca8386/qca8084 is registered
>>>> as the MDIO device, the hardware register is accessed by MDIO bus
>>>> that is normally used to access general PHY device, which is
>>>> different from the current existed qcom clock controller drivers
>>>> using ioremap to access hardware clock registers.
>>>
>>> "nsscc-qca8k is accessed via an MDIO bus"
>>>
>>>> MDIO bus is common utilized by both qca8386/qca8084 and other
>>>
>>> commonly
>>>
>>>> PHY devices, so the mutex lock mdio_bus->mdio_lock should be
>>>> used instead of using the mutex lock of remap.
>>>>
>>>> To access the hardware clock registers of qca8386/qca8084, there
>>>> is special MDIO frame sequence(three MDIO read/write operations)
>>>> need to be sent to device.
>>>
>>> "there is a special MDIO frame sequence"
>>>
>>> "which needs to be sent to the device"
>>
>> I will update the comments, thanks Bryan.
>>
>>>
>>> the following indentation splat from checkpatch
>>>
>>> CHECK: Alignment should match open parenthesis
>>> #2071: FILE: drivers/clk/qcom/nsscc-qca8k.c:2004:
>>> + ret = __mdiobus_write(bus, switch_phy_id, (reg |
>>> QCA8K_REG_DATA_UPPER_16_BITS),
>>> + upper_16_bits(val));
>>>
>>> CHECK: Alignment should match open parenthesis
>>> #2131: FILE: drivers/clk/qcom/nsscc-qca8k.c:2064:
>>> +static int qca8k_regmap_update_bits(void *context, unsigned int
>>> regaddr,
>>> + unsigned int mask, unsigned int value)
>>>
>>> total: 0 errors, 1 warnings, 2 checks, 2162 lines checked
>>>
>>> NOTE: For some of the reported defects, checkpatch may be able to
>>> mechanically convert to the typical style using --fix or
>>> --fix-inplace.
>>>
>>> 0004-clk-qcom-add-clock-controller-driver-for-qca8386-qca.patch has
>>> style problems, please review.
>>
>> Thanks Bryan for the review. The code line mentioned by CHECK is more
>> than 100 columns, so i separate the lines.
> Please read what checkpatch tells you.
>
> It asks you to change
>
> very_long_func_name(arg1, arg2,
> arg3);
>
> to
>
> very_long_func_name(arg1, arg2,
> arg3);
>
> (remember tab len is 8 for the linux kernel)
>
> Konrad
Got it, thanks Konrad for the reminder.
next prev parent reply other threads:[~2023-10-11 12:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-23 11:21 [PATCH v9 0/4] add clock controller of qca8386/qca8084 Luo Jie
2023-09-23 11:21 ` [PATCH v9 1/4] clk: qcom: branch: Add clk_branch2_prepare_ops Luo Jie
2023-09-23 11:21 ` [PATCH v9 2/4] dt-bindings: clock: add qca8386/qca8084 clock and reset definitions Luo Jie
2023-09-23 11:21 ` [PATCH v9 3/4] clk: qcom: common: commonize qcom_cc_really_probe Luo Jie
2023-10-11 10:06 ` Bryan O'Donoghue
2023-09-23 11:21 ` [PATCH v9 4/4] clk: qcom: add clock controller driver for qca8386/qca8084 Luo Jie
2023-10-11 10:25 ` Bryan O'Donoghue
2023-10-11 11:26 ` Jie Luo
2023-10-11 11:32 ` Konrad Dybcio
2023-10-11 12:40 ` Jie Luo [this message]
2023-10-11 11:33 ` Bryan O'Donoghue
2023-10-11 12:42 ` Jie Luo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c3914104-e2eb-44c1-4d5f-304c51b89c1a@quicinc.com \
--to=quic_luoj@quicinc.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=quic_srichara@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®