From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E4C36478E3A for ; Thu, 2 Jul 2026 12:39:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782995975; cv=none; b=b62wmS6ca7RL8CbOwjT63IRrmKvVHv0ZLjKocm2UNha5Fn5d84K2pe5LaL9EHhP1s3nCArQf1TV+m8uqLl+OXMDjC2hPN6VWACc7bVwGSSYqrY0zUdMW7t9HpBIPORnEUkHmoE2rNOXud8kSiOoVfdDVeA6pPbucpgLwj9A8QZk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782995975; c=relaxed/simple; bh=M/1IO1ovD3xv7E7bwlWhzJmzQk00aY6O8z3/PeBE8DE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=MIVpnWDIee8/3AzLGbrdnrJe1Yz6nNDqP4l4z8oq9ONoLrZFk1eD3M+7a62PhZkG11XNGHUkYBU9lSN/xpjFBebRaOOp50lSxVzLjyWrUb6+kQBn0J0vX35pjxAHppq9LbYJ+bcYLub9eDrSNNvg8CeAX8jQSpHLhdIB48JTeQY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=fza/WWmC; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=dazX+XzC; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="fza/WWmC"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="dazX+XzC" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6627Tsfn3964230 for ; Thu, 2 Jul 2026 12:39:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 9CnAJp8KHEUhQx8/mU74U/fRMf07e+imvfeLUvkYie4=; b=fza/WWmC380toLK/ tHkJhoz7hhJw77/0liY0hTcH53/gnckUuFovyfcL7LP+LAhlpcuoLXs8WpKVTqfV egxX2ePfToyWWUNRllWUV1B/SaEoF+7Q2iFX3m8HWaxE29Bik2tayo5h/st6S+We /gXOgvymgN66zWT+jNpiFdK0MoXWyUb4Gr4OyWkTfzHh7Wj/GXank2w7l+3BgpIE pgNeBhzbvG6kcwg7ya7krJjdmfVsQ1iMNuGRaeWCh28H8oJ/PvfEWE5mWOdmbTds nL+lnSrAfW5gbmbCWxABxdcDQ6qVbS8Ug44ILepZMAsr7gxviPFlxTNouFn1BTfl ti0Hdg== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f5knc1709-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 02 Jul 2026 12:39:32 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-92e57e56ce9so34715485a.3 for ; Thu, 02 Jul 2026 05:39:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782995972; x=1783600772; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=9CnAJp8KHEUhQx8/mU74U/fRMf07e+imvfeLUvkYie4=; b=dazX+XzCBzsIq/2oYnz1XEEoCFCqexXbXOR0iEXBaTYMnJCDqNddTk2e7t3Z26zGmh lS7KWttUXAlKs/R4RLn1mkTPLn07NZuIqB8cjjs2ImRPdMLbPvvS/0b/dFlHh+aS+76m 2nE9Q2jsiE3CfQ3rFg20lU9TIfMdV+kLIV3YONYentTFYVH8lhfLooXNbfxsbSQNmkot N2f+N4dPl/NUWdVw0OINHHw7zhFuvYZatB6ZuRBgN+Itj9GPgVqzNbFIVyIL8jP0JFCm fi8j368A1n8pOeyHBQ4HKmDHUkoLaKwDPT78d+jy3IUdgVyw5WJytkIgFxjmfrFKpLcG CVYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782995972; x=1783600772; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=9CnAJp8KHEUhQx8/mU74U/fRMf07e+imvfeLUvkYie4=; b=gzFo/MK+zhEO6n6nJkLN1JIFGiV/DOpxrQJxx5WdJlSZC+qRBm774/a6ub9hJ/BzAB FITnPQyOMogm3766AfyvFgOU0+vYSrRAR2NJ7IAo6la+WVvJJZV57XPSpaJWnH3E+ogu gFsPPBBACAbOjJTJex9cRhB80q4D67LRB+exmSGNGwfgdGcY0h0NEOrh2VcdFHPOqmen 4ilLcYISNgYBxz8mLzhBNqGLr8Cd8DON2pI78Wu+mHe2+UMto8VNGY2nnAklODXFaaKE sLQFCT+fPeGsPrt/disirQuGHtCafJoTtodW7kRUN15isscqLjO27nwcM2aRZowBa/PG QK6Q== X-Forwarded-Encrypted: i=1; AFNElJ/5d+0pYbTRyXwFm7qcMQ5uZFwuMIIKeBVUfHPCOMwSbKeLhtPo3YnYLiMEZNTcJ5tAGcJN7NDLtwCSkb4=@vger.kernel.org X-Gm-Message-State: AOJu0YxxKmGli4dYmcbwEY38ld2Vf7iiddB4iREArzxdgzRWeHRvqZwC 8QEjIwsyCyiumMX0pZdF/BV5n2ft733CuzfHBD35cZ14C/PhiXUQExLw00+8eMUik9dCo1hQ5bt Up7Rnp2rkCcXXw/t5b0GObE9RIvvmsIE5Ur5ww1UBejaWKCQW4vthdeZE/ArgDYXkfb4= X-Gm-Gg: AfdE7cnoJpjbdVBfB/88S2Gv+Ln/cO28CSl1fVNnTCpLdp16cEu8bXGWVhh+crVJMo4 UpMzECmJvJ+ozFM8fxJIe4IIaeWx3GPDftJ2zz5NihOlaVC3Dl5PsE5VpGbol68lk9r0X0UicUM h2Vs66YR/tcXO3uBcAX2gjkue3JpeP8icLwOQRcaYPhowztDso/OhpGh3CE8I3awrI7xJjn+QU8 BpxGg/DOZdOOaKEXNU0S+gbmvMM3dzBFMbhNIAQCk/m8zLtVOVcRfhSBcYPMIqJmZIMv42D3vcl 4nshPg+x5wINvcbxGvI3J8Wnddn0EDnu9apwi5bbSjchVz4y7sDnvgMpyr7Jupw+6CDfgW5Ltu7 WvsNanoOkNS9r8gIgJrJ6DTiwIDN5s5Sx8vE= X-Received: by 2002:ac8:590d:0:b0:51a:8c9b:6492 with SMTP id d75a77b69052e-51c26b25d63mr44656421cf.9.1782995972034; Thu, 02 Jul 2026 05:39:32 -0700 (PDT) X-Received: by 2002:ac8:590d:0:b0:51a:8c9b:6492 with SMTP id d75a77b69052e-51c26b25d63mr44655921cf.9.1782995970668; Thu, 02 Jul 2026 05:39:30 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-698ad0fff43sm935595a12.17.2026.07.02.05.39.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Jul 2026 05:39:29 -0700 (PDT) Message-ID: Date: Thu, 2 Jul 2026 14:39:26 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] spi: qcom-geni: Add property to force GSI mode To: Pengyu Luo , Mukesh Savaliya Cc: Dmitry Baryshkov , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andy Gross , Bjorn Andersson , linux-arm-msm@vger.kernel.org, linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260614083424.464132-1-mitltlatltl@gmail.com> <20260614083424.464132-2-mitltlatltl@gmail.com> <99eaf1d1-fbf9-4336-a13c-ae8ab789cc99@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: Th7rOcc1lqa2Cg1rKzUmQzKtF1o68x3D X-Authority-Analysis: v=2.4 cv=a4kAM0SF c=1 sm=1 tr=0 ts=6a465c04 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=6QUDDQO5MDr9iEhkdtUA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzAyMDEzMyBTYWx0ZWRfX5qsqN4zohsTr guMM3xYvjnxhRgEZ5R+6BxGL0F7i+BV37PTaQiR7r5ln7WVHAbx7moafxNUEapBgNU+hmrE/Jim jkggacutLtzrGSNLCJ24nDp6cWM+Ql5FvTDE88UNbFhwk4nghSMxQIboD7kLpXjsAG1JgGkiCa/ UrDCvAggDgIBEArvbBLAUOQReRjBXd2TCSquQrVIjqtnpxQV28brhGXBfT4x7Ep1cZGe63CCuOR Vr9ZR4ahbTARo0YLOzn+RWHyfGlw9V02iG7yISrNiPSmcLUgnV0ZpHqWp5lFNsJfh65D1JyCO+i tModU0FxqlMI+wkeo3jSEUg2T2JCeRntoJagJYH+xC/pQutchDOVk4gFL6FovW2AyDvso+Y954N 5pJCLtuyzG0NYL/ozCNswCHkDqLG6o0p4YsnQuRVusb9ex+0oScKsgLzuFy8UY0RscEQjXSGIm3 MAHL+arlL2I2jTU+A+Q== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzAyMDEzMyBTYWx0ZWRfXwJbWwgOT5n0b uVkM7QWtSljJ06RDmpikDuO7+tabnLdDXkXcEixsbngdboU+emNPieHNsQ99RtzkbnQpNGYieWm 5uG7CTMjzvF17s7E2YIMyZ0N9liw0MI= X-Proofpoint-GUID: Th7rOcc1lqa2Cg1rKzUmQzKtF1o68x3D X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-02_01,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 clxscore=1015 impostorscore=0 malwarescore=0 adultscore=0 suspectscore=0 priorityscore=1501 bulkscore=0 spamscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607020133 On 6/30/26 12:06 PM, Pengyu Luo wrote: > On Tue, Jun 30, 2026 at 5:52 PM Mukesh Savaliya > wrote: >> >> >> >> On 6/29/2026 1:33 PM, Pengyu Luo wrote: >>> On Mon, Jun 29, 2026 at 1:36 PM Mukesh Savaliya >>> wrote: >>>> >>>> Hi Pengyu, >>>> >>>> On 6/15/2026 2:48 AM, Dmitry Baryshkov wrote: >>>>> On Sun, Jun 14, 2026 at 04:34:24PM +0800, Pengyu Luo wrote: >>>>>> Some devices (such as gaokun3) do not disable FIFO mode, causing the >>>>>> driver to fallback to FIFO mode by default. However, these platforms >>>>>> also support GSI mode, which is highly preferred for certain >>>>>> peripherals like SPI touchscreens to improve performance. >>>>>> >>>>>> Introduce the "qcom,force-gsi-mode" device property to hint and force >>>>>> the controller into GSI mode during initialization. >>>> Why to force ? You can directly configure in GSI mode. Note there are >>>> some configuration done prior to Linux bootup too. >>> >>> Sorry, I don't get it. how? I know there may be a qupfw, but it is >>> impossible for a normal user like me to generate one with GSI >>> preferred. >>> >> If firmware doesn't program in GSI, you can't have this working in GSI >> mode, its going to fail (and work with fallback). if it's programmed in >> GSI, anyway this will run in GSI mode. So why to add extra things >> without any usage ? >> > > What I can confirm is that fifo is not disabled on my device, and gsi > is definitely enabled (under windows, check the register > SE_GENI_DMA_MODE_EN), forcing the device to enable GSI mode on linux > works well. What's the value of se->base + SE_DMA_IF_EN (+0x2004) on this SE? Konrad