From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 991D1233710 for ; Fri, 16 May 2025 10:11:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747390301; cv=none; b=fQfPcrjWJsa6EXu9bRLkxzajTFzzwc8nTUeV/BNIH2UYj1yipmwcHGb5MlJLSSAd4m52FXvJr/HRt6uMMtjzfGIvOWq1uniPCYh7CpDfoJ9I8qHwbuj9IY7QM7N9l67qpJuoLHu8gbfuyJMA1sqXou+JikB+DHqMZZ0O5ox/vvo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747390301; c=relaxed/simple; bh=PHD79eIwWCw9V5lNQ7QYdkVLrAR+HF/Hje38keTFPFc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=FoE2gNaXFLfSw6AB8xVl+dyqepvx02UuJdkNERYLEh+MSUQqMMoIVQAOiXQgsQKi8nR2XFe3p5eMZQeVVqu8rJrn8Ix1gg7ITYvg+BTu9rTjz8UZ77k68rgBqkYZDL/bE9UHgN3EjFiFPlCoDMBFPdn3Qy59+/DEOpV1PscNYvU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=SvH+DbcZ; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="SvH+DbcZ" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-3a1f9791a4dso1252886f8f.0 for ; Fri, 16 May 2025 03:11:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1747390298; x=1747995098; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=FK5emDR4y7307fTZlqtGJXVVpQCgklOy57Bb5kZPQdc=; b=SvH+DbcZuDdpa8iXC1jr2c3Ywxtm6z2bWqo3ZhCsITj2rL4pkwvBvrsXK+FpSckHSq Sq89UwmY6BihghzgV6Il7Ks+rSQBKruOHIjRefNhNLl8KKIrhUERQME62NWoa27KoWpf jWoUFJfiYRwNP/eBDjl2JtviHPapZB2jQqbHBW3i74/QEqovQgf50WD3y3OlukGLmLkH +LTsYyQBQPeOuOroa8sBS/Jdj6VDIatNioNIeG38322dsqD2R9mjvETyupOM+aOzK6W0 8ioGQiMgAbEHgCr8gGSslMTisds8iUk279eu/amA3NXsN2hxXq8PXy6/uuI61bYVGzcz ig7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747390298; x=1747995098; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FK5emDR4y7307fTZlqtGJXVVpQCgklOy57Bb5kZPQdc=; b=G4jbcXdLIDF3zIuf5KWiWiJlrARrZ4dHaJ10tSo/BM2mq+Uyui5j12BxSFnG3BVOup 3Nq2O/5H4PZdUDayIzD0fHnCLelCUrE5/dhLIqWFHeM6Amw9UhIPuhn4BYvJAAD4hWlz 4C2e5biuuGB7I/ZVEf2+THbV57zMJWimYWCJvXmXzSouHxwwNzgoRJQAPc/CzTi1lNoD QmOmks89tK5Xj5W+mWOB4ZbuyEmTsOjjHYsMo1MzfvisY/3VQjv8gI23C6Umg3o3QsB3 nXYrHeucuLEjbWEfHJeg5NXs890kgelMTC2bc2VqyttTGGfYYX8xFdySWgSObGWHpcgT GIyg== X-Forwarded-Encrypted: i=1; AJvYcCVQRk9ZLLrokrvbdkKSd1ckBNbE+SP2eolKddtHJQbT7V0a+nwgBVyZlNyzmJhlHpD8t8ZNKyxHPDZNYiw=@vger.kernel.org X-Gm-Message-State: AOJu0YxpbJxz6Oe+m8Cwxg7jdlotgcL0oPD6Givs54T8X9u6pLmNKfmt E1LQ0vyBH32AJdOF7cSxu02BrcCMgAuGmyhSC9pIAcFnEhOXFOwF4n53hH26+ICuZVc= X-Gm-Gg: ASbGncv2cXNTCLnuFPhxhWSnuYL+SI1hhacy21DJ5Xc6uYMlcZt0bzEcsFCApbdFSBz inpYv/Tqexbv/P2aQWmfrgMMkaPWPiS7peUE7zHYAN1DY+bv8D/Mg2M4ShabmgnDBh3myduu9mL gMp3otfBll24ZaLaBUW5pOQCKYBdPAVY2h9RA59hYBJzawhNSMXbw85dp2b/iuL+YT1iu11ZlVg ruCQ0js9o4uHw5SgTmJOutMJAILCyz/CSrgx+M6y53Oz0M/NDPklpDO1yYU11RStJ2IU/pj5Mz+ zlgRA89+FoLSpDZ0et9Q/5+F+Gm4z88efq2rMun30O56uu2wEUt5Tg6/aWupmHzqanVjZiJJLSH Y5ihJQPiu4XSn X-Google-Smtp-Source: AGHT+IENqe0ySJELs1LHO+iGEWDGqtm1yvWiW49LkEbYEHxbTK/1es1hMOvGyGFEKYjY38sVDEx5OA== X-Received: by 2002:a05:6000:3110:b0:3a0:b550:ded4 with SMTP id ffacd0b85a97d-3a35c821bbcmr2765151f8f.13.1747390297854; Fri, 16 May 2025 03:11:37 -0700 (PDT) Received: from [10.61.1.70] (110.8.30.213.rev.vodafone.pt. [213.30.8.110]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a3620dbc6asm1284004f8f.88.2025.05.16.03.11.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 May 2025 03:11:37 -0700 (PDT) Message-ID: Date: Fri, 16 May 2025 11:11:36 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/2] media: venus: fix TOCTOU vulnerability when reading packets from shared memory To: Vikash Garodia , Dikshita Agarwal , Mauro Carvalho Chehab , Stanimir Varbanov , Hans Verkuil Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Vedang Nagar References: <20250514-venus-fixes-v3-0-32298566011f@quicinc.com> <20250514-venus-fixes-v3-1-32298566011f@quicinc.com> <0c50c24a-35fa-acfb-a807-b4ed5394506b@quicinc.com> <767909a0-70ea-47d3-b6bf-b57e5d7e7c5c@linaro.org> <13887de6-4f84-9d0c-bd48-de6f0472d9ef@quicinc.com> Content-Language: en-US From: Bryan O'Donoghue In-Reply-To: <13887de6-4f84-9d0c-bd48-de6f0472d9ef@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 15/05/2025 19:25, Vikash Garodia wrote: > Check the pseudo code which i proposed earlier in this conversation [1]. It does > not rely on ptr_val at all to check the sanity after memcpy. > > [1]https://lore.kernel.org/all/0c50c24a-35fa-acfb-a807- > b4ed5394506b@quicinc.com/ Understood. Another version of this patch to check after the memcpy() for verification purposes might be correct but, IMO there's no scope for a TOCTOU based modification here. --- bod