mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Matteo Croce <technoboy85@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] get_maintainer: add ** glob pattern support
Date: Mon, 02 Mar 2026 08:48:12 -0800	[thread overview]
Message-ID: <c395bd6f33266c5b82f92f3a293732672b3c7a34.camel@perches.com> (raw)
In-Reply-To: <20260302103822.77343-1-teknoraver@meta.com>

On Mon, 2026-03-02 at 11:38 +0100, Matteo Croce wrote:
> Add support for the ** glob operator in MAINTAINERS F: and X: patterns,
> matching any number of path components (like Python's ** glob).
> 
> The existing * to .* conversion with slash-count check is preserved.
> ** is converted to (?:.*), a non-capturing group used as a marker to
> bypass the slash-count check in file_match_pattern(), allowing the
> pattern to cross directory boundaries.
> 
> This enables patterns like F: **/*[_-]kunit*.c to match files at any
> depth in the tree.
> 
> Signed-off-by: Matteo Croce <teknoraver@meta.com>

Acked-by: Joe Perches <joe@perches.com>

> ---
>  MAINTAINERS               | 1 +
>  scripts/get_maintainer.pl | 9 +++++++--
>  2 files changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 96e97d25e1c2..4ca6f6745f9c 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -35,6 +35,7 @@ Descriptions of section entries and preferred order
>  	   F:	drivers/net/	all files in and below drivers/net
>  	   F:	drivers/net/*	all files in drivers/net, but not below
>  	   F:	*/net/*		all files in "any top level directory"/net
> +	   F:	fs/**/*foo*.c	all *foo*.c files in any subdirectory of fs
>  	   One pattern per line.  Multiple F: lines acceptable.
>  	X: *Excluded* files and directories that are NOT maintained, same
>  	   rules as F:. Files exclusions are tested before file matches.
> diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
> index 4414194bedcf..f0ca0db6ddc2 100755
> --- a/scripts/get_maintainer.pl
> +++ b/scripts/get_maintainer.pl
> @@ -375,8 +375,10 @@ sub read_maintainer_file {
>  	    ##Filename pattern matching
>  	    if ($type eq "F" || $type eq "X") {
>  		$value =~ s@\.@\\\.@g;       ##Convert . to \.
> +		$value =~ s/\*\*/\x00/g;     ##Convert ** to placeholder
>  		$value =~ s/\*/\.\*/g;       ##Convert * to .*
>  		$value =~ s/\?/\./g;         ##Convert ? to .
> +		$value =~ s/\x00/(?:.*)/g;   ##Convert placeholder to (?:.*)
>  		##if pattern is a directory and it lacks a trailing slash, add one
>  		if ((-d $value)) {
>  		    $value =~ s@([^/])$@$1/@;
> @@ -746,8 +748,10 @@ sub self_test {
>  	if (($type eq "F" || $type eq "X") &&
>  	    ($self_test eq "" || $self_test =~ /\bpatterns\b/)) {
>  	    $value =~ s@\.@\\\.@g;       ##Convert . to \.
> +	    $value =~ s/\*\*/\x00/g;     ##Convert ** to placeholder
>  	    $value =~ s/\*/\.\*/g;       ##Convert * to .*
>  	    $value =~ s/\?/\./g;         ##Convert ? to .
> +	    $value =~ s/\x00/(?:.*)/g;   ##Convert placeholder to (?:.*)
>  	    ##if pattern is a directory and it lacks a trailing slash, add one
>  	    if ((-d $value)) {
>  		$value =~ s@([^/])$@$1/@;
> @@ -921,7 +925,7 @@ sub get_maintainers {
>  				my $value_pd = ($value =~ tr@/@@);
>  				my $file_pd = ($file  =~ tr@/@@);
>  				$value_pd++ if (substr($value,-1,1) ne "/");
> -				$value_pd = -1 if ($value =~ /^\.\*/);
> +				$value_pd = -1 if ($value =~ /^(\.\*|\(\?:\.\*\))/);
>  				if ($value_pd >= $file_pd &&
>  				    range_is_maintained($start, $end) &&
>  				    range_has_maintainer($start, $end)) {
> @@ -955,6 +959,7 @@ sub get_maintainers {
>  			$line =~ s/([^\\])\.([^\*])/$1\?$2/g;
>  			$line =~ s/([^\\])\.$/$1\?/g;	##Convert . back to ?
>  			$line =~ s/\\\./\./g;       	##Convert \. to .
> +			$line =~ s/\(\?:\.\*\)/\*\*/g;	##Convert (?:.*) to **
>  			$line =~ s/\.\*/\*/g;       	##Convert .* to *
>  		    }
>  		    my $count = $line =~ s/^([A-Z]):/$1:\t/g;
> @@ -1048,7 +1053,7 @@ sub file_match_pattern {
>  	if ($file =~ m@^$pattern@) {
>  	    my $s1 = ($file =~ tr@/@@);
>  	    my $s2 = ($pattern =~ tr@/@@);
> -	    if ($s1 == $s2) {
> +	    if ($s1 == $s2 || $pattern =~ /\(\?:/) {
>  		return 1;
>  	    }
>  	}
> 
> ```

      reply	other threads:[~2026-03-02 16:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-02 10:38 Matteo Croce
2026-03-02 16:48 ` Joe Perches [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c395bd6f33266c5b82f92f3a293732672b3c7a34.camel@perches.com \
    --to=joe@perches.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=technoboy85@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®