From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 624843DDAEC for ; Fri, 17 Jul 2026 14:14:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784297692; cv=none; b=BkpZCKz5GZf22PLZzrmQfCQu/jt2oi2dw4E3aM/lmsrtOT/qqdZFLSbA4kcRI6t5v5osIN8tajBmvx6EUnIPsvRb662NvOIsE+4Sf39FoNqMO3EbeyX+r9OYMHV3Tm7HmQQ2mfVzvJlFWUjoVJeFdVZJ+1Db+bCwMl5n38T4j2E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784297692; c=relaxed/simple; bh=KAm/AYUIYfZT7X1FNvOPdVe24HfSOIRqxExkrJ//yOw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=LJ8xx++5z8WnGYvhSf6IqsB0WkXyFwUjeDeNLtYrnlu0ejYdYCTXau91CtlZA/CndH8WOOxsQJ9OLOPgMgPMaz/1KDim5UC3w+r4G3AdOQd+tphXeOzQbExRu3YQMH42HXGXUSHEPUOkYOMDMTtdSPHo1n9A9UVkDI2cWV2wXW0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arturia.com; spf=pass smtp.mailfrom=arturia.com; dkim=pass (2048-bit key) header.d=arturia.com header.i=@arturia.com header.b=NpJSyA7Y; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arturia.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arturia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=arturia.com header.i=@arturia.com header.b="NpJSyA7Y" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-493f25d47dcso29057645e9.1 for ; Fri, 17 Jul 2026 07:14:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arturia.com; s=arturia; t=1784297688; x=1784902488; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=iP+3qWAITWJuNIeEV6DkJLDIFtTz+ldyffR4pVfrlVQ=; b=NpJSyA7Yj/SoqQjkXyHSSK2/7ELaAjwsRxVAkMOi2+idYsFjROeqEIMtGf/fmybdQB d+6Ll9UxDTx90pCs3qRjNImsVA6C6FW1M28W5rCo+YxqDrhKnbJkBtp1FEI9wnse4o/n 7zyKUxNptQxoSsCNwOdqUxyqmaFrXJ6ABYD8GO8O5isVjME+KWZW1eugWT/9v8HWenBC ehZ4GWQq/n9DwfyQixjyq7vSV/EW/zXKQVvgNNNvkn6TttebX5AvjPkrJ43pPH69YiqK nSjXsgY7pvHuQcgt5Ii44JxuFuDHZHN/1B0yryjYKTQ2iN1v1rDiDgqcOnG0LouLo3db N36w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784297688; x=1784902488; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=iP+3qWAITWJuNIeEV6DkJLDIFtTz+ldyffR4pVfrlVQ=; b=UnDczSq6qeCYVmrECdqJLzz+bbvOLoZBNq9aP6TaPrsklb4iu1k+amkHFkl67tkavP iBhhwd+Ve7RcYeo3o2huq8pmFcEIKljg6VvK11B10tp90QbOGoScx77dH0lZCLdzrv5L pyyD7NBdt7SO0L1yUUVPn3ujDr8FujRBIhcHew36JfDGqLsBXBHucSSc/9IrG6LAM7uf s0HVwTjlOItd/iGkq0XnYFIF+qFbWrdwYXLSQBApUynPn+1T4yUSHoLdwBjcNBTcFp5v b2IruaOdyGzVxV1BV/VWPWbP4h9d41f8OKblsrvDexlXN3u5B4LIzHYN29vh1H/qMNrE 0pnA== X-Forwarded-Encrypted: i=1; AHgh+RqYIcdsTZf3f/cJzqicKrC20sh6F2aL8GAPiguCaLZfQdJXpmr0XBrcfdCKkMMXmU49TWCn70qocmed+ZU=@vger.kernel.org X-Gm-Message-State: AOJu0Yxr74VO1ZCDgf7aM86oGQG7SWJIpT4vUn1Nd0V//1NAXVSUljPi Sz/05p54y6r006nCFy65w0icbI5nCI3zQyItqGCPvQMjuvSMrBlUWejW9fyuh1kWpAo= X-Gm-Gg: AfdE7ckVX/0T0iAZsJdBKASG0tQuE4G5YUmY/4lLkE5/4VNYdGdta8Aap/1VrzdPxyE 2A/D4byHjODhV38zqBzOK1AuE7bVSl0Lh7bFw92B5DpL+0Lp6TrzUknOZ971FuMecw84dlpU9r0 flGVpHKL94TtQMpwx2e9RNeg2Ycmq8NFgTUdtjVr725mDo9jxtEyEV3ZyjWUZl7hJ0gheBZ7zKQ NwKiRmRLa9CAOx803mb9f6xg/ky1xd0NdwgxmGjzFq7qynioeAXmMjlQFtqKktq4nvVA8LuSzsL zaEertNMEccJIVDpnRWmFSeqVI1k28+IEQdVtm5jK6S5JxTV79RwfRZhjeQtRdP6Q4EApjHhA+T 4/YA3KhEp2Z+2NBj0ry84nuytXmvuIDwAAM3RpW0sI5WLV4MV6o0MCozmmvy/gLwZgLaR1aiTCp XP5lKzgsZxl9eguFmcgLgujOqmq+tyDwsPmsYeiJRXyJFXBv41PPSIhtjoKYU= X-Received: by 2002:a05:600c:1c04:b0:492:3e69:a86f with SMTP id 5b1f17b1804b1-4954a3cff64mr35247915e9.1.1784297688498; Fri, 17 Jul 2026 07:14:48 -0700 (PDT) Received: from ?IPV6:2001:861:2128:c8c0:8e8c:fdab:4545:5849? ([2001:861:2128:c8c0:8e8c:fdab:4545:5849]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4954834fd05sm65413795e9.0.2026.07.17.07.14.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Jul 2026 07:14:47 -0700 (PDT) Message-ID: Date: Fri, 17 Jul 2026 16:14:46 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/4] regulator: dt-bindings: Add Silergy SYR82X allowed modes To: Mark Brown , Krzysztof Kozlowski Cc: lgirdwood@gmail.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20260715155141.128601-1-victor.krawiec@arturia.com> <20260715155141.128601-2-victor.krawiec@arturia.com> <20260717-nostalgic-raptor-of-sunshine-1aba9a@quoll> <94ce2136-3adc-40f5-946f-b56778f6343c@kernel.org> <38adfbda-2cdb-49bb-84d4-aae0a6258f68@sirena.org.uk> Content-Language: en-US From: Victor Krawiec In-Reply-To: <38adfbda-2cdb-49bb-84d4-aae0a6258f68@sirena.org.uk> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 7/17/26 14:44, Mark Brown wrote: > On Fri, Jul 17, 2026 at 02:31:51PM +0200, Krzysztof Kozlowski wrote: > >> So you are adding constants for one device but used in the bindings and >> driver for other? Are they valid there? > > It's one of these devices that's got a bunch of clones from various > manufacturers with minor differences and share a driver. I checked the datasheets and all devices share the same 2 modes which are Auto-PFM and Forced PWM mode. Since devices are all clones and share the same modes the binding part can be generic. I plan to rename the header and its macros to use FAN53555 name and add this property to the binding: regulator-initial-mode: enum: [ 1, 2 ] description: Defined in include/dt-bindings/regulator/fcs,fan53555-regulator.h However the implementation I made in the driver is currently restricted to SYR82X. I could make it generic but I don't have access to the other devices to test it. Best regards Victor