From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755352AbcFQIKx (ORCPT ); Fri, 17 Jun 2016 04:10:53 -0400 Received: from ex13-edg-ou-001.vmware.com ([208.91.0.189]:17841 "EHLO EX13-EDG-OU-001.vmware.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755279AbcFQIKq convert rfc822-to-8bit (ORCPT ); Fri, 17 Jun 2016 04:10:46 -0400 X-Greylist: delayed 902 seconds by postgrey-1.27 at vger.kernel.org; Fri, 17 Jun 2016 04:10:46 EDT Subject: Re: [Pv-drivers] [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email) To: Julian Calaby , Joe Perches References: <57634CBD.8000402@vmware.com> <1466128907097.81812@vmware.com> <1466130787.19647.100.camel@perches.com> <1466132688.19647.105.camel@perches.com> CC: "jejb@linux.vnet.ibm.com" , "Martin K. Petersen" , linux-scsi , "pv-drivers@vmware.com" , "linux-kernel@vger.kernel.org" , Jim Gill From: Thomas Hellstrom X-Enigmail-Draft-Status: N1110 Message-ID: Date: Fri, 17 Jun 2016 09:55:39 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8BIT X-Originating-IP: [10.113.170.11] X-ClientProxiedBy: EX13-CAS-004.vmware.com (10.113.191.54) To EX13-MBX-024.vmware.com (10.113.191.44) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi! IMO we shouldn't have maintainer info mentioned in the source files, since the information is redundant and moreover if we change maintainer a patch touching multiple files would just look odd, and we'd leave a lot of stale info in older kernels. Having the linux git *master* MAINTAINERS file as the authoritative information source for this makes most sense. If there are different maintainers of different parts of a single module we should be able to sort that out internally. Thanks, Thomas On 06/17/2016 05:11 AM, Julian Calaby wrote: > Hi Joe, > > On Fri, Jun 17, 2016 at 1:04 PM, Joe Perches wrote: >> On Fri, 2016-06-17 at 12:44 +1000, Julian Calaby wrote: >>> Hi Joe, >> rehi Julian. > (I always put a salutation on my emails and always finish them with > "Thanks," =) ) > >>> On Fri, Jun 17, 2016 at 12:33 PM, Joe Perches wrote: >> [] >>>> get_maintainer.pl also has a rarely used "--file-emails" option to >>>> scan for what appears to be email addresses in specific files. >>>> >>>> $ ./scripts/get_maintainer.pl -f --file-emails drivers/scsi/vmw_pvscsi.c >>>> Arvind Kumar (maintainer:VMware PVSCSI driver,in file) >>>> VMware PV-Drivers (maintainer:VMware PVSCSI driver) >>>> "James E.J. Bottomley" (maintainer:SCSI SUBSYSTEM) >>>> "Martin K. Petersen" (maintainer:SCSI SUBSYSTEM) >>>> linux-scsi@vger.kernel.org (open list:VMware PVSCSI driver) >>>> linux-kernel@vger.kernel.org (open list) >>>> >>>> note the "in file" after Arvind's name >>> Didn't know this, however my point stands: the maintainer line in the >>> file is redundant if we find maintainers through MAINTAINERS or the >>> get_maintainer.pl script. >> Yes, I'm not suggesting anything else. Jim's name >> should appear in the MAINTAINERS file somewhere. >> >> The question to me is whether or not Jim Gill is >> taking over the maintainership of the entire >> VMware PVSCSI driver or just a few files of it. > As I see it, he's taking over maintainership of all of it: it's only > files are drivers/scsi/vmw_pvscsi.[ch] AFAIK. > > Thanks, >