mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: Justin Tee <justintee8345@gmail.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	"Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc: James Smart <james.smart@broadcom.com>,
	Justin Tee <justin.tee@broadcom.com>,
	Hannes Reinecke <hare@suse.de>,
	linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-hardening@vger.kernel.org
Subject: Re: [PATCH][next] scsi: fc: Avoid -Wflex-array-member-not-at-end warnings
Date: Wed, 27 Aug 2025 07:54:09 +0200	[thread overview]
Message-ID: <c3988bb4-a51e-4d7e-90d6-7c37020cd1b4@embeddedor.com> (raw)
In-Reply-To: <CABPRKS9BVsGhBDmNVbts9QhMsJ-mZhMKDB4u-NnfVcVLsfWrAg@mail.gmail.com>



On 27/08/25 01:13, Justin Tee wrote:
> Hi Martin and Gustavo,
> 
> Regarding the maintainers file, yes Broadcom will push a patch to update soon.
> 
> Regarding Gustavo’s patch, I think we should also update the
> assignment of rdf.desc_len in lpfc_els.c like below.
> 
> diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c
> index fca81e0c7c2e..432761fb49de 100644
> --- a/drivers/scsi/lpfc/lpfc_els.c
> +++ b/drivers/scsi/lpfc/lpfc_els.c
> @@ -3762,7 +3762,7 @@ lpfc_issue_els_rdf(struct lpfc_vport *vport,
> uint8_t retry)
>          memset(prdf, 0, cmdsize);
>          prdf->rdf.fpin_cmd = ELS_RDF;
>          prdf->rdf.desc_len = cpu_to_be32(sizeof(struct lpfc_els_rdf_req) -
> -                                        sizeof(struct fc_els_rdf));
> +                                        sizeof(struct fc_els_rdf_hdr));

Good catch! :)

Thanks
-Gustavo


      reply	other threads:[~2025-08-27  5:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-12 14:13 Gustavo A. R. Silva
2025-08-26  1:53 ` Martin K. Petersen
2025-08-26 23:13   ` Justin Tee
2025-08-27  5:54     ` Gustavo A. R. Silva [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c3988bb4-a51e-4d7e-90d6-7c37020cd1b4@embeddedor.com \
    --to=gustavo@embeddedor.com \
    --cc=gustavoars@kernel.org \
    --cc=hare@suse.de \
    --cc=james.smart@broadcom.com \
    --cc=justin.tee@broadcom.com \
    --cc=justintee8345@gmail.com \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®