From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5748FC4332F for ; Mon, 7 Mar 2022 12:26:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242259AbiCGM1D (ORCPT ); Mon, 7 Mar 2022 07:27:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34910 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242301AbiCGM0x (ORCPT ); Mon, 7 Mar 2022 07:26:53 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C0A9582D34 for ; Mon, 7 Mar 2022 04:25:53 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 55D8461119 for ; Mon, 7 Mar 2022 12:25:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CD6BCC340E9; Mon, 7 Mar 2022 12:25:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1646655952; bh=Ghs63fYthC1CW9AbnkUpsxT3KRIqjn2YMnqNPVu9Z9A=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Cfvm4qBjvVqDUD41LgVmaVdXePN17HbVw1cNKxXHi+koU8FzymcIF5bA3seLlGXJ+ hHp31fad1v5ZmIsUFvjJB80HpsldqY85UEpMkZOeRvJKC9vzKwRXzwBVy0sW3WzLUf vL/PkjV+B2MFgfR0LeRa25VErcNN7bu9KharV2rgU+awTgtz8f5SWpvYLF7VYjye8z WWUR7ZxCAA2ciBBSoIpNk2w2fPGWqB2XpjCJ+LRoOBmU2/GWafDxQttxcBTNi2xDXc XJA4LMNQcAqRGvejYstDkd8Rd9hRKP2FNZ6/TFHBOVJ71yCGyqYM6U8GsyKPwJMq65 vbWwtFvr5WuVQ== Message-ID: Date: Mon, 7 Mar 2022 14:25:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH] mtd: rawnand: omap2: Actually prevent invalid configuration and build error Content-Language: en-US To: Miquel Raynal Cc: Randy Dunlap , Guenter Roeck , krzysztof.kozlowski@canonical.com, vigneshr@ti.com, nm@ti.com, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org References: <20220220004415.GA1519274@roeck-us.net> <4bbe337e-8cd8-a4d6-303d-d5aa21bee2e0@infradead.org> <20220304165451.0129012e@xps13> <6c09de15-1ab2-5ca8-7003-69ff3f7c4dc5@kernel.org> <20220307110357.20d50176@xps13> From: Roger Quadros In-Reply-To: <20220307110357.20d50176@xps13> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Miquel, On 07/03/2022 12:03, Miquel Raynal wrote: > Hi Roger, > > rogerq@kernel.org wrote on Sat, 5 Mar 2022 00:50:14 +0200: > >> Hi Miquel, >> >> On 04/03/2022 17:54, Miquel Raynal wrote: >>> Hi Guenter, Roger, >>> >>> rdunlap@infradead.org wrote on Sat, 26 Feb 2022 22:55:28 -0800: >>> >>>> On 2/19/22 16:44, Guenter Roeck wrote: >>>>> On Sat, Feb 19, 2022 at 09:36:00PM +0200, Roger Quadros wrote: >>>>>> The root of the problem is that we are selecting symbols that have >>>>>> dependencies. This can cause random configurations that can fail. >>>>>> The cleanest solution is to avoid using select. >>>>>> >>>>>> This driver uses interfaces from the OMAP_GPMC driver so we have to >>>>>> depend on it instead. >>>>>> >>>>>> Fixes: 4cd335dae3cf ("mtd: rawnand: omap2: Prevent invalid configuration and build error") >>>>>> Signed-off-by: Roger Quadros >>>>> >>>>> Tested-by: Guenter Roeck >>>> >>>> Tested-by: Randy Dunlap >>> >>> Sorry for noticing that just now, but there is still a problem with >>> this patch: we now always compile-in the OMAP_GPMC driver whenever we >>> need the NAND controller, even though it is not needed. This grows the >>> kernel for no reason. >> >> Sorry, I did not understand what you meant. >> >> We no longer explicitly enable OMAP_GPMC since we dropped the "select". >> This fixes all build issues that were reported recently. >> >> MTD_NAND_OMAP2 will not be enabled if OMAP_GPMC is not since we added >> the "depends on". This fixes the original build issue that we started to >> fix with select initially. > > Yes, this side is fine. > > In the initial commit, you proposed: > > --- a/drivers/mtd/nand/raw/Kconfig > +++ b/drivers/mtd/nand/raw/Kconfig > @@ -42,7 +42,8 @@ config MTD_NAND_OMAP2 > tristate "OMAP2, OMAP3, OMAP4 and Keystone NAND controller" > depends on ARCH_OMAP2PLUS || ARCH_KEYSTONE || ARCH_K3 || COMPILE_TEST > depends on HAS_IOMEM > + select OMAP_GPMC if ARCH_K3 > > Which creates a dependency over OMAP_GPMC only for a single > architecture. Which means that other OMAP platforms do not necessarily > need OMAP_GPMC for the NAND controller to work. Now, you propose: No that is not true. Other platforms that need MTD_NAND_OMAP2 are explicitly selecting OMAP_GPMC i.e. in arch/arm/mach-omap2/Kconfig > > --- a/drivers/mtd/nand/raw/Kconfig > +++ b/drivers/mtd/nand/raw/Kconfig > @@ -42,8 +42,7 @@ config MTD_NAND_OMAP2 > tristate "OMAP2, OMAP3, OMAP4 and Keystone NAND controller" > depends on ARCH_OMAP2PLUS || ARCH_KEYSTONE || ARCH_K3 || COMPILE_TEST > depends on HAS_IOMEM > depends on OMAP_GPMC > > This means any of the other OMAP architectures will compile the GPMC > driver even though they might not need it, which would unnecessarily > increase the kernel size. > > Am I missing something? MTD_NAND_OMAP2 NAND controller is a submodule of the OMAP GPMC IP. So it cannot work without OMAP_GPMC driver. Hope this clarifies the doubts. > >>> In fact, Roger once said: >>> >>> "We will figure out how to enable OMAP_GPMC for K3 architecture >>> some other way." >>> >>> It turns out this is not what was finally proposed. Could we try yet >>> another solution? >> >> This issue is still present i.e. we cannot enable MTD_NAND_OMAP2 driver on >> K3 platform since OMAP_GPMC config is hidden and not select-able >> by user or defconfig file. >> >> But it is not yet a deal breaker since NAND on K3 is not yet enabled upstream. >> >> For this I think OMAP_GPMC has to be a visible config entry and select-able >> from a defconfig file as I had done initially [1]. >> >> Now we have a lot of explanation to write as to why we need to do it ;) > > We certainly do :) > >> [1] - https://lore.kernel.org/lkml/20211123102607.13002-3-rogerq@kernel.org/ >> > > Thanks, > Miquèl cheers, -roger