From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54711C3F2D0 for ; Fri, 28 Feb 2020 08:35:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 33844246A2 for ; Fri, 28 Feb 2020 08:35:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726793AbgB1Ifq (ORCPT ); Fri, 28 Feb 2020 03:35:46 -0500 Received: from szxga04-in.huawei.com ([45.249.212.190]:11120 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726063AbgB1Ifp (ORCPT ); Fri, 28 Feb 2020 03:35:45 -0500 Received: from DGGEMS407-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 2A02FE226D94DD5082DD; Fri, 28 Feb 2020 16:35:43 +0800 (CST) Received: from [10.134.22.195] (10.134.22.195) by smtp.huawei.com (10.3.19.207) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 28 Feb 2020 16:35:38 +0800 Subject: Re: [PATCH 1/2] f2fs: Fix mount failure due to SPO after a successful online resize FS To: Sahitya Tummala , Jaegeuk Kim , CC: References: <1582799978-22277-1-git-send-email-stummala@codeaurora.org> From: Chao Yu Message-ID: Date: Fri, 28 Feb 2020 16:35:37 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1582799978-22277-1-git-send-email-stummala@codeaurora.org> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sahitya, Good catch. On 2020/2/27 18:39, Sahitya Tummala wrote: > Even though online resize is successfully done, a SPO immediately > after resize, still causes below error in the next mount. > > [ 11.294650] F2FS-fs (sda8): Wrong user_block_count: 2233856 > [ 11.300272] F2FS-fs (sda8): Failed to get valid F2FS checkpoint > > This is because after FS metadata is updated in update_fs_metadata() > if the SBI_IS_DIRTY is not dirty, then CP will not be done to reflect > the new user_block_count. > > Signed-off-by: Sahitya Tummala > --- > fs/f2fs/gc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c > index a92fa49..a14a75f 100644 > --- a/fs/f2fs/gc.c > +++ b/fs/f2fs/gc.c > @@ -1577,6 +1577,7 @@ int f2fs_resize_fs(struct f2fs_sb_info *sbi, __u64 block_count) > > update_fs_metadata(sbi, -secs); > clear_sbi_flag(sbi, SBI_IS_RESIZEFS); Need a barrier here to keep order in between above code and set_sbi_flag(DIRTY)? > + set_sbi_flag(sbi, SBI_IS_DIRTY); > err = f2fs_sync_fs(sbi->sb, 1); > if (err) { > update_fs_metadata(sbi, secs); Do we need to add clear_sbi_flag(, SBI_IS_DIRTY) into update_fs_metadata(), so above path can be covered as well? Thanks, >