From: Krzysztof Kozlowski <krzk@kernel.org>
To: Nam Tran <trannamatk@gmail.com>, krzk+dt@kernel.org
Cc: pavel@kernel.org, lee@kernel.org, robh@kernel.org,
conor+dt@kernel.org, devicetree@vger.kernel.org,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/3] dt-bindings: leds: Add LP5812 LED driver
Date: Tue, 1 Apr 2025 17:04:36 +0200 [thread overview]
Message-ID: <c39e5f6a-8e5b-496f-a284-74f7bc758ddd@kernel.org> (raw)
In-Reply-To: <20250401142935.50906-1-trannamatk@gmail.com>
On 01/04/2025 16:29, Nam Tran wrote:
> On Mon, 31 Mar 2025, Krzysztof Kozlowski wrote:
>
>> Please do not explain me how DT works, we all know. You do not have
>> child node. If you disagree - point me to the line in schema having it.
>
> Thank you for your feedback.
> I now understand that my schema does not define child nodes, so #address-cells and #size-cells should not be included.
> I will update the schema accordingly as shown below.
This has... What are we talking here about? I commented only about that
patch.
You claimed:
>Nam: I included the #address-cells and #size-cells properties to
resolve a warning encountered when running:
which was obviously not true. You could not have such errors, because
you did not have children. You disagreed with me so you got response
like that.
If you decide to add children, then you will need address and size
cells, but that's a different patch.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-04-01 15:04 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-06 17:21 [PATCH v3 0/3] leds: add new LED driver for TI LP5812 Nam Tran
2025-03-06 17:21 ` [PATCH v3 1/3] dt-bindings: leds: Add LP5812 LED driver Nam Tran
2025-03-07 8:42 ` Krzysztof Kozlowski
2025-03-18 13:56 ` Nam Tran
2025-03-18 18:59 ` Krzysztof Kozlowski
2025-03-31 15:31 ` Nam Tran
2025-03-31 15:42 ` Krzysztof Kozlowski
2025-04-01 14:29 ` Nam Tran
2025-04-01 15:04 ` Krzysztof Kozlowski [this message]
2025-03-06 17:21 ` [PATCH v3 2/3] arm64: dts: Add LP5812 LED node for Raspberry Pi 4 Model B Nam Tran
2025-03-07 8:42 ` Krzysztof Kozlowski
2025-03-07 8:43 ` Krzysztof Kozlowski
2025-03-06 17:21 ` [PATCH v3 3/3] leds: add new LED driver for TI LP5812 Nam Tran
2025-03-06 18:53 ` Christophe JAILLET
2025-03-07 8:52 ` Krzysztof Kozlowski
2025-03-24 4:44 ` Nam Tran
2025-03-10 1:21 ` kernel test robot
2025-03-11 11:20 ` kernel test robot
2025-03-18 13:35 ` Nam Tran
2025-03-18 18:54 ` Krzysztof Kozlowski
2025-03-24 4:39 ` Nam Tran
2025-03-20 15:50 ` Lee Jones
2025-03-24 4:34 ` Nam Tran
2025-03-25 19:15 ` Markus Elfring
2025-03-27 15:48 ` Nam Tran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c39e5f6a-8e5b-496f-a284-74f7bc758ddd@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@kernel.org \
--cc=robh@kernel.org \
--cc=trannamatk@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®