mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ivaylo Ivanov <ivo.ivanov.ivanov1@gmail.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Alim Akhtar <alim.akhtar@samsung.com>
Cc: linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/3] dt-bindings: arm: samsung: document g0s board binding
Date: Wed, 19 Feb 2025 12:29:59 +0200	[thread overview]
Message-ID: <c39e6058-0649-452f-9a21-d9d5a28ccc06@gmail.com> (raw)
In-Reply-To: <adbbd60e-c72c-46f3-87e5-198ab1d49d9f@kernel.org>

On 2/19/25 10:35, Krzysztof Kozlowski wrote:
> On 15/02/2025 14:04, Ivaylo Ivanov wrote:
>> Add binding for the Samsung Galaxy S22+ (SM-S906B) board, which is
>> based on the Samsung Exynos2200 SoC.
>>
>> Signed-off-by: Ivaylo Ivanov <ivo.ivanov.ivanov1@gmail.com>
>> ---
>>  .../devicetree/bindings/arm/samsung/samsung-boards.yaml     | 6 ++++++
>>  1 file changed, 6 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml b/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml
>> index fab29f95d..bb3f6a0e1 100644
>> --- a/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml
>> +++ b/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml
>> @@ -45,6 +45,12 @@ properties:
>>            - const: samsung,aries
>>            - const: samsung,s5pv210
>>  
>> +      - description: Exynos2200 based boards
>> +        items:
>> +          - enum:
>> +              - samsung,g0s                     # Samsung Galaxy S22+ (SM-S906B)
>
> What does g0s stand for?

Samsung started codenaming their S series like that since ~S20. I'd actually
much rather use something like samsung,s22p but since 990 devices upstream
already use the weird codenames, I've decided to do the same.

I'll mention G0S it in the commit message next revision.

Best regards,
Ivaylo

>  Sound a bit cryptic and you did not use it in
> commit msg to explain the origin.
>
>
> Best regards,
> Krzysztof


  reply	other threads:[~2025-02-19 10:30 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-15 13:04 [PATCH v1 0/3] arm64: dts: exynos: add initial support for Samsung Galaxy S22+ Ivaylo Ivanov
2025-02-15 13:04 ` [PATCH v1 1/3] dt-bindings: arm: samsung: document g0s board binding Ivaylo Ivanov
2025-02-19  8:35   ` Krzysztof Kozlowski
2025-02-19 10:29     ` Ivaylo Ivanov [this message]
2025-02-15 13:04 ` [PATCH v1 2/3] arm64: dts: exynos: add initial support for exynos2200 SoC Ivaylo Ivanov
2025-02-19  8:41   ` Krzysztof Kozlowski
2025-02-19 10:34     ` Ivaylo Ivanov
2025-02-15 13:05 ` [PATCH v1 3/3] arm64: dts: exynos: add initial support for Samsung Galaxy S22+ Ivaylo Ivanov
2025-02-19  0:42 ` [PATCH v1 0/3] " Rob Herring (Arm)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c39e6058-0649-452f-9a21-d9d5a28ccc06@gmail.com \
    --to=ivo.ivanov.ivanov1@gmail.com \
    --cc=alim.akhtar@samsung.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®