From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DD45C433F5 for ; Tue, 24 May 2022 02:23:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229940AbiEXCXF (ORCPT ); Mon, 23 May 2022 22:23:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48382 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233295AbiEXCXD (ORCPT ); Mon, 23 May 2022 22:23:03 -0400 Received: from alexa-out.qualcomm.com (alexa-out.qualcomm.com [129.46.98.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D7D9D9CC9D; Mon, 23 May 2022 19:23:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1653358982; x=1684894982; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=0de7OZdEDnotdHJVDJmUKMnd7Q0VBtn1A0ZCxSDuzPQ=; b=bCK74XKGe2HxcgEttobw7Us0WHqYzzAv/NopWsCV7T7ZD63ml77meuP8 yQxojCCEh3ilnFU3p5I7uWjA+24KjZboEAkxeyujxybx2C05pOEZwu/cS KIFdc3rrl379m2O852yAcTv5f8J6p/o0/6beoZ6oE6WDAou9ltmXZj35J Q=; Received: from ironmsg09-lv.qualcomm.com ([10.47.202.153]) by alexa-out.qualcomm.com with ESMTP; 23 May 2022 19:23:02 -0700 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg09-lv.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 May 2022 19:23:01 -0700 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Mon, 23 May 2022 19:23:00 -0700 Received: from [10.79.43.230] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Mon, 23 May 2022 19:22:57 -0700 Subject: Re: [PATCH v4 2/3] dt-bindings: remoteproc: qcom: Convert SC7280 MSS bindings to YAML To: Stephen Boyd , , , CC: , , , , , , , References: <1652978825-5304-1-git-send-email-quic_sibis@quicinc.com> <1652978825-5304-3-git-send-email-quic_sibis@quicinc.com> <1289c2e4-5607-b515-88b1-f44585e62cd3@quicinc.com> From: Sibi Sankar Message-ID: Date: Tue, 24 May 2022 07:52:53 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/21/22 1:40 AM, Stephen Boyd wrote: > Quoting Sibi Sankar (2022-05-20 11:46:58) >> On 5/20/22 4:05 AM, Stephen Boyd wrote: >>> Quoting Sibi Sankar (2022-05-19 09:47:04) >>>> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sc7280-mss-pil.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sc7280-mss-pil.yaml >>>> new file mode 100644 >>>> index 000000000000..a936d84eefa6 >>>> --- /dev/null >>>> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,sc7280-mss-pil.yaml >>>> + resets = <&aoss_reset AOSS_CC_MSS_RESTART>, >>>> + <&pdc_reset PDC_MODEM_SYNC_RESET>; >>>> + reset-names = "mss_restart", "pdc_reset"; >>>> + >>>> + qcom,halt-regs = <&tcsr_mutex 0x23000 0x25000 0x28000 0x33000>; >>>> + qcom,ext-regs = <&tcsr 0x10000 0x10004 &tcsr_mutex 0x26004 0x26008>; >>> >>> Because it's two items I'd expect: >>> >>> <&tcsr 0x10000 0x10004>, <&tcsr_mutex 0x26004 0x26008>; >> >> I guess both the ways work since the driver uses >> of_parse_phandle_with_fixed_args. > > See commit 39bd2b6a3783 ("dt-bindings: Improve phandle-array schemas") > for why the way you have it is not preferred. Sure, I'll fix the dt up and update the example. -Sibi >