From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f173.google.com (mail-lj1-f173.google.com [209.85.208.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6EF223203B4 for ; Fri, 16 Jan 2026 09:24:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768555497; cv=none; b=UT/Sgh+Bnj32hWibBXov3ipbykwX5Gzdj7ZkJLx2SJj37JbWQMGOPz7kxr5qkOWuaA4nsHbvr1BC9Ug14xhey3EkdfopCfBs1UgJOf3MZDfpikKXko4ZlZvJ9VMGP82898s8vPj2u7WnECCwiwNUcANmbGreSDBDOz9w6dye9hU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768555497; c=relaxed/simple; bh=F1dBOslSNJdmGhuKyZQUTNwmlqPoJ944FJFaQAUDiz0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Rne3Fh/m2Udcl6crBRrRLurYIqKqFMCC7lfO9Vq3hnmPMhzeyFhRmURIkbP2Dh2we+kP0Ljp4OzcbUAnZV9impMnIpA/wXB2UdmHqLrDtj9M5AAbchQrRZbN/ClEK7H0fTRZjl/99BEqrvcYVyls85NX7NrLTglEovkjpzfqkEM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Tn1m8XTq; arc=none smtp.client-ip=209.85.208.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Tn1m8XTq" Received: by mail-lj1-f173.google.com with SMTP id 38308e7fff4ca-382ff96b169so1839461fa.2 for ; Fri, 16 Jan 2026 01:24:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1768555494; x=1769160294; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=RUi1WEtiQf1a2/X/kibJLzk8TGAQoRCMC8REEAl19os=; b=Tn1m8XTq+AMhynzbcolJZzo+b1QfjjDewJckwJgTiloPIkQw4tPNehpHKTzgyqLd1B ic//+rQAc6if/9FEd0uwiNucsCaMZHitL4RDlEoKWO4yamsJ9udZUTIDBstiS8cmSWJd TQIEdcP1PXK2ifB274SoXyLhiK51ImDs2Wbr3K2FGkKgjbeHzbt5L/Ije8NNvJhMzUIL FdhTDeG04UbD0k7YxCe5fMfviEx6OV/xIEglWGAdwgIUovTL2TYcmRUFx7LbTDIQTA4f nbM/cQRBVbzM3npJQVhRvWLC7dal0OH3BbvixtH9Qc6wdzD3799SJfJ+rmLXoV1J10su Ds8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768555494; x=1769160294; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=RUi1WEtiQf1a2/X/kibJLzk8TGAQoRCMC8REEAl19os=; b=HBOOQWYr0VQIxPV0fEgk8kmPbCHnL9Zxg4W62TtnAVTlMF1A293p4YRUsDRQMRMw5J c6KMyC0O1G3z0ULhAFbLkxueNVMGJHUWPnP/zhB5hMveVI+eOCYYRbpMSnbttrvt95NT pW9aOvZAkxV7h9ivjI9Ziy3/j7iNjmKv+Xp6cyCsFusF+l68XsG3CZUpTy5QJ6dIPRIW ij9MSR+V1wm0R9bRs7OqrsA54oh4PKWknCzVLmm2QColMWwkZxBKizYHUTOu23JtozZQ /m1vxxCslcoOyQlY5OMqZZB6tWRStWeMNHlvz0CHzcnMymZp2CyFhEWauUp5Yog4h/BA J4BA== X-Gm-Message-State: AOJu0Yxy9EY+XpTw8lNwPbBXqpEGuL0RRpqXvtMoqhpQoJrF/L6QBJVQ hFc0K39d/FC9sZGVpMfwokFc2TnmEYcWrj8kSBwGBZ/Kohza6+3WZNdJinqm/sPq66Uo02Jd7zZ ePbq8 X-Gm-Gg: AY/fxX5e+eWurP/FTho4nWo+tZxCp7S4XfGT/lFsxTUls6UPVDOuS+5GAZTc1TjxEsq Q40gZ9glC0XTdKZmGHQVvzqKUW5biOb+azI+ggPTZ+CW73reCFOAXOYByH51BB1+3J83k5eCC0p 9kMAabPmONz/wPfGJy6B/WyKVud+3ZMD76rft0XiPmpO11881WIrRF/aCpZRX83a/3Cm4NtSms0 xkN+lJHXAaB6PwWplMIC61JuauBAOV66i2bAQs84yupX1q1bzlr1RHbDIq6Gl8F+btKi6n+LOj1 s++ZN4ICmg2A4jZjfJDGHCxOMZwG2Ct6Vn/uCv3498l6T3DC2mO3Vlc76fR0pl2hG5yjSWQpf5t xrYvJBGighGAYCvgsuROCST6ArsjalxajPh6S8jzsy2BjHCk0M/rNI74hYxZtAk4y62yLeIeX4r 6D4WnGEXuyDjVheidmEBYdNvIhmwgUBDJwP1Kjrko5XdgwuVucKE9+uusCByKsAomJcQ== X-Received: by 2002:a05:651c:41c4:b0:383:53e2:ad29 with SMTP id 38308e7fff4ca-383842f990amr4601421fa.6.1768555492152; Fri, 16 Jan 2026 01:24:52 -0800 (PST) Received: from [192.168.1.100] (91-159-24-186.elisa-laajakaista.fi. [91.159.24.186]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-38384fb8fb1sm5639921fa.46.2026.01.16.01.24.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 Jan 2026 01:24:51 -0800 (PST) Message-ID: Date: Fri, 16 Jan 2026 11:24:50 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 1/3] media: qcom: camss: Add common TPG support To: Bryan O'Donoghue , Wenmeng Liu , Robert Foss , Todor Tomov , Mauro Carvalho Chehab Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20260113-camss_tpg-v8-0-fa2cb186a018@oss.qualcomm.com> <20260113-camss_tpg-v8-1-fa2cb186a018@oss.qualcomm.com> <87a31d4e-b604-4b9a-92e9-75fd2748489a@linaro.org> <98a26638-675b-4654-a940-898ba9e1af9c@oss.qualcomm.com> <641421a6-bf42-49f4-8f94-9cb0bce8e97c@linaro.org> From: Vladimir Zapolskiy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/15/26 17:54, Bryan O'Donoghue wrote: > On 15/01/2026 02:58, Vladimir Zapolskiy wrote: >>>> Writing proper values to registers should be a concern on the driver >>>> level, >>>> it sounds improper to push this simple task and responsibility to >>>> userspace. >>> >>> I think we should stick to the same format as is already upstream for >>> the CSID version of this - which is the same data. >>> >> >> It is not the same and it will not be the same, if the currently presented >> version is taken. If TPG modes in CSID are continuous, here they are not, >> so it makes a big difference for userspace, and better it should be >> removed. > > Not sure I follow you here. > > The set of strings for camss-csid we have now is: > > const char * const csid_testgen_modes[] = { > "Disabled", > "Incrementing", > "Alternating 0x55/0xAA", > "All Zeros 0x00", > "All Ones 0xFF", > "Pseudo-random Data", > "User Specified", > "Complex pattern", > "Color box", > "Color bars", > NULL > }; > > Wengmeng has > > +const char * const testgen_payload_modes[] = { > + "Disabled", > + "Incrementing", > + "Alternating 0x55/0xAA", > + "Reserved", > + "Reserved", > + "Pseudo-random Data", > + "User Specified", > + "Reserved", > + "Reserved", > + "Color bars", > + "Reserved" > +}; > > I think the "Reserved" should go away but, other than that we should That's what I've asked, there is no dispute. > keep namespace consistency between CSID-TPG and standalone-TPG. > When "consistency" is not defined, it's just a fine sounding buzzword. CSID TPG has: * modes, which numbers are continuously incremented, * the number of TPG modes for a user is expectedly the number of TPG modes. The displayed v8 of the "standalone TPG" broke both assumptions from above, so there is no more "consistency" between two TPGs, while I explicitly ask to preserve the "consistency". -- Best wishes, Vladimir