From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 986B5C0044C for ; Wed, 7 Nov 2018 07:03:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3E5942086B for ; Wed, 7 Nov 2018 07:03:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=yandex-team.ru header.i=@yandex-team.ru header.b="Q97BEWfY"; dkim=pass (1024-bit key) header.d=yandex-team.ru header.i=@yandex-team.ru header.b="XUbkCF0t" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3E5942086B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=yandex-team.ru Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730452AbeKGQcC (ORCPT ); Wed, 7 Nov 2018 11:32:02 -0500 Received: from forwardcorp1j.cmail.yandex.net ([5.255.227.105]:33077 "EHLO forwardcorp1j.cmail.yandex.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726298AbeKGQcC (ORCPT ); Wed, 7 Nov 2018 11:32:02 -0500 Received: from mxbackcorp2j.mail.yandex.net (mxbackcorp2j.mail.yandex.net [IPv6:2a02:6b8:0:1619::119]) by forwardcorp1j.cmail.yandex.net (Yandex) with ESMTP id 1A2082110F; Wed, 7 Nov 2018 10:02:57 +0300 (MSK) Received: from smtpcorp1p.mail.yandex.net (smtpcorp1p.mail.yandex.net [2a02:6b8:0:1472:2741:0:8b6:10]) by mxbackcorp2j.mail.yandex.net (nwsmtp/Yandex) with ESMTP id uvyeP5A3iy-2ul8Aufb; Wed, 07 Nov 2018 10:02:57 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru; s=default; t=1541574177; bh=LBkvXVCkiEyzx/R46y6sjrNSXlNCubsrlhs8k0kpzyg=; h=Subject:To:Cc:References:From:Message-ID:Date:In-Reply-To; b=Q97BEWfYv9K70RLcHLmj+5JCI6ZEldFhcDXe3BjRj6vw6IswLabbaaIdMvozuIlwj DsuVra+4bPpsOg5ZhhsDXTG7zMZhYc6VLU9w9eQ4plfV6YFS/0symhg2I7F7XCr7aw I4SWv/FlWzGoolYXVJ99gYkuWoUQyzNFyYgfReAI= Received: from dynamic-red.dhcp.yndx.net (dynamic-red.dhcp.yndx.net [2a02:6b8:0:40c:2501:1cc0:44e4:e39a]) by smtpcorp1p.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id 0kqTivFmpb-2uJKweGO; Wed, 07 Nov 2018 10:02:56 +0300 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client certificate not present) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru; s=default; t=1541574176; bh=LBkvXVCkiEyzx/R46y6sjrNSXlNCubsrlhs8k0kpzyg=; h=Subject:To:Cc:References:From:Message-ID:Date:In-Reply-To; b=XUbkCF0tzll/JyNqIv0aYBURr1b0qZWaM49Shq1Po4yx2ltcTBRKHZ4ilduT1A+lM HDCDb++/kUnq3z5WfGaaImzPVuD/s6sl1dHlNtCtQg8yT0O2xs+sl4ilrjFDtKDHsG qlTcefX+7giqbYFoF1XGi6+2XLhMS/QMGW9sxBts= Authentication-Results: smtpcorp1p.mail.yandex.net; dkim=pass header.i=@yandex-team.ru Subject: Re: [PATCH v1 0/4]mm: convert totalram_pages, totalhigh_pages and managed pages to atomic To: Arun KS Cc: keescook@chromium.org, minchan@kernel.org, getarunks@gmail.com, gregkh@linuxfoundation.org, akpm@linux-foundation.org, mhocko@kernel.org, vbabka@suse.cz, linux-kernel@vger.kernel.org, linux-mm@kvack.org, julia.lawall@lip6.fr References: <1540551662-26458-1-git-send-email-arunks@codeaurora.org> <9b210d4cc9925caf291412d7d45f16d7@codeaurora.org> <63d9f48c-e39f-d345-0fb6-2f04afe769a2@yandex-team.ru> <08a61c003eed0280fd82f6200debcbca@codeaurora.org> <10c88df6-dbb1-7490-628c-055d59b5ad8e@yandex-team.ru> <22fa2222012341a54f6b0b6aea341aa2@codeaurora.org> From: Konstantin Khlebnikov Message-ID: Date: Wed, 7 Nov 2018 10:02:55 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <22fa2222012341a54f6b0b6aea341aa2@codeaurora.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-CA Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06.11.2018 11:43, Arun KS wrote: > On 2018-11-06 14:07, Konstantin Khlebnikov wrote: >> On 06.11.2018 11:30, Arun KS wrote: >>> On 2018-11-06 13:47, Konstantin Khlebnikov wrote: >>>> On 06.11.2018 8:38, Arun KS wrote: >>>>> Any comments? >>>> >>>> Looks good. >>>> Except unclear motivation behind this change. >>>> This should be in comment of one of patch. >>> >>> totalram_pages, zone->managed_pages and totalhigh_pages are sometimes modified outside managed_page_count_lock. Hence convert these >>> variable to atomic to avoid readers potentially seeing a store tear. >> >> So, this is just theoretical issue or splat from sanitizer. >> After boot memory online\offline are strictly serialized by rw-semaphore. > > Few instances which can race with hot add. Please see below, > https://patchwork.kernel.org/patch/10627521/ Could you point what exactly are you fixing with this set? from v2: > totalram_pages, zone->managed_pages and totalhigh_pages updates > are protected by managed_page_count_lock, but readers never care > about it. Convert these variables to atomic to avoid readers > potentially seeing a store tear. This? Aligned unsigned long almost always stored at once. To make it completely correct you could replace a += b; with WRITE_ONCE(a, a + b); > > Regards, > Arun > >> >>> >>> Will update the comment. >>> >>> Regards, >>> Arun >>> >>>> >>>> Reviewed-by: Konstantin Khlebnikov >>>> >>>>> >>>>> Regards, >>>>> Arun >>>>> >>>>> On 2018-10-26 16:30, Arun KS wrote: >>>>>> This series convert totalram_pages, totalhigh_pages and >>>>>> zone->managed_pages to atomic variables. >>>>>> >>>>>> The patch was comiple tested on x86(x86_64_defconfig & i386_defconfig) >>>>>> on tip of linux-mmotm. And memory hotplug tested on arm64, but on an >>>>>> older version of kernel. >>>>>> >>>>>> Arun KS (4): >>>>>>   mm: Fix multiple evaluvations of totalram_pages and managed_pages >>>>>>   mm: Convert zone->managed_pages to atomic variable >>>>>>   mm: convert totalram_pages and totalhigh_pages variables to atomic >>>>>>   mm: Remove managed_page_count spinlock >>>>>> >>>>>>  arch/csky/mm/init.c                           |  4 +- >>>>>>  arch/powerpc/platforms/pseries/cmm.c          | 10 ++-- >>>>>>  arch/s390/mm/init.c                           |  2 +- >>>>>>  arch/um/kernel/mem.c                          |  3 +- >>>>>>  arch/x86/kernel/cpu/microcode/core.c          |  5 +- >>>>>>  drivers/char/agp/backend.c                    |  4 +- >>>>>>  drivers/gpu/drm/amd/amdkfd/kfd_crat.c         |  2 +- >>>>>>  drivers/gpu/drm/i915/i915_gem.c               |  2 +- >>>>>>  drivers/gpu/drm/i915/selftests/i915_gem_gtt.c |  4 +- >>>>>>  drivers/hv/hv_balloon.c                       | 19 +++---- >>>>>>  drivers/md/dm-bufio.c                         |  2 +- >>>>>>  drivers/md/dm-crypt.c                         |  2 +- >>>>>>  drivers/md/dm-integrity.c                     |  2 +- >>>>>>  drivers/md/dm-stats.c                         |  2 +- >>>>>>  drivers/media/platform/mtk-vpu/mtk_vpu.c      |  2 +- >>>>>>  drivers/misc/vmw_balloon.c                    |  2 +- >>>>>>  drivers/parisc/ccio-dma.c                     |  4 +- >>>>>>  drivers/parisc/sba_iommu.c                    |  4 +- >>>>>>  drivers/staging/android/ion/ion_system_heap.c |  2 +- >>>>>>  drivers/xen/xen-selfballoon.c                 |  6 +-- >>>>>>  fs/ceph/super.h                               |  2 +- >>>>>>  fs/file_table.c                               |  7 +-- >>>>>>  fs/fuse/inode.c                               |  2 +- >>>>>>  fs/nfs/write.c                                |  2 +- >>>>>>  fs/nfsd/nfscache.c                            |  2 +- >>>>>>  fs/ntfs/malloc.h                              |  2 +- >>>>>>  fs/proc/base.c                                |  2 +- >>>>>>  include/linux/highmem.h                       | 28 ++++++++++- >>>>>>  include/linux/mm.h                            | 27 +++++++++- >>>>>>  include/linux/mmzone.h                        | 15 +++--- >>>>>>  include/linux/swap.h                          |  1 - >>>>>>  kernel/fork.c                                 |  5 +- >>>>>>  kernel/kexec_core.c                           |  5 +- >>>>>>  kernel/power/snapshot.c                       |  2 +- >>>>>>  lib/show_mem.c                                |  2 +- >>>>>>  mm/highmem.c                                  |  4 +- >>>>>>  mm/huge_memory.c                              |  2 +- >>>>>>  mm/kasan/quarantine.c                         |  2 +- >>>>>>  mm/memblock.c                                 |  6 +-- >>>>>>  mm/memory_hotplug.c                           |  4 +- >>>>>>  mm/mm_init.c                                  |  2 +- >>>>>>  mm/oom_kill.c                                 |  2 +- >>>>>>  mm/page_alloc.c                               | 71 +++++++++++++-------------- >>>>>>  mm/shmem.c                                    |  7 +-- >>>>>>  mm/slab.c                                     |  2 +- >>>>>>  mm/swap.c                                     |  2 +- >>>>>>  mm/util.c                                     |  2 +- >>>>>>  mm/vmalloc.c                                  |  4 +- >>>>>>  mm/vmstat.c                                   |  4 +- >>>>>>  mm/workingset.c                               |  2 +- >>>>>>  mm/zswap.c                                    |  4 +- >>>>>>  net/dccp/proto.c                              |  7 +-- >>>>>>  net/decnet/dn_route.c                         |  2 +- >>>>>>  net/ipv4/tcp_metrics.c                        |  2 +- >>>>>>  net/netfilter/nf_conntrack_core.c             |  7 +-- >>>>>>  net/netfilter/xt_hashlimit.c                  |  5 +- >>>>>>  net/sctp/protocol.c                           |  7 +-- >>>>>>  security/integrity/ima/ima_kexec.c            |  2 +- >>>>>>  58 files changed, 195 insertions(+), 144 deletions(-)