From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A63CC54E76 for ; Mon, 20 Nov 2023 13:23:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233227AbjKTNXp convert rfc822-to-8bit (ORCPT ); Mon, 20 Nov 2023 08:23:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34338 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233330AbjKTNX3 (ORCPT ); Mon, 20 Nov 2023 08:23:29 -0500 Received: from rtits2.realtek.com.tw (rtits2.realtek.com [211.75.126.72]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E641D6D; Mon, 20 Nov 2023 05:23:04 -0800 (PST) X-SpamFilter-By: ArmorX SpamTrap 5.78 with qID 3AKDMZCI0801065, This message is accepted by code: ctloc85258 Received: from mail.realtek.com (rtexh36506.realtek.com.tw[172.21.6.27]) by rtits2.realtek.com.tw (8.15.2/2.95/5.92) with ESMTPS id 3AKDMZCI0801065 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 20 Nov 2023 21:22:35 +0800 Received: from RTEXMBS05.realtek.com.tw (172.21.6.98) by RTEXH36506.realtek.com.tw (172.21.6.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.17; Mon, 20 Nov 2023 21:22:35 +0800 Received: from RTEXMBS04.realtek.com.tw (172.21.6.97) by RTEXMBS05.realtek.com.tw (172.21.6.98) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 20 Nov 2023 21:22:32 +0800 Received: from RTEXMBS04.realtek.com.tw ([fe80::40c2:6c24:2df4:e6c7]) by RTEXMBS04.realtek.com.tw ([fe80::40c2:6c24:2df4:e6c7%5]) with mapi id 15.01.2375.007; Mon, 20 Nov 2023 21:22:32 +0800 From: Justin Lai To: Jakub Kicinski CC: "davem@davemloft.net" , "edumazet@google.com" , "pabeni@redhat.com" , "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" , "andrew@lunn.ch" , Ping-Ke Shih , Larry Chiu Subject: RE: [PATCH net-next v11 05/13] net:ethernet:realtek:rtase: Implement hardware configuration function Thread-Topic: [PATCH net-next v11 05/13] net:ethernet:realtek:rtase: Implement hardware configuration function Thread-Index: AQHaF8h2HvTf1F/vj0i3mzSIlPQ+NLCALagAgAMLV4A= Date: Mon, 20 Nov 2023 13:22:32 +0000 Message-ID: References: <20231115133414.1221480-1-justinlai0215@realtek.com> <20231115133414.1221480-6-justinlai0215@realtek.com> <20231118145046.7bb8efca@kernel.org> In-Reply-To: <20231118145046.7bb8efca@kernel.org> Accept-Language: zh-TW, en-US Content-Language: zh-TW x-originating-ip: [172.21.210.185] x-kse-serverinfo: RTEXMBS05.realtek.com.tw, 9 x-kse-antispam-interceptor-info: fallback x-kse-antivirus-interceptor-info: fallback Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-KSE-AntiSpam-Interceptor-Info: fallback Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On Wed, 15 Nov 2023 21:34:06 +0800 Justin Lai wrote: > > + .ndo_vlan_rx_add_vid = rtase_vlan_rx_add_vid, > > + .ndo_vlan_rx_kill_vid = rtase_vlan_rx_kill_vid, #ifdef > > +CONFIG_NET_POLL_CONTROLLER > > + .ndo_poll_controller = rtase_netpoll, #endif > > + .ndo_setup_tc = rtase_setup_tc, > > This patch is still way too huge. Please remove more functionality from the > initial version of the driver. You certainly don't need VLAN support or CBS > offload to pass packets. Thanks for your review, I will remove some less necessary functions and make the patch smaller.