From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB74833A9EC for ; Wed, 28 Jan 2026 08:51:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769590312; cv=none; b=mqJ326WK37gZPa+1dxMbm6lI0Dw4zHDAmqnunX378DyrnSt0oZ55DMlkpO+pSvX5X+A4TTLWQFp/k1fouCCRUk3oIfVO1QtAl+tTNzAMrVwMdPvNUeSqCLJHFTQoXvgHKRar8t8bAx6PYv2XuCLrTKbMfZ3mnqQmFXL/KrTyva8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769590312; c=relaxed/simple; bh=X2AzdKeGMu19tO1ypR/VJC5WRPHhh7DKhZdB6XQSJHI=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=GqDk4Kl7I7VLDuNQuEyoDq/aTUMl9iyeit+MEU7IaEWJtfmQQdoWEesxsxApODgYkWt5KRsWIRPCd0zlgSa9OU1v5Bz84g1EjmpyK4NFl+hW4sZ8ERhG9qeTE/AFEhlny6MA0GGzaYgYUckpUNiVIDylv1+pGpR46WYJdZrupDE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=t+v46eqb; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="t+v46eqb" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-4806d23e9f1so7049495e9.2 for ; Wed, 28 Jan 2026 00:51:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1769590306; x=1770195106; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=KkssKX9UZLI3a5TYO9ENZYAnlkONRgQSKBvfWG/TLA4=; b=t+v46eqbTW5XM6obyBEMzkqYgESFckHAk/whgKXQvrxkoub0siR5k34gc8CSoCGwWk 6vwr2IqLsIYvaZRUUwSEOv0c0vtILiQbwoddqzQwNU1gRDPgIadRC+/+GR+h4BZyg/Te 4+yXlRsQ6kukqHeW5f1cmzCIUDDp/HPCqSUcsCR2+OX2VmM1rVF3+HlY06ojyKCaZY0N aoHDVPJ4AZsLUWWrqF02/sEjyFGF2PsCzi9EtAxmqFzks3krk0vXZimCUufDsr3ILJJT CQ+d+J3+3ApFtJO3JrVC9GLEyhDmCfS3ySkb0ud9KWQiUZrqv+z9EQu/Tzt/Umk7LudR OaXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769590306; x=1770195106; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KkssKX9UZLI3a5TYO9ENZYAnlkONRgQSKBvfWG/TLA4=; b=doD66EelOyl1HIYDSTQsOZKcx+BKJJCnaIjPgIH/WfS+bzFD+EXT6p3ggS5jvrBkHH 8+as0NxrbYt8zYovd1sj5OcKdCBbaG+1ER4uNXL2qRjjYw5UkPWBVXgLoR9EMwENnuNZ plUhy5r+RHd8sJiVGJV+Fn7EYRa0TVcKLQsnZ9nKaCbLGwBxJUtSutREZFgU2iXuN0me XQjcUW5iBzVu5CkV/paB4xZqB1PZbt9YJTFpsHxgMalDbItLTbdTq/OL3zcQS9XSCA22 HLSpYYqBxNBA7z5/ImqmzsMm/7Fis2CmpY40ruiI6RC+iJJD7zQFGh+Mmqvp7E4ove/a zk6w== X-Forwarded-Encrypted: i=1; AJvYcCWBw1DSG9vGE2aqFuTKMVuKJ3ksOmY3tPD4qFAWaLZIfIacTIaVMLGPMU+7ZwzqrbyEIosv2friNTFvGYQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yy3I6nBPfMCP51eJhiUyjdIpkwQNHIf8QMpfRM4xhkEbqxYWrDD DuU0sb8MWSnZx25GsqmyLeEOyH7FZbE09/i8D96s7gFP6abHmKmcWzwEJDwUgb+0MqY= X-Gm-Gg: AZuq6aK+1CMMXAK/4Jntam9j7ap4RaBZ8/FjUtz3MGt9UXrdphxW5we+EVvbBuzgTyn d3Xp0gOo8tNsNekjez6+vEX31eLfjXkVgU1hn2JlN9dtalhtA+l6NbNIphNjum2fLJVWGwSEKmC SGIu3FcOYij1OdY/Y9XqNr+omGDYXj5GsDIgymVJyDa+WrmBDHZzIx0cIv4C9CI9boNsXGwLBZv EuyxFYpjAM4VDE8btnxDNzLJQbDDsGYwqiha7KDsBoG2lw3u1hWIxTWEO/Q8KUomk7A7JNQr5i8 hjfBIWkYcNcT7Hsmw6zxiVoQNUQ9bY640iK7WTsElCH9Qfd9lo2z/cBcTQIuojWcD4jifGYO8bl yS1zAYOMYabSjmUHTa3EL0nudArOVB/BGDaFQI5hw4Gg9xrphKcobDN28eZjwBqEs9Ex4j+FRbm /DXT0PjJjpfopw9HIZ5I5xOkd/zjNYrYk5vNsH0qJLL1i8VUSO3oql9oIQuRNAI3A= X-Received: by 2002:a05:600c:4592:b0:477:1af2:f40a with SMTP id 5b1f17b1804b1-48069c5b97cmr56776605e9.17.1769590305903; Wed, 28 Jan 2026 00:51:45 -0800 (PST) Received: from ?IPV6:2a01:e0a:3d9:2080:7745:d752:5f0b:2b68? ([2a01:e0a:3d9:2080:7745:d752:5f0b:2b68]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4806cddffe9sm66744915e9.4.2026.01.28.00.51.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Jan 2026 00:51:45 -0800 (PST) Message-ID: Date: Wed, 28 Jan 2026 09:51:44 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: Neil Armstrong Subject: Re: [PATCH v2 2/7] pci: pwrctrl: add PCI pwrctrl driver for the UPD720201/UPD720202 USB 3.0 xHCI Host Controller To: Manivannan Sadhasivam , Shawn Lin Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Greg Kroah-Hartman , Geert Uytterhoeven , Magnus Damm , Bartosz Golaszewski , Bjorn Helgaas , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-usb@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-pci@vger.kernel.org References: <20260127-topic-sm8650-ayaneo-pocket-s2-base-v2-0-c55ec1b5d8bf@linaro.org> <20260127-topic-sm8650-ayaneo-pocket-s2-base-v2-2-c55ec1b5d8bf@linaro.org> <0104896e-44d0-485a-a44e-694864c819b7@linaro.org> <33bbb3ec-5659-4d50-a5ff-dafa44e291dd@rock-chips.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 1/28/26 08:57, Manivannan Sadhasivam wrote: > On Wed, Jan 28, 2026 at 02:22:50PM +0800, Shawn Lin wrote: >> 在 2026/01/28 星期三 5:53, Neil Armstrong 写道: >>> On 1/27/26 16:53, Manivannan Sadhasivam wrote: >>>> On Tue, Jan 27, 2026 at 10:57:29AM +0100, Neil Armstrong wrote: >>>>> Add support fo the Renesas UPD720201/UPD720202 USB 3.0 xHCI Host >>>>> Controller >>>>> power control which connects over PCIe and requires specific >>>>> power supplies >>>>> to start up. >>>>> >>>> >>>> This driver only handles the supplies. So why can't you use the existing >>>> pwrctrl-slot driver as a fallback? >>> >>> It would fit with no change, but the name "slot" doesn't match the goal >>> here, >>> it's not a slot at all, it's an actual pcie IC. >>> >> >> How about renaming slot.cto something like pci-pwrctrl-simple.c, especially >> if most power sequences fit into this category? This would follow the naming >> example seen in other subsystems, such as drivers/mmc/core/pwrseq_simple.c. >> > > Yes. There is no point in duplicating the drivers just for a different name. > Slot driver is relatively new. So I don't think there would be issues in > renaming the module name. > > I'd prefer for 'pci-pwrctrl-generic.ko' for module name and 'generic.c' for > driver name. Will do Thanks, Neil > > - Mani >