From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8AC8C42E404 for ; Mon, 24 Aug 2026 13:46:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787579211; cv=none; b=cfMf0DxHfjwmLLVY8bgxZsEOS1yJeK18PhJK1waw8BZisH++ewgHkZeIvXFv1nBRqK4FlhD/D+MYrWDsTdPbK2R0lvefreSau1kNFcjJ7WS1RZIPJ5pj7adh8MmevL24n3+1i/MrzmuDnXwLSr8snWYdgHzsscHgOpdInN0pmUc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787579211; c=relaxed/simple; bh=u7ptXGg46h20+ycS2XTm1WSVKz2gZ9zCx+Gra8HyM2k=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jaWRit0lFwOc60bDK9t0ICxBGnjZiVqIJFm5n4QaiNOqZZT4YQgGQQxolk8xooE9zLBV2Iwn88dNu6YGhIZTmvqR/firLP8E4Ylf+tfNTQLJ6SaHjJ8KCCOtIuuENFsKaqCBOF4UheZqoFWh2yilH9fsdt2zVspuorkJZyDtFVI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=UsyQI/ZG; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=GtROgGHo; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="UsyQI/ZG"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="GtROgGHo" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67OCuxNt2583592 for ; Mon, 24 Aug 2026 13:46:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Nns8MPtsNp7ny0utoj3zguksz33o1lq3WNM38Fnh1Kg=; b=UsyQI/ZG0RP0lXB2 C/BDMVKmfhmKljREkvaPmhueQWqkkcO8zS0r/DVK25iHTlV1/o9EM+L78j5Is/Sk I/FjcrsnsIino7G3J9hSvjvNSGbey78jL03naR2/PpBLg5fA4DDhzITqQftU4iwa uzNK0Ta6emu6QSAc/jUunr6aJzzjb4g4Ja6gEjzGurYg9jioCndfMWrWUhwAUqnE cET/sAfYE7HGe4rzjLBY2xZ55FvOtdftGbv5xzx5ZBMAWQfBbe59+OYeRAuXcuFO 79FGzq5LMEozefIuQegxGqz7o7gq/LaAXRoVcGraIxsY71+JZfS1IfPDYyhjfxFi hKZEEg== Received: from mail-vs1-f69.google.com (mail-vs1-f69.google.com [209.85.217.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g8hbthmwt-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 24 Aug 2026 13:46:41 +0000 (GMT) Received: by mail-vs1-f69.google.com with SMTP id ada2fe7eead31-7530aaa7212so105942137.3 for ; Mon, 24 Aug 2026 06:46:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787579200; x=1788184000; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Nns8MPtsNp7ny0utoj3zguksz33o1lq3WNM38Fnh1Kg=; b=GtROgGHoxMGwAkvgMpOWeGkxdifxpZRlYLsSQH6wd6jCByY9KVSgl+l8FiT/zmXW6T n3ZS1mxhhu3yJfHJduyUVP6yiuOT1HC5aUt6w4MyCD+uA2A8J5rePCDXs8PzPDkKEGu4 bO1MJLp1gx/7SqhNaShRc0669GdmESOq5XuFQK5XU3ik8oUL6tWmDAvv1IV1YevCRtVA rjINyOX0PmS6zRYn5x+VRORG/F/U2oqo0OjuVSVDA9HqmX6KkPcS67p0PPUAGBVqgEa6 yPjNGrKfN93fXqr8G7aiTQ+Ve8GDW54LKkLVc7YkdEl3gy2HiSDj7KkenG7hjNrpCIGu f/NQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787579200; x=1788184000; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Nns8MPtsNp7ny0utoj3zguksz33o1lq3WNM38Fnh1Kg=; b=l6QFN3bdOIhEoevO0W9xoEmFD2KoPX1G18iREJbIFJF6xEPWYBuYuPQ9bk6CXoXtGm lHKjQSD7PofhPmAt2KcQ6nG0ZHNpp1T11+Af7zasMuYAXpUvgYWa/B1BSBCVaopL2KUP cy64qjtMCqOEgSCdxq2EpbVEv8ViifxIOrLIxF94Oa3mBvhtWo5B4TdCpiLRSzJwfg4D sIIG/Z+G29Pomp22DiIW4QnqwWMbYNJf1qsWoSsDjfYIyI5J3lHnA0/6b3XnwifPwNeO KTWIdwThS5kffnrhTYKaHt3xKg3fou31lmtwYYms6xAksLABb198monxh18ozVLk4t3M SsVQ== X-Forwarded-Encrypted: i=1; AHgh+RoDoqxtaas0SQIsmZaDft4JEK3wMqtkniV6KnhXKBdt+tNX0w6MWSLGXv1pLarmAJhS7/aW3nT0ZBSZkUE=@vger.kernel.org X-Gm-Message-State: AFuF++m6dJ9rllgV+Pepqj6m+i7RNga4yGhqqtK5TneZZYf/djO93FEJ p7943kYC9YD5sErj3cqwecA7FkbecSiwTa2MU5yGVtcvC9t4RBWjXy2Fb4+Okdn769ySCa1Ikc1 Ig5st4cgTFfsOWabOoJv9rvZRwqrcST9OK13Twb1KfpykQtGfw/d/YjJP6lvCYs6YJ6E= X-Gm-Gg: AR+sD12ZSIoUms8YMygPdwdB4xCJZEVv5T4aKYuO17arpYnPb9ZvgmwduVY5txUN5mR tbqGhpXjHca+fuX6ESdsZVtBr92vZyEWUwNzEf6u6A+Whwq6uwZXBYeQOYvzoG7yvNMj5LLNvzJ C4FEVc+bCd6fiH1UHchE9rSHRn5+a5oT8avG4xL9JK6hfiv6RgssBu0wvBURJa9gjw1IWZGaxAn tBjj7bMpYX21bQNvOoVxGRZchBSuHZAGa7pYqeCY1PlnH+haOcHoLMK6bGTevX0gOKU28lUZudN LBe3c9yveqtO/OogOkcUluOx4VxtySx5yOKvMQW2BrXYDeee0TbRrlgAdoUHVAMP/NuEfVxm9wQ oIUlSRCLrBOXPXK4/Ck4dSvni X-Received: by 2002:a05:6102:1594:b0:778:30ee:f44a with SMTP id ada2fe7eead31-77a5f2e70b7mr3427923137.0.1787579200614; Mon, 24 Aug 2026 06:46:40 -0700 (PDT) X-Received: by 2002:a05:6102:1594:b0:778:30ee:f44a with SMTP id ada2fe7eead31-77a5f2e70b7mr3427912137.0.1787579200146; Mon, 24 Aug 2026 06:46:40 -0700 (PDT) Received: from [192.168.120.193] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6a59e00108asm13140614a12.2.2026.08.24.06.46.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Aug 2026 06:46:39 -0700 (PDT) Message-ID: Date: Mon, 24 Aug 2026 15:46:36 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 6/9] usb: misc: qcom_eud: add role-based EUD control To: Elson Serrao , Bjorn Andersson , Dmitry Baryshkov , Greg Kroah-Hartman , Konrad Dybcio , Krzysztof Kozlowski , Peter Chen , Rob Herring , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260811213610.2956147-1-elson.serrao@oss.qualcomm.com> <20260811213610.2956147-7-elson.serrao@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260811213610.2956147-7-elson.serrao@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODI0MDExNiBTYWx0ZWRfXw0SdAhskcbK8 4l6Ueh7feb/rtjKqraj11rU9ucQ3WpcOTAT7Snf1AOPbu7Akq/V1REWtg8jgH6iaatJCNKOnIE3 jxHgUcUY4joBfbtDFbFpY6jq8QhZ9j9F9ankU+y2OqxTG7adMnkQXBLagEPcbvYYbo8rk3EomxA yliBSypGFRmtwGKlnimJncNep6cFgXiB/pUooBpC1xrTXkR3qOW9yJntNalipI1c+OVAmBsNPUl FmLxoLSlXhHmv2D9WwnJSenduCbRYmwZ6NfiXeo0/XgfaF1D9wVHD2iHJMPyyA6xet/OO9YQyc1 JBsVdgkN503CPAHctvYPmFEPrCWmbvjXApFXTDE0qfErvXHykB2RtHodieAe/LUH45MgKDab+tx BWz6MS+8yWELzbc603ArV8XcSPBitba9838cxRyxe2sS6HGkNVBdONXD6JSl0dr91hsztBZovbn 8xNjKQvjhioXzWqw66w== X-Authority-Analysis: v=2.4 cv=JL0LdcKb c=1 sm=1 tr=0 ts=6a8c4b41 cx=c_pps a=5HAIKLe1ejAbszaTRHs9Ug==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=X7E0pNrBJpJ0GBZA2WEA:9 a=QEXdDO2ut3YA:10 a=gYDTvv6II1OnSo0itH1n:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwODI0MDExNiBTYWx0ZWRfXyBVtovlah70A aKumjiptZALY94t8A3RVexxMrsBLOROCUumRzktal8WtPVTHkz5a/F+r3ely6wwjEIR3Hzh36Ka 6qIs9PF/FXdWLV4DmCgce4VSw4+9/oA= X-Proofpoint-GUID: rUF4seMm6RMdpToulTNEsBCBZ68jruvj X-Proofpoint-ORIG-GUID: rUF4seMm6RMdpToulTNEsBCBZ68jruvj X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-24_04,2026-08-24_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 suspectscore=0 clxscore=1015 impostorscore=0 priorityscore=1501 adultscore=0 bulkscore=0 malwarescore=0 spamscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608240116 On 8/11/26 11:36 PM, Elson Serrao wrote: > EUD functions by presenting itself as a USB device to the host PC and is > therefore only applicable when the port operates in device role. Keeping > EUD enabled in other roles provides no benefit and unnecessarily keeps > the associated PHY resources enabled. Furthermore, enabling EUD in host > role can cause the USB controller to misbehave because the EUD hub > supports only a single upstream-facing port. > > Address this by treating EUD as usable only in device role. The > role-switch callback enables or disables EUD as the port enters or > leaves device role. A sysfs enable request made outside device role is > recorded and honored when the port subsequently switches to device role. > > Reviewed-by: Peter Chen > Signed-off-by: Elson Serrao > --- Reviewed-by: Konrad Dybcio Konrad