From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 12D823E3DA6 for ; Tue, 9 Jun 2026 08:57:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780995440; cv=none; b=f2wmErGBvnbEu/kRp5G3mYXrZJyj2NvD8uuZrG3ydTZt2bEV0bsZr8+aOsBvSIjYOEOV5I1QYW02bbdnKhFTl0YZAVzjoyHN7ZrZdW7usj9l/OqRUewYIGC2OvLJYhSKi8t8SR5pork1TtHln0cQYTb5dr+HNvXBQXJNO9h5FsE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780995440; c=relaxed/simple; bh=zZCsXnjVimwX+u/Cp9VUCXkd7AOaMc73JPe7POemOaU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=VXw9HZT665c+notvWKKPaNkhhYvUGZunkN5eA3FV49RfSVjLizHzkaBfYO14DboVc8XP+0Nw5jcTq2W7kZw2b8F3Oca7EEjq2jbs2GTVCLGXKJ3erop3ADxq4vGwn7Wd4nqDYV11cxuoMhgwhNOSYRsVLTgJWGt80yK2DZsGRN8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=oltAfdje; arc=none smtp.client-ip=209.85.208.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="oltAfdje" Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-69155ca09d8so3598000a12.3 for ; Tue, 09 Jun 2026 01:57:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1780995437; x=1781600237; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=FPwdVwz7ctVs0k+br7o6SIlRqfvmba+MdXedF8Oh3cc=; b=oltAfdjeVuy5VznbfeBBC5mOPKft3ku/XG56RyfIMhCj9OxMeiBWT5J+H3hNYFJ3TF hXMMfAq8UZbfz3tqTrKJ9X0kzOp1AhDgdSzZxRnUNAFq13OhkfZBTaJTvXpN8bYoYbDK 3B08INJbRR/ThPcDSAu7+pWekm2QnJZNJXmkbQ8oDyhtovwNvTKrOYg++d1fCk3KUy3j 0o13965NX/1wBNtDPtW46JTpntr0m1EAB6BhNXo7EN47TgQSRVre1Do+DaopPgwpkOHd ei21yazQVvnOB8d40kbOIGZ/B2WwahcNHkK9RxeX9cpGGJfRma6VxhlD/cyykX0NtQbb IkLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780995437; x=1781600237; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=FPwdVwz7ctVs0k+br7o6SIlRqfvmba+MdXedF8Oh3cc=; b=F6FWSkbPKLZrihn1FTo4rHEG6qkFN8Yxw+5KdcKH7rwHdITepEIGvK8s3M9NiJJsYI R4GxBi7QdlV+86ucRdSzr46QEagFFN+gTkXytBGNa4ChsjIYCywFwJcA1It5Q+4HgacD JdrzRjIpLqPwxx+dFzR/XcCy/Tfq9pTojqUyXYwqCHtfkIm2/luZp5E2dBZ36OyZTFds Dm/lSqoY1ZbbT+cd8wFO3MVYDV2jIxanlZ/dBiPq/m8KoCm/2iacqd2R6f8j+JiRB1ai qY0YhXTiuhcEMakNhxbPsip+wGUfmApHxTK23YXZDLlXvYw1U1LAYz+ZHweVKMHoyL5l u0yw== X-Forwarded-Encrypted: i=1; AFNElJ9mh1gw9oezeVcNEZNAtZvNZv/TkpbTx4wyNlvpgAn8WTbWTHMs7jyIesZyiRm0EBGlUBYoZCQ6A/3PFG0=@vger.kernel.org X-Gm-Message-State: AOJu0Yw468295waK2sQcTbq9Rhi5piI0tIT6JndgiQ3pBrkI0nM0l2Ek Dhuki9KyUwYEHgosG5cyFJwILm1myWCo4+r36BSTP235jim+KxnsQmR40xCNTzV+voE= X-Gm-Gg: Acq92OHEFypvXKsKTQsOzrS6aJstcMOPYWkIB7e4FHlGFPuikPseH9R2xTghLSHNc+6 ro9h+ylo7ds3AJTttTjt+UIxE7qDiXUFNV23RzcFtrkGaNqPOohEH6nt6e0MTZmluE1/ovSHepn OBC4/LjQBydb5vEz9O2njPkEHWQZqbRYw7fKWVzguXVaMolAvtiFOnWqcjmGeOv/M5SvbVyHNeK AJ9HHMblSTyOG1Vn3vZFF0gYeGOoCNawoquumzvO0ieSWVUZQ5Qbersqt/Hx+cEBFR7Nw8HLpEU dLtAHktZLUKuHWtVlQoaHvzdCZXiZ3qjgBDAutst35IYj6+PP+Hs2RWaATKB/TXszBpeuAsIEA1 KoJBmFJy2b8x67EGrvZBaM0jAmhagvt+r5IW3HtsbJt5LTDjJugndpFgzhxGeyeraZRq+lv+Kh1 g7QN4IHpiwJbkvjXJLrUJQltFv5p79U5/H22xuJ28kdE9N X-Received: by 2002:a05:6402:4303:b0:688:1d5:44c5 with SMTP id 4fb4d7f45d1cf-692381fb3c7mr835032a12.2.1780995437379; Tue, 09 Jun 2026 01:57:17 -0700 (PDT) Received: from [192.168.0.167] ([109.77.72.26]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-68e65b55d81sm8343493a12.27.2026.06.09.01.57.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Jun 2026 01:57:16 -0700 (PDT) Message-ID: Date: Tue, 9 Jun 2026 09:57:12 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 0/7] Add CAMSS and IMX577 sensor support for Shikra EVK To: Nihal Kumar Gupta , Bryan O'Donoghue , Vladimir Zapolskiy , Loic Poulain , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Robert Foss , Andi Shyti , Bjorn Andersson , Konrad Dybcio , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam Cc: linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Suresh Vankadara , Vikram Sharma , Wolfram Sang References: <20260608-shikra-camss-review-v2-0-ca1936bf1219@oss.qualcomm.com> From: Bryan O'Donoghue Content-Language: en-US In-Reply-To: <20260608-shikra-camss-review-v2-0-ca1936bf1219@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 08/06/2026 15:06, Nihal Kumar Gupta wrote: > Shikra EVK is based on the Qualcomm Shikra SoC. > It lacks a camera sensor in its default configuration. > This series adds CAMSS driver support, CCI definitions and enables > the 22-pin IMX577 sensor via CSIPHY1 through device tree overlays. > > We have tested IMX577 Sensor on CCI1 with following commands: > - media-ctl --reset > - media-ctl -d /dev/media0 -V '"imx577 1-001a":0[fmt:SRGGB10/4056x3040 field:none]' > - media-ctl -d /dev/media0 -V '"msm_csiphy1":0[fmt:SRGGB10/4056x3040]' > - media-ctl -d /dev/media0 -V '"msm_csid0":0[fmt:SRGGB10/4056x3040]' > - media-ctl -d /dev/media0 -V '"msm_vfe0_rdi0":0[fmt:SRGGB10/4056x3040]' > - media-ctl -d /dev/media0 -l '"msm_csiphy1":1->"msm_csid0":0[1]' > - media-ctl -d /dev/media0 -l '"msm_csid0":1->"msm_vfe0_rdi0":0[1]' > - yavta -B capture-mplane -c -I -n 5 -f SRGGB10P -s 4056x3040 -F /dev/video0 > > Used following tools for the sanity check of these changes. > - make -j32 W=1 > - checkpatch.pl > - make DT_CHECKER_FLAGS=-m W=1 DT_SCHEMA_FILES=i2c/qcom,i2c-cci.yaml dt_binding_check > - make DT_CHECKER_FLAGS=-m DT_SCHEMA_FILES=media/qcom,qcm2290-camss.yaml dt_binding_check W=1 > - make CHECK_DTBS=y W=1 qcom/qrb2210-rb1-vision-mezzanine.dtb > - make CHECK_DTBS=1 W=1 qcom/shikra-cqm-cqs-evk-imx577-camera.dtb > - make CHECK_DTBS=1 W=1 qcom/shikra-iqs-evk-imx577-camera.dtb > - make CHECK_DTBS=y W=1 dtbs > > This patch series depends on patch series: > https://lore.kernel.org/all/20260527-shikra-dt-v4-0-b5ca1fa0b392@oss.qualcomm.com/ > https://lore.kernel.org/all/20260608-shikra-gcc-rpmcc-clks-v5-0-94cefe092ee3@oss.qualcomm.com/ > > Signed-off-by: Nihal Kumar Gupta > --- > Changes in v2: > - Drop qcm2390_resources struct and CAMSS_2390 enum; use qcom,qcm2290-camss > as fallback compatible string since Shikra CAMSS is register-compatible > with QCM2290 (Loic, Bryan) > - Use oneOf in iommus to describe all valid SID combinations: VFE-only > (Shikra) and VFE+CDM+OPE read+OPE write (QCM2290/Agatti); add > per-entry descriptions naming each SID (Krzysztof, Bryan) > - Rename shikra-cqm-evk-imx577-camera overlay to > shikra-cqm-cqs-evk-imx577-camera, shared by both CQM and CQS EVK > boards which use the same PM4125 PMIC and camera supply rails (Bryan) > - Add reset-gpios pinctrl state for IMX577 sensor (gpio33, cam1-reset-default-state) > - Add comment in overlay DTS explaining absent regulators are powered > by the daughter board (Bryan) > - Collect Reviewed-by tags > - Add reset-gpios pinctrl state for IMX577 sensor. > - Link to v1: https://lore.kernel.org/r/20260526-shikra-camss-review-v1-0-645d2c8c75a7@qti.qualcomm.com > > --- > Nihal Kumar Gupta (7): > dt-bindings: media: qcom: Add Shikra CAMSS compatible > dt-bindings: i2c: qcom-cci: Document Shikra compatible > arm64: dts: qcom: shikra: Add CAMSS node > arm64: dts: qcom: shikra: Add CCI definitions > arm64: dts: qcom: shikra: Add pin configuration for mclks > arm64: dts: qcom: shikra-cqm-cqs-evk-imx577-camera: Add DT overlay > arm64: dts: qcom: shikra-iqs-evk-imx577-camera: Add DT overlay > > .../devicetree/bindings/i2c/qcom,i2c-cci.yaml | 2 + > .../bindings/media/qcom,qcm2290-camss.yaml | 16 +- > arch/arm64/boot/dts/qcom/Makefile | 8 + > .../dts/qcom/shikra-cqm-cqs-evk-imx577-camera.dtso | 70 ++++++++ > arch/arm64/boot/dts/qcom/shikra-cqm-evk.dts | 9 + > arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts | 9 + > .../dts/qcom/shikra-iqs-evk-imx577-camera.dtso | 70 ++++++++ > arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts | 9 + > arch/arm64/boot/dts/qcom/shikra.dtsi | 197 +++++++++++++++++++++ > 9 files changed, 387 insertions(+), 3 deletions(-) > --- > base-commit: 6e845bcb78c95af935094040bd4edc3c2b6dd784 > change-id: 20260526-shikra-camss-review-cf6f66ac566b > prerequisite-change-id: 20260511-shikra-dt-d75d97454646:v4 > prerequisite-patch-id: 3a689e8dda5fd2755b689d94d095806b3f2e6eed > prerequisite-patch-id: 2acc300a68ed8c5364fb5f2f7d28fc0d56ab07bf > prerequisite-patch-id: 2357cac636e019eaf14d6a493a1c72bca56fe405 > prerequisite-patch-id: 2885f299e711582da312ca9d13983d296a3dd5dc > prerequisite-patch-id: 91af5f3c01e766a53ce8de69aa21847a2d6bbbf8 > prerequisite-change-id: 20260429-shikra-gcc-rpmcc-clks-2094edfff3b0:v5 > prerequisite-patch-id: 59bb0a7828e41f546f734f127d81da83c0adcda9 > prerequisite-patch-id: 197da6bcb15cadc47869dba88c8020987b25c335 > prerequisite-patch-id: 8ec9c1eb03f052ae232ed54117abed38672c23f6 > prerequisite-patch-id: 350db4f4bcdfc0fad9ed57cd5b1723f85ad44f5d > > Best regards, I really think you did a good job taking v1 feedback BTW, good work. For the series. Reviewed-by: Bryan O'Donoghue --- bod