From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF1CAC00140 for ; Fri, 12 Aug 2022 08:45:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237528AbiHLIpO (ORCPT ); Fri, 12 Aug 2022 04:45:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57062 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237565AbiHLIpE (ORCPT ); Fri, 12 Aug 2022 04:45:04 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id B6D76A8CD8 for ; Fri, 12 Aug 2022 01:45:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1660293902; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wxoycUTdX5EPODZXQ/28haLXP8FulwP/RdMCFThGP5k=; b=V+TMF7YI43EE0SF07t3pq4ivReymjItpA8KRYyU8x7FfgVDAMNCFdOrMH8jtfNODEQcHzM PLtPk6Cz4G3WzhQ0XaaEU1leTqVNYKGc0vdAlXkxaKL9ZPIgSALzieOhhM83jXlCtRTiZG Pj5m7ZMC3x3O8CENuIaB1qY5V0IXryE= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-659-xrlnlH2eO2m4dIN5LiQOkg-1; Fri, 12 Aug 2022 04:45:01 -0400 X-MC-Unique: xrlnlH2eO2m4dIN5LiQOkg-1 Received: by mail-ej1-f70.google.com with SMTP id js11-20020a17090797cb00b00730d73eac83so186964ejc.19 for ; Fri, 12 Aug 2022 01:45:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=wxoycUTdX5EPODZXQ/28haLXP8FulwP/RdMCFThGP5k=; b=21QsMCbWh95i85c2ayGwx4WfeuyaLhlUdFnnGulwiM1g+jqDV5KOOXCjIzoL0oIkg/ OQjvAQqWGzLxftOd7Tt5/xsW5s/IV3tM1NeWg2QbjqZ84pVnXkxL5mWoPULD7591uzEL m8AaC8LnyVBKiZLJXrjFB5p+VdeV9HBBZYB7/J9+zDGhDo7TbsZNRjQpERzAmNcROJrM duuIf0CX0V8cw1RCY/28UUKeq0XWHnsgqfRk59rjnhMgsdiubpY+FdyaQcugbuNo3YGq fGijiOLI39EyK0fOa48jwRoj+LCHdq8BG0mmhpDCu2zdCPA6swF51MC5a9sKZkvsZ9vU I07A== X-Gm-Message-State: ACgBeo2SpjYcYDdOsOhS9Cp97ifglTLa3kmGc4HtTRgJPvyFPZU/kCEz XClir+U33UgUq03T6L5w0TPXnMixNPn9UDacxJ1K87yGoVpbbj0sXfWSCdvQMilx9d2bouMtu+R t8XdMeLF/M39p10BbYJtf1RGR X-Received: by 2002:a05:6402:b1b:b0:442:8cee:177d with SMTP id bm27-20020a0564020b1b00b004428cee177dmr2605174edb.318.1660293900489; Fri, 12 Aug 2022 01:45:00 -0700 (PDT) X-Google-Smtp-Source: AA6agR4faCKb3OVGqQbsXrDmbmSTRFWZL9S/wtfh7PDkDMvgkKLZysKH6klOEkjyTQwgLnIp49JfNA== X-Received: by 2002:a05:6402:b1b:b0:442:8cee:177d with SMTP id bm27-20020a0564020b1b00b004428cee177dmr2604927edb.318.1660293895418; Fri, 12 Aug 2022 01:44:55 -0700 (PDT) Received: from ?IPV6:2001:1c00:c1e:bf00:d69d:5353:dba5:ee81? (2001-1c00-0c1e-bf00-d69d-5353-dba5-ee81.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:d69d:5353:dba5:ee81]) by smtp.gmail.com with ESMTPSA id e6-20020a1709061e8600b006fec4ee28d0sm536426ejj.189.2022.08.12.01.44.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 Aug 2022 01:44:54 -0700 (PDT) Message-ID: Date: Fri, 12 Aug 2022 10:44:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v3 6/6] asus-wmi: Support the hardware GPU MUX on some laptops Content-Language: en-US To: =?UTF-8?Q?Thomas_Wei=c3=9fschuh?= Cc: Luke Jones , andy.shevchenko@gmail.com, pobrn@protonmail.com, pavel@ucw.cz, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220809025054.1626339-1-luke@ljones.dev> <20220809025054.1626339-7-luke@ljones.dev> <7365d41a-1475-118c-96a8-6ab927bda5b7@redhat.com> <9ed62983bd03ed26cdb4399dd69b4096e8711fa9.camel@ljones.dev> <0239b3bb-d9cb-4549-9e9e-006923b61634@t-8ch.de> From: Hans de Goede In-Reply-To: <0239b3bb-d9cb-4549-9e9e-006923b61634@t-8ch.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 8/12/22 10:31, Thomas Weißschuh wrote: > Hi, > > On 2022-08-12 09:59+0200, Hans de Goede wrote: >> Date: Fri, 12 Aug 2022 09:59:29 +0200 >> From: Hans de Goede >> To: Luke Jones >> Cc: andy.shevchenko@gmail.com, pobrn@protonmail.com, pavel@ucw.cz, >> platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org >> Subject: Re: [PATCH v3 6/6] asus-wmi: Support the hardware GPU MUX on some >> laptops >> User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 >> Thunderbird/91.12.0 >> >> Hi, >> >> On 8/12/22 00:01, Luke Jones wrote: >>> Hi Hans, >>> >>> On Thu, 2022-08-11 at 15:53 +0200, Hans de Goede wrote: >>>> Hi, >>>> >>>> On 8/9/22 04:50, Luke D. Jones wrote: >>>>> Support the hardware GPU MUX switch available on some models. This >>>>> switch can toggle the MUX between: >>>>> >>>>> - 0, Dedicated mode >>>>> - 1, Optimus mode >>>>> >>>>> Optimus mode is the regular iGPU + dGPU available, while dedicated >>>>> mode switches the system to have only the dGPU available. >>>>> >>>>> Signed-off-by: Luke D. Jones >>>> >>>> I see that you have replied to this that it needs more work. >>>> >>>> Besides it needing more work, ideally this should hook into >>>> the existing vga-switcheroo mechanism for this. Can you take >>>> a look at that please? >>>> >>>> I think this might be the first non GPU driver doing vga- >>>> switcheroo stuff. So this may be something to discuss >>>> on the dri-devel list. >>> >>> I'm not sure how this would work. In typical ASUS fashion they do non- >>> standard stuff. This switch is a basic toggle that requires a reboot to >>> enable after writing to the ACPI method, after reboot the dGPU becomes >>> the only visible GPU on the system and (this GPU) can not be suspended. >>> >>> In short: it toggles the laptop from discrete-only mode, and optimus >>> mode, requiring a reboot to switch. >>> >>> From what I understand of switcheroo it is more to manage having dual >>> (or more) GPU available during runtime, and manage the power states, >>> offload etc. >> >> Right, I did not realize this requires a reboot, that would be >> something to mention in the Documentation bits accompanying the patch. >> >> This is also a reason why it is good to have the docs update in >> the same patch as adding the functionality, because the docs may >> help with reviewing. >> >> Anyways I agree that if this requires a reboot then using >> the vga switcheroo stuff is not applicable. So we can just go with >> a simple(ish) asus-wmi sysfs attribute. > > Would this not fit the existing "firmware-attributes" class? > It even has a flag to signal that a reboot is required after an attribute has > been changed. Yes it sounds like a BIOS setting is being toggled from within Linux, which would normally be done through the "firmware-attributes" class, but all existing "firmware-attributes" class drivers allow changing all BIOS setting not just a single setting, so using the "firmware-attributes" class here is not really appropriate. > Maybe it is overkill to use it only for this, though. Right :) Regards, Hans >>> I have a vastly improved patch for this prepared now. Because of how >>> the actual feature works (and the above explanation) it must be under >>> the asus-nb-wmi sysfs (next to the dgpu_disable and egpu_enable toggles >>> which are also unusual and non-standard work-arounds of Windows >>> issues). >> >> Ack, sounds good. > > Thomas >