From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 744C03A254D for ; Wed, 10 Jun 2026 08:17:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781079478; cv=none; b=jGe5WAFSRus9rO8Qd0UotIdz75Mc2+YcqartSg0eAJrajnzJDQBzB3YroKVIOPTZTRcwf//CV/wfdyBEa/bw+eHcxmzH4VQww3J1Go3dwavFsgNhY0NmZUMp0UlFdkLWszmcL3Yjd6GqFDmnyrXNZnZEOvpaVMYeoxYAoAycKRs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781079478; c=relaxed/simple; bh=ua4oCBMHWovh1U2nrh0ck8+JU0/8VJey05G1+ETTpTs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=bGdtLA362PnJosmky2d8Ps9hxmwp/R6k+KBQQvRj5XSnAy/dsVrbRXPeOO55Lg3KqxjcY1RSHEW2pdUXUiNtHkmWL5nN32Pq63xE0y2sEM6zK2ksNp59eeHjX+B4ITCQ00dPpVVBhIs9Z6OsSmO9NEaEVWUgUwQLXBM01rJKt/Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=o1kFWw51; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=NfAkS5zR; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="o1kFWw51"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="NfAkS5zR" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65A7j48R948051 for ; Wed, 10 Jun 2026 08:17:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= wyz1qfOB2eWQ0JoiKqQ0zeXhArsoeEYRvieRQpOLvOo=; b=o1kFWw51NsdYCN2I 2UbKSHJTd8lezvUuMw+gI9OuDy8TLZum/+n14tgf5+1x5ZWDUcA4TioqNYBiCwqe d8ACavAXt08GtLxKo78Sy3jgKFpxLDXad0jPY0+bfMq9LYAUzVdKb4VQN1C3tssW 2zS8a4/aVjNro1CBKxP+QNXLKfbbKAsdncZIMx+zoSXIBRlBHW6zoP4cGl5vawvg kMW6Nc6hwMejNGDn1h8M3gRMn9ovZFO8rNThFmsZTDv8NH7DhuB1TVa+lriulg6J p5BX7wbik7GKy0PWLvv+sQqZxosUcFKtwO/AlCm97G17C+IeEX/Di0Z61Hlc8L2w 5eHmwg== Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4epwnnsfn4-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 10 Jun 2026 08:17:56 +0000 (GMT) Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-84235f9b91fso4834381b3a.2 for ; Wed, 10 Jun 2026 01:17:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781079475; x=1781684275; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=wyz1qfOB2eWQ0JoiKqQ0zeXhArsoeEYRvieRQpOLvOo=; b=NfAkS5zR4P0x/bjvbsO8ekhK3+UUaUtcNe8EVwZbk3knARk7BAoMzCfoqRi07x+oXR 32zoC3hTZR/MyrdwvEiGsOc3yIz2EDY5BTwsOgWOZpf9YarnGSpNhHeUBKIow4WzeOCN VgJSoamtuz9+m09ngOoDohf4pC7/mGIq3ytXjBuz1ViJezOi0o3vf5lHe5N47QpoKVCx PLFYXJK+dNFsEVxQJShyVmxYMYnkdjbCQh87Fuss4ZSkFj3PPKfeFAJTh41fDx8x3Gxg icbTginq8ABNq67QYnA7jdjKs45twsDcKEKFMn1AvmdJjBx+DHD10Y5xeDQ/5lt9OZq/ lgdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781079475; x=1781684275; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=wyz1qfOB2eWQ0JoiKqQ0zeXhArsoeEYRvieRQpOLvOo=; b=N2qAXe4DWLdqTHojbpv9PYGSfoWqWkuFEaEjF0Y9fJ2OQfgfsulae22+qBmwFCwzOL BGMJjBafhRU/9P6z3fprZ0fbsSie5GOhOzs/h54ZvDiXNpv6Qe0DmQunpYegPCqNh8he y2+VNE3kCnNjVGz8nNUsF02v4+61X4RR0w86vFE+DfQCdWSglSFjC9kVESxFJO6raD4f gMdPBGzXpcuwbtmwCuWsB5XiMq+1xpxy4kOAAJLxE7/2fzbE4f1je32r6PiHROBigvg/ WPxwEQwCgffYPK+QiNCcHtw7OVo6VQ/n810LJlw7SJgv8Tcb7yfxu9J+A+EpI+KUJFVB qVyQ== X-Forwarded-Encrypted: i=1; AFNElJ/g0SsD7krPmHDMnZ+Xhd0H5Z2cl2Jz+mQ3neLSBOOGDGBE2zZ/YdI9MzDoS5SPiInvzd4lk0r9Qm4emNk=@vger.kernel.org X-Gm-Message-State: AOJu0YwQXZ6Yx7OxbsF9nsY94Z75GmCWP7jJuEkm8+uKG23rDYcHV6oL w9pSVAeZoYFo8xn+DSfo9SypD1QjlFBRGTF61M6DGv4R7XheenjPd7QNtOaZsJ8Tdd9OqtxYI+q lwUJqf9QFYoxyVRKHkoXalMpFuoeqJZlALzClYEivAloZcEhziiNXPinf7oiLPjvZZYpcekXxea s= X-Gm-Gg: Acq92OGKj9GEBbnKLFnD0tBBYadd36vl8r/cAMBWAzSluFN+DXwMePoGtP+yYxGB4KA SixqyYe+TQfWDacJMfy4/C1ym0rWFvFYUvsXcTB3tWGBl8ShMBNewrHHZtVYx/ZMZj8ePbK1ZtA SsRn8AXfVcjuyiXzL/EzK7wfKfy6lyJtiNFcatAGW803VPlMkdbDNvr2EGmZ9E6fvzRA4S1MxW0 rR7GzMxtT9mwimOugmbcoabgg5mAFZ3clObsB8EM9oAPTAngX0qRiPDEzLVFp2+/X1qBi17eTZi cBixVc7Va2ZI35XjtFmrNSnBYTG6bU/E8Jrq1hQqLdAtwtx0gDMIlh5AoVw8ad7Onr4FNkbC/fn B8BlZFXW5FaL4lZwDqtuRJJqcUZUHw9ewo15rbIseFsw35pPKEjtRlgKCMpJg X-Received: by 2002:a05:6a00:4390:b0:82c:d7c4:4c57 with SMTP id d2e1a72fcca58-842b0e73596mr25413133b3a.19.1781079475267; Wed, 10 Jun 2026 01:17:55 -0700 (PDT) X-Received: by 2002:a05:6a00:4390:b0:82c:d7c4:4c57 with SMTP id d2e1a72fcca58-842b0e73596mr25413097b3a.19.1781079474853; Wed, 10 Jun 2026 01:17:54 -0700 (PDT) Received: from [10.218.18.193] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-842828cf783sm24328211b3a.40.2026.06.10.01.17.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Jun 2026 01:17:54 -0700 (PDT) Message-ID: Date: Wed, 10 Jun 2026 13:47:50 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 2/2] pinctrl: qcom: lpass-lpi: Switch to PM clock framework for runtime PM To: Krzysztof Kozlowski , Bjorn Andersson , Linus Walleij Cc: linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, mohammad.rafi.shaik@oss.qualcomm.com, Konrad Dybcio References: <20260522204644.4101640-1-ajay.nandam@oss.qualcomm.com> <20260522204644.4101640-3-ajay.nandam@oss.qualcomm.com> <7fce0440-7649-4bd3-b25e-00e2feaf6303@kernel.org> Content-Language: en-US From: Ajay Kumar Nandam In-Reply-To: <7fce0440-7649-4bd3-b25e-00e2feaf6303@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: FhhfRfTWdflEQ2dAT6LCgNzyf4CJygyj X-Proofpoint-ORIG-GUID: FhhfRfTWdflEQ2dAT6LCgNzyf4CJygyj X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjEwMDA3NyBTYWx0ZWRfX2EfSrqqMAXLz y4RWdNKLEMHCBgOZ9ZpmXdCUcVzeDu1yT6eNh331OyJEOQaT/Y3Z6ey4lnnY+AkEko+KsKlkB/R YQq7rsnyUyuKo7YQEaO+NEb4glYPAPG06ZOhTAiPrGZa1lLvrdVlJNbKlgyJwwV6KabnY/ttb38 iRbKjQtBJLDc4TZcDh+0VRwuhJ+WtB+YciwbZSLPKRvC6bxnBrwG42AYwp+XtpREGVWukPmKMS7 w0Viu2cHdy4Ck1KDwMWHm1C3meISie3Sbvh8RNyPcjCWRsAbmTEhmCS50rDw6CzzO2qRBH/au+g YeTHusDKF2tTq82Pf8PEm4CvcOk/qp401GKHbZtVesTi6gfag2I3U6sF5ayreu+qbQ4F2axandy OiyT2ifqncr7b9hqvJ48bl+PGWnt5f/LgD3pECgCW86x+ajz1Lu9Vh8E1pI04Ou7ipguYCyAWl6 wVDjoF/FE9MOg4dkVpw== X-Authority-Analysis: v=2.4 cv=epLvCIpX c=1 sm=1 tr=0 ts=6a291db4 cx=c_pps a=WW5sKcV1LcKqjgzy2JUPuA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=Qe6B47XUAAAA:8 a=VwQbUJbxAAAA:8 a=QyXUC8HyAAAA:8 a=EUspDBNiAAAA:8 a=1m74azz6ZWac8Rq_qFoA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=OpyuDcXvxspvyRM73sMx:22 a=QWPKR-PWjQKaio0naagv:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-10_02,2026-06-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 clxscore=1015 bulkscore=0 suspectscore=0 malwarescore=0 priorityscore=1501 phishscore=0 adultscore=0 lowpriorityscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606100077 On 6/10/2026 11:48 AM, Krzysztof Kozlowski wrote: > On 22/05/2026 22:46, Ajay Kumar Nandam wrote: >> Convert the LPASS LPI pinctrl driver to use the PM clock framework for >> runtime power management. >> >> This allows the LPASS LPI pinctrl driver to drop clock votes when idle, >> improves power efficiency on platforms using LPASS LPI island mode, and >> aligns the driver with common runtime PM patterns used across Qualcomm >> LPASS subsystems. >> >> Guard GPIO register read/write helpers and slew-rate register programming >> with synchronous runtime PM calls so the device is active during MMIO >> operations whenever autosuspend is enabled. >> >> Make PINCTRL_LPASS_LPI depend on PM_CLK, since this patch introduces >> direct PM clock API use in the shared core. >> >> Suggested-by: Konrad Dybcio >> Signed-off-by: Ajay Kumar Nandam >> --- >> drivers/pinctrl/qcom/Kconfig | 1 + >> drivers/pinctrl/qcom/pinctrl-lpass-lpi.c | 144 +++++++++++++++-------- >> 2 files changed, 99 insertions(+), 46 deletions(-) >> > > > It looks this introduces new build warnings: > https://krzk.eu/#/builders/151/builds/303/steps/11/logs/stdio > > Which you might have been notified about more than two weeks ago: > https://lore.kernel.org/all/202605241040.1av35pgK-lkp@intel.com/ > > Best regards, > Krzysztof Hi Krzysztof, Thanks for the report. You're right — this was introduced by the runtime PM refactor, and the unused lpi_gpio_write() was also reported earlier by the Intel CI. I've addressed this with a follow-up fix removing the unused helper: https://lore.kernel.org/all/20260610080809.2588640-1-ajay.nandam@oss.qualcomm.com/ >