From: Joe Perches <joe@perches.com>
To: Tanjuate Brunostar <tanjubrunostar0@gmail.com>,
gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, outreachy@lists.linux.dev
Subject: Re: [PATCH] staging: rts5208: Replace instances of udelay by usleep_range
Date: Wed, 19 Oct 2022 21:40:31 -0700 [thread overview]
Message-ID: <c3c211c1c99cd19f86fb801576c55b2ae2216c6f.camel@perches.com> (raw)
In-Reply-To: <Y06yiBaluz6X0C4G@elroy-temp-vm.gaiao0uenmiufjlowqgp5yxwdh.gvxx.internal.cloudapp.net>
On Tue, 2022-10-18 at 14:04 +0000, Tanjuate Brunostar wrote:
> Replace the use of udelay by usleep_range as suggested by checkpatch:
>
> CHECK: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.rst
> + udelay(30);
[]
> diff --git a/drivers/staging/rts5208/ms.c b/drivers/staging/rts5208/ms.c
[]
> @@ -3235,7 +3235,7 @@ static int ms_write_multiple_pages(struct rtsx_chip *chip, u16 old_blk,
> return STATUS_FAIL;
> }
>
> - udelay(30);
> + usleep_range(30, 30);
This isn't useful. Please read the Documentation/timers.
next prev parent reply other threads:[~2022-10-20 4:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-18 14:04 Tanjuate Brunostar
2022-10-20 4:40 ` Joe Perches [this message]
2022-10-20 6:08 ` Tanju Brunostar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c3c211c1c99cd19f86fb801576c55b2ae2216c6f.camel@perches.com \
--to=joe@perches.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
--cc=tanjubrunostar0@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®