From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 431AB392C26 for ; Tue, 3 Feb 2026 07:51:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770105088; cv=none; b=paFmzZJ5aNMRDEgAgfBjpPbWaQZcqXAA0DOSQKPVVi6iBpB6ScKsyaa8YcSR8AbYuTxEqTRK75GDH5Nq5Z6S4rhDNeyyy9t9MOK7KgxDyHu+9uPcTomqAMe2Z4DTlg0yLmF6s0W1/DvQw4q8ekC7qFo13y8g7cwZ1c29CYaI5P4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770105088; c=relaxed/simple; bh=WK1m/rfMy+nsMO0sFa47FzExdTA2TNlHubHOaplhbdQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=GVftlY4qLjvJq4396ahyPDiNlnckahaNduZuEMTSs+mzAmJXeepvV9pQ4mpmQtVz6Z2BGXWYiCJxLxDtfvCGryX3y9rKgPsEOAigPV3uV5k/JCwWm6YaFCxOxNj4MiMCz7k124NWT0N/ql9gGPWp8Yk3iUttpGJDwXLoeMI7vjU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=blackwall.org; spf=none smtp.mailfrom=blackwall.org; dkim=pass (2048-bit key) header.d=blackwall.org header.i=@blackwall.org header.b=LLZF0tlI; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=blackwall.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=blackwall.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=blackwall.org header.i=@blackwall.org header.b="LLZF0tlI" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-42fb6ce71c7so4346521f8f.1 for ; Mon, 02 Feb 2026 23:51:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=blackwall.org; s=google; t=1770105085; x=1770709885; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=nVvoMu7jKyWYs7cJ4I1AmXisCkMpA/I5c//QtIjMPJc=; b=LLZF0tlIKp7S/JgIVE4d+ANaky85zDDqPGdoF8p0az12wa39SDUDOppqGftkP1nI93 j7g8U0TtfrqAWTIsr3ZfQdGPIzU82bExeoJJd+DIPuEA3DCaW81hO9Ey4rnbDtB3f2m3 OQob7u/4R9ozPqEkLqvwSLmhMFZSmNIPCSVDsMLFof4LLTe+QwRyihhX+KvdE+aZhGwI 7PwTfnKz2hdOMhr1izb65NbmYpaJ0JKeS1y9QuTOS6sxhsD+fVmm0Cuv3YHRnuNk7QSP AS63eulqs+HNzZdeFh3SCT9+DQ/by0oKPwO4hI41200VT5lA+Ia7yuhE7cnU2rA50GeB 7rNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770105085; x=1770709885; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nVvoMu7jKyWYs7cJ4I1AmXisCkMpA/I5c//QtIjMPJc=; b=YLXzOqPul21DnO99WLbxCfpa2EMEa4kpM597jvUXJ5hH4VK2DUvAjybziJJ/RMdGF0 KexKzi65pkxtu7NujmX03NviEA5qDpbzgBoM/uyfJL5pPd6tFihZGj0OkHGiLsgrEmzi RCXDwXmlv4Z5157dCqfWVKyFp4Q75Ou5vMAIlKDYWejoVcIbGQrqMWCw4ADiLoH+K3EY yGFpNVpvZtgsjz0i/krzDvdYfVnIGLFJ+eL0oO9mN076N/WynglT40bfdZ80ynaIoxmG 0Tuxb6pzP5PxoLDyIaDEawHnvUuSzjSWewvi1gnWr/KbqfAIF7u0L+KnLfgc4uIV/5nc 8PWA== X-Forwarded-Encrypted: i=1; AJvYcCXkR0CmaYXKlWfhabJAAygLhYw2cTeRKVqpZAA4eSPIVAch+Mj1OeoGPP04QyX6IyezbvX+useMjZFOnok=@vger.kernel.org X-Gm-Message-State: AOJu0YylWgMkSVNplImAZXIoB2zQOnS7DRvv2S0fTk3Fw4ssCD3YmqsU w5vcNpxn6T/M4bX7EFE3i78cRtO8canRT+tHJzOJcKrxcmiXlEmNORKGg9GPwbeTzMI= X-Gm-Gg: AZuq6aJQwmPLtSBpi4WveU5TQMB+2oNmoJ0GHBxuldcf1KQQfLzdE3oWIrEZ9+xufa3 dFM+x+ImgarSt6+UAJawDr2I1CpnIRHHH8gwW9H7TlzV5Dn0M6LnDNniBkML9dgdWlmLjJOHUDa A/N5rhuc7g9XMIdJkm8MALNnMdfmjgz1yQk2H3nBz6q/DveonrSbyZSd5THFPg7XiJc+FVLEupL UjWAm0AnyQsSZvVsmC0J92ZGiaEMGL/Zb6utD7a+wAUIhhMJL7ORg9P94Sn2kcLAH4RXdVRX41M 1j/9/+laqBNkghxMP/PYWfuuro633ed8xQSmBT0B65owVI0CN+VJCV5DfEagbF22Kh4l0+lPoG7 End0zNcyUdsEgUFJZXkKTmOTusWWGSrbhaJDqepWssBk9eLh8jPxNI9m2dztQTtq3ndzHS5UeDs N1SCwPOZt/Imer4aTlN7oHScmzFmVoWyibZ+Ce47KYiQ== X-Received: by 2002:a5d:5f83:0:b0:435:a83e:88e with SMTP id ffacd0b85a97d-435f3a6b975mr18413158f8f.2.1770105085362; Mon, 02 Feb 2026 23:51:25 -0800 (PST) Received: from [192.168.0.161] (78-154-15-142.ip.btc-net.bg. [78.154.15.142]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-435e1048a54sm48458131f8f.0.2026.02.02.23.51.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Feb 2026 23:51:24 -0800 (PST) Message-ID: Date: Tue, 3 Feb 2026 09:51:23 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v3] net: bridge: use sysfs_emit instead of sprintf To: David Corvaglia , idosch@nvidia.com Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, bridge@lists.linux.dev, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <0100019c1fc2bcc3-bc9ca2f1-22d7-4250-8441-91e4af57117b-000000@email.amazonses.com> Content-Language: en-US From: Nikolay Aleksandrov In-Reply-To: <0100019c1fc2bcc3-bc9ca2f1-22d7-4250-8441-91e4af57117b-000000@email.amazonses.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 02/02/2026 21:09, David Corvaglia wrote: > Replace sprintf with sysfs_emit in sysfs show() methods as outlined in > Documentation/filesystems/sysfs.rst. > > sysfs_emit is preferred to sprintf in sysfs show() methods as it is safer > with buffer handling. > > Signed-off-by: David Corvaglia > --- > v3: Fix whitespace issue. > v2: https://lore.kernel.org/bridge/0100019c1d2d46e0-a083f912-ac82-47e8-8cbb-ac9d70355ed3-000000@email.amazonses.com/ > Fix alignment of sysfs_emit arguments. > v1: https://lore.kernel.org/bridge/0100019c14f90490-950ddd9b-1897-4111-bddd-0d4b8abf380a-000000@email.amazonses.com/ > This is my first patch to the kernel! I've been able to build and boot > with the patch. I also tested the sysfs reads and they seem to be > correct. Any feedback is appreciated. > > net/bridge/br_stp_if.c | 8 +-- > net/bridge/br_sysfs_br.c | 108 +++++++++++++++++++-------------------- > net/bridge/br_sysfs_if.c | 32 ++++++------ > 3 files changed, 73 insertions(+), 75 deletions(-) > LGTM Acked-by: Nikolay Aleksandrov