From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755455AbdKNPoj (ORCPT ); Tue, 14 Nov 2017 10:44:39 -0500 Received: from 19pmail.ess.barracuda.com ([64.235.154.231]:55234 "EHLO 19pmail.ess.barracuda.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752887AbdKNPob (ORCPT ); Tue, 14 Nov 2017 10:44:31 -0500 Subject: Re: [PATCH] MIPS: ath25: Avoid undefined early_serial_setup() without SERIAL_8250_CONSOLE To: Ralf Baechle CC: James Hogan , , , Thomas Gleixner , Philippe Ombredanne , Kate Stewart , Greg Kroah-Hartman References: <1510666157-27252-1-git-send-email-matt.redfearn@mips.com> <20171114140534.GA14698@linux-mips.org> From: Matt Redfearn Message-ID: Date: Tue, 14 Nov 2017 15:43:43 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171114140534.GA14698@linux-mips.org> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.150.130.83] X-BESS-ID: 1510674247-452059-8516-521135-2 X-BESS-VER: 2017.14.1-r1710272128 X-BESS-Apparent-Source-IP: 12.201.5.28 X-BESS-Outbound-Spam-Score: 0.00 X-BESS-Outbound-Spam-Report: Code version 3.2, rules version 3.2.2.186917 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------- 0.00 BSF_BESS_OUTBOUND META: BESS Outbound X-BESS-Outbound-Spam-Status: SCORE=0.00 using account:ESS59374 scores of KILL_LEVEL=7.0 tests=BSF_BESS_OUTBOUND X-BESS-BRTS-Status: 1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14/11/17 14:05, Ralf Baechle wrote: > On Tue, Nov 14, 2017 at 01:29:17PM +0000, Matt Redfearn wrote: > >> Currently MIPS allnoconfig with CONFIG_ATH25=y fails to link due to >> missing support for early_serial_setup(): >> >> LD vmlinux >> arch/mips/ath25/devices.o: In function ath25_serial_setup': >> devices.c:(.init.text+0x68): undefined reference to 'early_serial_setup' >> >> Rather than adding dependencies to the platform to force inclusion of >> SERIAL_8250_CONSOLE together with it's dependencies like TTY, HAS_IOMEM, >> etc, just make ath25_serial_setup() a no-op when the dependency is not >> selected in the kernel config. > > Looks like arch/mips/rb532/serial.c might be suffering from the same > issue? Hi Ralf! Indeed it does, and another unmet dependency. Patches incoming. Thanks, Matt > > Ralf >