From: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
To: Youling Tang <tangyouling@loongson.cn>,
Josh Poimboeuf <jpoimboe@redhat.com>,
Peter Zijlstra <peterz@infradead.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [v2] tools/objtool: Fix unnecessary jumps
Date: Tue, 11 Aug 2020 20:54:10 +0530 [thread overview]
Message-ID: <c3cc66bb-bdf0-bc53-f7d3-75cf8d5f94d4@linux.vnet.ibm.com> (raw)
In-Reply-To: <1597119505-8038-1-git-send-email-tangyouling@loongson.cn>
On 11/08/20 9:48 am, Youling Tang wrote:
> There is no need to jump to the "out" tag when "ret < 0", just return
> directly to "ret".
>
> Signed-off-by: Youling Tang <tangyouling@loongson.cn>
the patch looks good to me, the commit message doesn't explain the
reason for the change. It can be written like:
"Previously cleanup() function was called under the out label for both
fatal errors (ret < 0) and warnings. Now that cleanup() function is
removed, the out label is no longer required. Remove it and return
immediately for the fatal errors with ret as return code and 0 for
warnings."
Reviewed-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
--
Kamalesh
prev parent reply other threads:[~2020-08-11 15:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-11 4:18 Youling Tang
2020-08-11 15:24 ` Kamalesh Babulal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c3cc66bb-bdf0-bc53-f7d3-75cf8d5f94d4@linux.vnet.ibm.com \
--to=kamalesh@linux.vnet.ibm.com \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=tangyouling@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®