From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93990C0015E for ; Mon, 7 Aug 2023 02:09:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229681AbjHGCID (ORCPT ); Sun, 6 Aug 2023 22:08:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35774 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229498AbjHGCIB (ORCPT ); Sun, 6 Aug 2023 22:08:01 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EF4051701 for ; Sun, 6 Aug 2023 19:08:00 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7743F612FE for ; Mon, 7 Aug 2023 02:08:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7E0EEC433C7; Mon, 7 Aug 2023 02:07:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691374079; bh=vEzRQjXv1ttsp5vdYXUk/AoSYOpDU/Q7NEu1H1UZQq0=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=hCsKvEeI+ES1k2p4uCYKudBehFAa7Mta/Px2N9VqjFRT4ZjKOyZpySoAlwJV8n9Os aoPng/Jrj6vmPom/o9mwXKXsV1UZOmEezUYtigJhF4Xwq6oUBHk3+kaxlC5bSMt+pr 7hL9cx2SoxFx1hQ8IKMEXKoUMjfAG3ttwr/I9bEY4FwrVTVhZE3knX70I4Hn/crfU5 9wFn5+tMFBgikj2pm/gg4bHBYiXJ1EauidipdUexDv3MF8SpCE4dji2F3z6HgHo5g4 xyrg2u0ZsX1MdofIRKqs1rZn7/Yu5Q46mrfphgZSYBU3Cg48fOAHmrkUKUU6Iau+mN w+XOdhDHY/Dyw== Message-ID: Date: Mon, 7 Aug 2023 10:07:56 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [f2fs-dev] [PATCH] f2fs: clean up w/ sbi->log_sectors_per_block Content-Language: en-US To: Shinichiro Kawasaki Cc: "jaegeuk@kernel.org" , "linux-kernel@vger.kernel.org" , "linux-f2fs-devel@lists.sourceforge.net" , Damien Le Moal References: <20230523123521.67656-1-chao@kernel.org> From: Chao Yu In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023/8/4 17:43, Shinichiro Kawasaki wrote: > On May 23, 2023 / 20:35, Chao Yu wrote: >> Use sbi->log_sectors_per_block to clean up below calculated one: >> >> unsigned int log_sectors_per_block = sbi->log_blocksize - SECTOR_SHIFT; > > Hello Chao, > > When I ran workloads on f2fs using v6.5-rcX with fixes [1][2] and a zoned block > devices with 4kb logical block size, I observe mount failure as follows. When > I revert this commit, the failure goes away. > > [ 167.781975][ T1555] F2FS-fs (dm-0): IO Block Size: 4 KB > [ 167.890728][ T1555] F2FS-fs (dm-0): Found nat_bits in checkpoint > [ 171.482588][ T1555] F2FS-fs (dm-0): Zone without valid block has non-zero write pointer. Reset the write pointer: wp[0x1300,0x8] > [ 171.496000][ T1555] F2FS-fs (dm-0): (0) : Unaligned zone reset attempted (block 280000 + 80000) > [ 171.505037][ T1555] F2FS-fs (dm-0): Discard zone failed: (errno=-5) > > The patch replaced "sbi->log_blocksize - SECTOR_SHIFT" with > "sbi->log_sectors_per_block". However, I think these two are not equal when the > device has 4k logical block size. The former uses Linux kernel sector size 512 > byte. The latter use 512b sector size or 4kb sector size depending on the > device. mkfs.f2fs obtains logical block size via BLKSSZGET ioctl from the device > and reflects it to the value sbi->log_sector_size_per_block. This causes > unexpected write pointer calculations in check_zone_write_pointer(). This > resulted in unexpected zone reset and the mount failure. > > I think this patch needs revert. What do you think? Hi Shinichiro, Oh, my bad, I think we need to revert that patch. Thanks for the report! :) Thanks, > > [1] https://lkml.kernel.org/linux-f2fs-devel/20230711050101.GA19128@lst.de/ > [2] https://lore.kernel.org/linux-f2fs-devel/20230804091556.2372567-1-shinichiro.kawasaki@wdc.com/