From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1167358AbdDXKJl (ORCPT ); Mon, 24 Apr 2017 06:09:41 -0400 Received: from szxga01-in.huawei.com ([45.249.212.187]:5789 "EHLO dggrg01-dlp.huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1167293AbdDXKJa (ORCPT ); Mon, 24 Apr 2017 06:09:30 -0400 From: John Garry Subject: Re: [PATCH] scsi: sas: move scsi_remove_host call into sas_remove_host To: Johannes Thumshirn , "Martin K . Petersen" References: <20170421121141.20701-1-jthumshirn@suse.de> CC: Christoph Hellwig , Linux Kernel Mailinglist , Linux SCSI Mailinglist , Hannes Reinecke , James Bottomley , Jinpu Wang , Linuxarm Message-ID: Date: Mon, 24 Apr 2017 11:09:03 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <20170421121141.20701-1-jthumshirn@suse.de> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.203.181.152] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020206.58FDCECF.01A3,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 1b52115836213ab6ebfd3128fd3e0428 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21/04/2017 13:11, Johannes Thumshirn wrote: > Move scsi_remove_host call into sas_remove_host and remove it from SAS HBA > drivers, so we don't mess up the ordering. This solves an issue with double > deleting sysfs entries that was introduced by the change of sysfs behaviour > from commit bcdde7e ("sysfs: make __sysfs_remove_dir() recursive"). > > Signed-off-by: Johannes Thumshirn > Suggested-by: Christoph Hellwig > Cc: Hannes Reinecke > Cc: James Bottomley > Cc: Jinpu Wang > Cc: John Garry For what it's worth: Tested-by: John Garry # On hisi_sas