From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5807C433FE for ; Fri, 22 Apr 2022 02:32:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1443371AbiDVCfQ (ORCPT ); Thu, 21 Apr 2022 22:35:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36114 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1443337AbiDVCfN (ORCPT ); Thu, 21 Apr 2022 22:35:13 -0400 Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 37B8A4B40C; Thu, 21 Apr 2022 19:32:19 -0700 (PDT) X-UUID: 6752f75ddda14dd2965f3ab6b1f0cd1c-20220422 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.4,REQID:93ca15cf-f748-4b1b-adef-2a610cd29006,OB:0,LO B:0,IP:0,URL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,RULE:Release_Ham,ACTI ON:release,TS:0 X-CID-META: VersionHash:faefae9,CLOUDID:c486b5ef-06b0-4305-bfbf-554bfc9d151a,C OID:IGNORED,Recheck:0,SF:nil,TC:nil,Content:0,EDM:-3,File:nil,QS:0,BEC:nil X-UUID: 6752f75ddda14dd2965f3ab6b1f0cd1c-20220422 Received: from mtkexhb01.mediatek.inc [(172.21.101.102)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1812272290; Fri, 22 Apr 2022 10:32:13 +0800 Received: from mtkcas10.mediatek.inc (172.21.101.39) by mtkmbs10n1.mediatek.inc (172.21.101.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.792.15; Fri, 22 Apr 2022 10:32:11 +0800 Received: from mtksdccf07 (172.21.84.99) by mtkcas10.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Fri, 22 Apr 2022 10:32:11 +0800 Message-ID: Subject: Re: [PATCH v20 2/8] soc: mediatek: add mtk-mutex support for mt8195 vdosys0 From: Jason-JH Lin To: CK Hu , Matthias Brugger , Chun-Kuang Hu , AngeloGioacchino Del Regno CC: Nancy Lin , Singo Chang , , , , , , Date: Fri, 22 Apr 2022 10:32:11 +0800 In-Reply-To: <82cc5e6900138e13ed9d75c6d2a42c6d7afc1959.camel@mediatek.com> References: <20220419094143.9561-1-jason-jh.lin@mediatek.com> <20220419094143.9561-3-jason-jh.lin@mediatek.com> <82cc5e6900138e13ed9d75c6d2a42c6d7afc1959.camel@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi CK, Thanks for the reviews. On Thu, 2022-04-21 at 14:50 +0800, CK Hu wrote: > Hi, Jason: > > On Tue, 2022-04-19 at 17:41 +0800, jason-jh.lin wrote: > > Add mtk-mutex support for mt8195 vdosys0. > > > > Signed-off-by: jason-jh.lin > > Acked-by: AngeloGioacchino Del Regno < > > angelogioacchino.delregno@collabora.com> > > Tested-by: Fei Shao > > --- > > drivers/soc/mediatek/mtk-mutex.c | 87 > > ++++++++++++++++++++++++++++++-- > > 1 file changed, 84 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/soc/mediatek/mtk-mutex.c > > b/drivers/soc/mediatek/mtk-mutex.c > > index aaf8fc1abb43..729ee88035ed 100644 > > --- a/drivers/soc/mediatek/mtk-mutex.c > > +++ b/drivers/soc/mediatek/mtk-mutex.c > > @@ -17,6 +17,9 @@ > > #define MT8183_MUTEX0_MOD0 0x30 > > #define MT8183_MUTEX0_SOF0 0x2c > > > > +#define MT8195_DISP_MUTEX0_MOD0 0x30 > > +#define MT8195_DISP_MUTEX0_SOF 0x2c > > This is identical to mt8183, so use mt8183 one instead of creating > new > one. > > Regards, > CK > I'll fix this in the next version. Regards, Jason-JH.Lin. > > > > > > +static const struct mtk_mutex_data mt8195_mutex_driver_data = { > > + .mutex_mod = mt8195_mutex_mod, > > + .mutex_sof = mt8195_mutex_sof, > > + .mutex_mod_reg = MT8195_DISP_MUTEX0_MOD0, > > + .mutex_sof_reg = MT8195_DISP_MUTEX0_SOF, > > +}; > > + > > > > -- Jason-JH Lin