From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932345AbdCXRpx (ORCPT ); Fri, 24 Mar 2017 13:45:53 -0400 Received: from mx2.suse.de ([195.135.220.15]:43737 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753131AbdCXRog (ORCPT ); Fri, 24 Mar 2017 13:44:36 -0400 Subject: Re: [PATCH] mm/page_alloc: use nth_page helper To: Geliang Tang , Andrew Morton , Mel Gorman , Michal Hocko , Johannes Weiner , Joonsoo Kim References: Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org From: Vlastimil Babka Message-ID: Date: Fri, 24 Mar 2017 18:43:49 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 24.3.2017 15:10, Geliang Tang wrote: > Use nth_page() helper instead of page_to_pfn() and pfn_to_page() to > simplify the code. Well I've never heard of this helper so I would have to look it up to see what it does. Looks like there's not many users. Anyway it's simpler to use just "page + i" if within MAX_ORDER_NR_PAGES, which should be the case here. That can also actually save a few cycles. Otherwise it looks like a pointless churn to me. > Signed-off-by: Geliang Tang > --- > mm/page_alloc.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index f749b7f..3354f56 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -2511,9 +2511,8 @@ void mark_free_pages(struct zone *zone) > &zone->free_area[order].free_list[t], lru) { > unsigned long i; > > - pfn = page_to_pfn(page); > for (i = 0; i < (1UL << order); i++) > - swsusp_set_page_free(pfn_to_page(pfn + i)); > + swsusp_set_page_free(nth_page(page, i)); > } > } > spin_unlock_irqrestore(&zone->lock, flags); >