From: "CK Hu (胡俊光)" <ck.hu@mediatek.com>
To: "angelogioacchino.delregno@collabora.com"
<angelogioacchino.delregno@collabora.com>,
"chunkuang.hu@kernel.org" <chunkuang.hu@kernel.org>
Cc: "dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"fshao@chromium.org" <fshao@chromium.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"kernel@collabora.com" <kernel@collabora.com>
Subject: Re: [PATCH v3 3/6] drm/mediatek: mtk_dpi: Switch to devm_drm_of_get_bridge()
Date: Thu, 27 Jul 2023 03:24:41 +0000 [thread overview]
Message-ID: <c3e1553b8f55e107b548bd14c60d55b6b46de0bb.camel@mediatek.com> (raw)
In-Reply-To: <20230726082245.550929-4-angelogioacchino.delregno@collabora.com>
Hi, Angelo:
On Wed, 2023-07-26 at 10:22 +0200, AngeloGioacchino Del Regno wrote:
> Function drm_of_find_panel_or_bridge() is marked as deprecated: since
> the usage of that in this driver exactly corresponds to the new
> function
> devm_drm_of_get_bridge(), switch to it.
Reviewed-by: CK Hu <ck.hu@mediatek.com>
>
> Signed-off-by: AngeloGioacchino Del Regno <
> angelogioacchino.delregno@collabora.com>
> Reviewed-by: Fei Shao <fshao@chromium.org>
> ---
> drivers/gpu/drm/mediatek/mtk_dpi.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c
> b/drivers/gpu/drm/mediatek/mtk_dpi.c
> index fdd5b7126e27..08822fe88c93 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dpi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c
> @@ -1062,10 +1062,10 @@ static int mtk_dpi_probe(struct
> platform_device *pdev)
> if (dpi->irq <= 0)
> return -EINVAL;
>
> - ret = drm_of_find_panel_or_bridge(dev->of_node, 0, 0,
> - NULL, &dpi->next_bridge);
> - if (ret)
> - return ret;
> + dpi->next_bridge = devm_drm_of_get_bridge(dev, dev->of_node, 0,
> 0);
> + if (IS_ERR(dpi->next_bridge))
> + return dev_err_probe(dev, PTR_ERR(dpi->next_bridge),
> + "Failed to get bridge\n");
>
> dev_info(dev, "Found bridge node: %pOF\n", dpi->next_bridge-
> >of_node);
>
next prev parent reply other threads:[~2023-07-27 3:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-26 8:22 [PATCH v3 0/6] drm/mediatek: Small mtk-dpi cleanups AngeloGioacchino Del Regno
2023-07-26 8:22 ` [PATCH v3 1/6] drm/mediatek: mtk_dpi: Simplify with devm_drm_bridge_add() AngeloGioacchino Del Regno
2023-07-27 3:11 ` CK Hu (胡俊光)
2023-07-26 8:22 ` [PATCH v3 2/6] drm/mediatek: mtk_dpi: Simplify with dev_err_probe() AngeloGioacchino Del Regno
2023-07-26 8:22 ` [PATCH v3 3/6] drm/mediatek: mtk_dpi: Switch to devm_drm_of_get_bridge() AngeloGioacchino Del Regno
2023-07-27 3:24 ` CK Hu (胡俊光) [this message]
2023-07-26 8:22 ` [PATCH v3 4/6] drm/mediatek: mtk_dpi: Switch to .remove_new() void callback AngeloGioacchino Del Regno
2023-07-26 8:22 ` [PATCH v3 5/6] drm/mediatek: mtk_dpi: Use devm_platform_ioremap_resource() AngeloGioacchino Del Regno
2023-07-26 8:22 ` [PATCH v3 6/6] drm/mediatek: mtk_dpi: Compress struct of_device_id entries AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c3e1553b8f55e107b548bd14c60d55b6b46de0bb.camel@mediatek.com \
--to=ck.hu@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chunkuang.hu@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=fshao@chromium.org \
--cc=kernel@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®