From: Jonathan Cameron <jic23@kernel.org>
To: Joe Perches <joe@perches.com>,
Brian Masney <masneyb@onstation.org>,
linux-iio@vger.kernel.org
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net,
linux-kernel@vger.kernel.org, ldewangan@nvidia.com
Subject: Re: [PATCH v3 2/2] staging: iio: isl29028: move out of staging
Date: Wed, 26 Apr 2017 07:03:23 +0100 [thread overview]
Message-ID: <c3e1c235-15b3-ebf6-d4f0-25a4a6dc6c9f@kernel.org> (raw)
In-Reply-To: <1493185750.18659.24.camel@perches.com>
On 26/04/17 06:49, Joe Perches wrote:
> On Wed, 2017-04-26 at 06:30 +0100, Jonathan Cameron wrote:
>> On 25/04/17 02:34, Brian Masney wrote:
>>> Move ISL29028 ALS / Proximity Sensor out of staging and into mainline.
>>>
>>> Signed-off-by: Brian Masney <masneyb@onstation.org>
>
> Hey Brian.
>
> Next time it's better to use git format-patch -M
> to reduce the patch size and show renames.
My fault :) For patches doing a move of an IIO driver
out of staging I've asked that people don't
use -M to encourage people to do a 'big picture' review
before we move them out of staging.
This particular one went pretty smoothly, but in some other
staging move patches it's been a different story!
As Brian has done quite a few of these he is getting pretty
good at it ;)
Jonathan
>
>> Applied to the togreg branch of iio.git
>>
>> Thanks,
>>
>> Jonathan
>>> ---
>>> drivers/iio/light/Kconfig | 10 +
>>> drivers/iio/light/Makefile | 1 +
>>> drivers/iio/light/isl29028.c | 723 +++++++++++++++++++++++++++++++++++
>>> drivers/staging/iio/light/Kconfig | 10 -
>>> drivers/staging/iio/light/Makefile | 1 -
>>> drivers/staging/iio/light/isl29028.c | 723 -----------------------------------
>>> 6 files changed, 734 insertions(+), 734 deletions(-)
>>> create mode 100644 drivers/iio/light/isl29028.c
>>> delete mode 100644 drivers/staging/iio/light/isl29028.c
>
> [quoted the entire patch]
>
> And Jonathan, please trim your replies a bit more.
>
> Thanks.
>
next prev parent reply other threads:[~2017-04-26 6:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-25 1:34 [PATCH v3 0/2] " Brian Masney
2017-04-25 1:34 ` [PATCH v3 1/2] staging: iio: isl29028: correct proximity sleep times Brian Masney
2017-04-26 5:30 ` Jonathan Cameron
2017-04-25 1:34 ` [PATCH v3 2/2] staging: iio: isl29028: move out of staging Brian Masney
2017-04-26 5:30 ` Jonathan Cameron
2017-04-26 5:49 ` Joe Perches
2017-04-26 6:03 ` Jonathan Cameron [this message]
2017-04-26 5:25 ` [PATCH v3 0/2] " Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c3e1c235-15b3-ebf6-d4f0-25a4a6dc6c9f@kernel.org \
--to=jic23@kernel.org \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=ldewangan@nvidia.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masneyb@onstation.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®