From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CFA3B2264DB for ; Sat, 16 Aug 2025 07:30:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755329402; cv=none; b=rQKeK+QPkO4fMWGCQlj9dZFM54b03EZuVZY9N6J5uZW2PAiGvcdysDQXA1b+6EBOZweMQHwWcz9rTAGVs/4Nksi75Wt4FwCT2nBhMilK/M8Qu2k94FEu7E0oEaSBB0yPsgWjs0HvHM8gS9jAKuXvh6cuGDllRXQ0pt4OuJyuR8g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755329402; c=relaxed/simple; bh=cW6/Kk6xhPjcm6HHtbxNdbs/mfaUPd0lad7M/sDHp+s=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=iyL3qAlySH/rotYqpUWLuQU2/55SkncttPeYLZRHysLKdM8saT2E4JaCRhVt85dZ60wwXS7WveX4b+SphFppE6ZXp1NPF6nMJxouxYE8eZ+VHsuZI4YRKZYwQJIURSxZoHzJktM75BxplZi7JSemtPD6/FJ8Rq2pQXR2RzHUmag= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=gBjnl2Rv; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="gBjnl2Rv" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1755329399; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=R5YdMvftyyNcqXdxEvGbyCjnA5x9aBSv+Dou4SkBOqo=; b=gBjnl2RvSQkpnuXvcIAOxs1/ISLwareaa4rYJPeEurYz8caOa4aD57abW/scynxZEiMbsP mN+WX1nH8hwmonniDt1uWGy4KqAaiXET6UzwQxfX94rBkikJS8uqIhDYVn4tZKFasdJM7B UQJINQina7j42PVaQjyS2kHFFfXPNoA= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-330-_qOSqIWYPjirlOrYxRB5qA-1; Sat, 16 Aug 2025 03:29:57 -0400 X-MC-Unique: _qOSqIWYPjirlOrYxRB5qA-1 X-Mimecast-MFC-AGG-ID: _qOSqIWYPjirlOrYxRB5qA_1755329396 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3b9d41b82beso2037179f8f.0 for ; Sat, 16 Aug 2025 00:29:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755329396; x=1755934196; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=R5YdMvftyyNcqXdxEvGbyCjnA5x9aBSv+Dou4SkBOqo=; b=Ie0Z5A/OkkBDMNBKLaFMJ4M4UuiyGCXDTCB6vXhcMuFl8BUO2QitB8brtava6mrthc PDT+VskkLarwbg9TkVSQ9tbF9PjbmLqMeDKHEmfXVPjXTSUwEiwYn9RDtB2EUMb2KVAF feyIjrk2zyx8pnD+z3ZRMIms8lOrcu79WK6dHCY86HMpnlZ2jVixnIiYJKX2IVD2E8qt IqprXQWAFHmqFnIaojeyIj0i7Ps7TyxdN+qBvLQej3XWEIeTzD/e8UbT62SIoIwbkja4 pqfmxdTdiTFfElKQjRNox4DiGtGa/W3JCzFAZav6jEMneURXXfN9kevyN5YO7dYmhF16 s+OA== X-Forwarded-Encrypted: i=1; AJvYcCV33017htFAW2Odh4cpnRh5XYrv6I/LXvmx2Qc9oRrjdmawr6FL6V/ZqznaGUy1i2f5FDj+80SKwaL90NI=@vger.kernel.org X-Gm-Message-State: AOJu0YyGvbhaMZzsYidd2jGqfgA2WYBYGBAWByTNLH7SR8GYIr8s50a8 LX+2cYI0cLgvLWcvhqQwXiEtXbfCkcBnYLeNW9AOkwZZ9nOKhV/iQrwrGg6Fkuuco1R6ZuPmKPi UA04lP90bSzNZ1q61gUAhobOnCJpd53Q0Gk/lS436gZYPsMwBH08KobVA9B67qfxREg== X-Gm-Gg: ASbGncu90cI2sREBk4bx7MzdO69PZmxeva9AMW7kdAz1ljwuHEKKH/jKeQFqageygbN 7qQ5WbILxO2aN6UL478tLaQXuCEwwAAQmkK+A/IDRfkmAD0bDuNalToegAn9+N+BQSsOWhW8wN2 xueSh+31WIAfMQugtNiqgIcu1OMahfDFGU7B8qqCv/w4zzwmDpu+P5+ST4QxESF8RLivFV416xQ jxsUWIOl8Dd6pOsqgf93oLzgcHrevNFIOaY5ASkaltywLKdYHAFz6UyZK8M5NtjoFdiq+DEk5oy 4POIlgUEQWxpKRbmNrbk0WZ66C8R+erI5bz7Owh/g28xrjrQSXKfWY+w/9jd+hWOt3+oWzUD3r3 GpDiJYAChTjR/p+VwWbwC3VzOwSKdYWmYrqtrNLAVooNdjxeThkqv3eyCZp/uYD0x6Fc= X-Received: by 2002:a05:6000:250e:b0:3b7:6205:25c7 with SMTP id ffacd0b85a97d-3bc684d7a6amr1161462f8f.13.1755329396431; Sat, 16 Aug 2025 00:29:56 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEdeZbLYVw/9iFVb7Qe06uYvO+L+q1zunUurrOjukRyliqvXYO4XKk8xjLSqGpY6omDRyef/A== X-Received: by 2002:a05:6000:250e:b0:3b7:6205:25c7 with SMTP id ffacd0b85a97d-3bc684d7a6amr1161440f8f.13.1755329396041; Sat, 16 Aug 2025 00:29:56 -0700 (PDT) Received: from ?IPV6:2003:d8:2f23:c700:d8ae:41bf:492a:9e4c? (p200300d82f23c700d8ae41bf492a9e4c.dip0.t-ipconnect.de. [2003:d8:2f23:c700:d8ae:41bf:492a:9e4c]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3bb6475863dsm4747109f8f.5.2025.08.16.00.29.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 16 Aug 2025 00:29:55 -0700 (PDT) Message-ID: Date: Sat, 16 Aug 2025 09:29:54 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/4] mm/memory_hotplug: Update comment for hotplug memory callback priorities To: Dave Jiang , linux-cxl@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: gregkh@linuxfoundation.org, rafael@kernel.org, dakr@kernel.org, dave@stgolabs.net, jonathan.cameron@huawei.com, alison.schofield@intel.com, vishal.l.verma@intel.com, ira.weiny@intel.com, dan.j.williams@intel.com, marc.herbert@linux.intel.com, akpm@linux-foundation.org References: <20250814171650.3002930-1-dave.jiang@intel.com> <20250814171650.3002930-2-dave.jiang@intel.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZoEEwEIAEQCGwMCF4ACGQEFCwkIBwICIgIG FQoJCAsCBBYCAwECHgcWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaJzangUJJlgIpAAKCRBN 3hD3AP+DWhAxD/9wcL0A+2rtaAmutaKTfxhTP0b4AAp1r/eLxjrbfbCCmh4pqzBhmSX/4z11 opn2KqcOsueRF1t2ENLOWzQu3Roiny2HOU7DajqB4dm1BVMaXQya5ae2ghzlJN9SIoopTWlR 0Af3hPj5E2PYvQhlcqeoehKlBo9rROJv/rjmr2x0yOM8qeTroH/ZzNlCtJ56AsE6Tvl+r7cW 3x7/Jq5WvWeudKrhFh7/yQ7eRvHCjd9bBrZTlgAfiHmX9AnCCPRPpNGNedV9Yty2Jnxhfmbv Pw37LA/jef8zlCDyUh2KCU1xVEOWqg15o1RtTyGV1nXV2O/mfuQJud5vIgzBvHhypc3p6VZJ lEf8YmT+Ol5P7SfCs5/uGdWUYQEMqOlg6w9R4Pe8d+mk8KGvfE9/zTwGg0nRgKqlQXrWRERv cuEwQbridlPAoQHrFWtwpgYMXx2TaZ3sihcIPo9uU5eBs0rf4mOERY75SK+Ekayv2ucTfjxr Kf014py2aoRJHuvy85ee/zIyLmve5hngZTTe3Wg3TInT9UTFzTPhItam6dZ1xqdTGHZYGU0O otRHcwLGt470grdiob6PfVTXoHlBvkWRadMhSuG4RORCDpq89vu5QralFNIf3EysNohoFy2A LYg2/D53xbU/aa4DDzBb5b1Rkg/udO1gZocVQWrDh6I2K3+cCs7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: <20250814171650.3002930-2-dave.jiang@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 14.08.25 19:16, Dave Jiang wrote: > Add clarification to comment for memory hotplug callback ordering as the > current comment does not provide clear language on which callback happens > first. > > Signed-off-by: Dave Jiang > --- > include/linux/memory.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/memory.h b/include/linux/memory.h > index 40eb70ccb09d..02314723e5bd 100644 > --- a/include/linux/memory.h > +++ b/include/linux/memory.h > @@ -116,7 +116,7 @@ struct mem_section; > > /* > * Priorities for the hotplug memory callback routines (stored in decreasing > - * order in the callback chain) > + * order in the callback chain). The callback ordering happens from high to low. > */ > #define DEFAULT_CALLBACK_PRI 0 > #define SLAB_CALLBACK_PRI 1 "stored in decreasing order in the callback chain" is pretty clear? It's a chain after all that gets called. -- Cheers David / dhildenb