From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EEFF226ED5C for ; Thu, 5 Mar 2026 17:53:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772733194; cv=none; b=OSCEbFiVfKVF423f5lk+AAa8SVMsrzw64jMu/ynYoizGT5wQRQcMqadeON2c2RRkMUh3+Q0E5fin60wVVuqSXj+SU+u8sLxmg9aUMU+mV7kx6nXf6Y5UQfD/w7l1JCVYh5L7gPhqAbgEZVIph3cP4c4nAtREMUQiYDcG5MNy1ZY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772733194; c=relaxed/simple; bh=ROWnuy6Rn+2HRwecaqRc3kEQ3SqRfK+w/L6FaAqeaAU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=gJD3vwdBcQrX2hNh88h+xHJSmTQmoC4TejcSFF2Qjx1VdSwbUsDTuUhAfdRyBvJNdK9lJncG0KtUUylj8X2OyMY+zJLYHDLqG2Va4+5T0nhEJ/FiTxuUGkfpnx8HrqK8zq73e9En3mVshFiNdMkjyXVjtMXnv0RwhNI7HFrtYsg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=JgU6YTaT; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=WHp/+bbQ; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="JgU6YTaT"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="WHp/+bbQ" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 625CMxRQ719996 for ; Thu, 5 Mar 2026 17:53:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= V5Ga9dDil/3B9VR9KlURzGCWzoPjqQ+IyQcq9xHkWKU=; b=JgU6YTaTq7fpD4MU S/8pEqJlucTfas4yiL+8tyzScKEy0/aBWrrcE0EfohZ+97WBx+BPQyOZR29zvIm1 5dfddeY0o5VWpFmTWiZvgbfARXYvWeMTDZLYa9btBL2LwmFwK47woY+EPLQ+IyL5 V4xkLgxANLR6ltvz9YyPvhjy+lN6ElrHGRGEoNDdER0Up1nC0R7JgnqxQAAusJqk 7Ac+lej1DB1166lHFOs0TLSdK1rrjNB/UJ+ztoXj4CBFyRvNsXpjma6FO8SW/J6Q vi3Z67EvA7QUT4PdpMbcQ3gS+xjH/XSQ/j2QIHOrG5REshh5g5PUAQBCjVmwi0hN J4iS7w== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cq9srh3bq-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 05 Mar 2026 17:53:11 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2ae61939fa5so76925875ad.0 for ; Thu, 05 Mar 2026 09:53:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772733191; x=1773337991; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=V5Ga9dDil/3B9VR9KlURzGCWzoPjqQ+IyQcq9xHkWKU=; b=WHp/+bbQ+t6tATg13HGHbrx0E5NO0SZyKD6Y6T2d/lEqnvYD9uPJJNkV5ULeh8/e5V N3dexkeqJQT8c03g/c629DBj5gFkPHBZu+lbwUFUm6AH8NI9igTiRCkTW2AKvIrsQM81 f98W2MnnxJbmivwaRqxIRncaeIhK6qWd9ia/Kt1HyOZ0Gw2lkInRjB2yVWfL/3VzNbNl v30O41wcCl6vLL1+1Uo1OIF1CQcMkseMm57N3GtfVwpuhdv4Ju5QDhc/S8eo9nHojXpv 407+6vmBpye0FPLbU3o/IG7Ry/AsCKfmgDeK3VYQWi3veRnfk09ouD4SWGVIntve/tns af/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772733191; x=1773337991; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=V5Ga9dDil/3B9VR9KlURzGCWzoPjqQ+IyQcq9xHkWKU=; b=T6sJ0qkX2z7MNtkkkBK3sC+F9M4jCDKGWDj9lPGCQiovGAPLU1Z6p2IgdZleS6ZSNG eHS3qmfrb5vh9Lhn5lY6dHKWNdeo/AJ1fRV/ruQ0EwxYqVDTNYICDEhcEHFB+G4l/YZ6 fAMr4yetibRYVx0w0TEsAmz/hT4zlxDWU/17k/fHIPCbyY379EuVpMQ8oJhrg0cE+t29 3qbaAIsIdQwaJ0dwcuOFyq0ST//01PzBIoftyfrOXHnHYlvAhqIO+V82yGeDhbidwFZQ 5A/r472TISPALmKKDy7guxYLYL8cx/gZXZqC6SBGGbseSYnNJiLpkN8/R2sXQFt3cGmv 5mHg== X-Forwarded-Encrypted: i=1; AJvYcCUTEpVcvfBYTx1YKWc6CYUVBgv2ZTR7khUExWdxpNmlQ+2/3GPZ8y6lgdNHJDzMNuIbMsstgDmqzjG+ud0=@vger.kernel.org X-Gm-Message-State: AOJu0Ywc1wxEhs2UN1oiIW9lF7E3J/2ageh65AHifavy9qQ66aUFcjrQ ubJblS0j6/aD1RR5PuWFfp7lUUuzOZXXIMzBu9tr9TtbCg7GwC+xjCvNZUme3anxLlpgTRoNAm5 brudQkskycct/nYhV3MIhr0j0VxrfFr7ildpbGHcGlhV3Dkh2Q0miWf7XF6Q4kUpjid4= X-Gm-Gg: ATEYQzw5WPA83XIuvLdgSCyeP+9M2pKcVPw0jDyeozYdHkqoJWX+bZUm+RFmQCzB0At pkCfKuSih6iHG97kFUKiw1NwkJ6jMkmvTgLxWKwb2bM9UXmN9LKdIa50RbJIWjbDiWyf/DRg6Tq NyE7cLvb5HHmxqsN64wfLFQqMsX2loVbxHBtBm1THDZ5VSpeQlaE4AQPcgkzVon53qfX+XyEWMn bPHIDUKv8ahtwPCGt2CDIq22w7fyf53koij5Fcx01pRbtmZWd+LxEkAf85hTK00ZBKfXcpz7OwH 2CFUTm3sW5wqSAudzoz82ganQQNsccCM9aPxujo0/HtCPmAC0372EXLoTw7IFkYrX8F0omYMsbS 057AUjIeL48RliuCFsvv/sR+i+ZkttdAVe0YmkYBIvCX5Mviaj3lGCKw= X-Received: by 2002:a17:903:38c8:b0:2ae:57e2:9b32 with SMTP id d9443c01a7336-2ae6a9ed5ffmr69921945ad.8.1772733190736; Thu, 05 Mar 2026 09:53:10 -0800 (PST) X-Received: by 2002:a17:903:38c8:b0:2ae:57e2:9b32 with SMTP id d9443c01a7336-2ae6a9ed5ffmr69921425ad.8.1772733190225; Thu, 05 Mar 2026 09:53:10 -0800 (PST) Received: from [192.168.29.31] ([49.43.226.5]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ae464ffff3sm143642605ad.42.2026.03.05.09.53.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Mar 2026 09:53:09 -0800 (PST) Message-ID: Date: Thu, 5 Mar 2026 23:22:59 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v20 08/10] arm64: dts: qcom: lemans: Add psci reboot-modes To: Konrad Dybcio , Lorenzo Pieralisi , Arnd Bergmann , Bjorn Andersson , Sebastian Reichel , Rob Herring , Souvik Chakravarty , Krzysztof Kozlowski , Andy Yan , Matthias Brugger , Mark Rutland , Conor Dooley , Konrad Dybcio , John Stultz , Moritz Fischer , Bartosz Golaszewski , Sudeep Holla Cc: Florian Fainelli , Krzysztof Kozlowski , Dmitry Baryshkov , Mukesh Ojha , Andre Draszik , Kathiravan Thirumoorthy , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Srinivas Kandagatla References: <20260304-arm-psci-system_reset2-vendor-reboots-v20-0-cf7d346b8372@oss.qualcomm.com> <20260304-arm-psci-system_reset2-vendor-reboots-v20-8-cf7d346b8372@oss.qualcomm.com> <4d4cb697-17c0-4610-b498-04a3bb252923@oss.qualcomm.com> Content-Language: en-US From: Shivendra Pratap In-Reply-To: <4d4cb697-17c0-4610-b498-04a3bb252923@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=a/I9NESF c=1 sm=1 tr=0 ts=69a9c307 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=mvMbtr4cKWCpcPtdaitTtQ==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=JqnQEXjPz3xb6-exIXoA:9 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-GUID: U0eCt9OiF1ddTFJ_wx49RNDP56vxfbiG X-Proofpoint-ORIG-GUID: U0eCt9OiF1ddTFJ_wx49RNDP56vxfbiG X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA1MDE0NyBTYWx0ZWRfX4chNRMpim+AX eK2PXXz7UbCH1y/P18oG5KXU2hZSjQbdnevg0KPXcoKWk2olgk2x0/pBO9jReYr9oF4tw5UIgEG +vFCUVxLG7FTuO9dbbhEbj+1fhDOCFHopigQsj3ELVHW30CGlV62Ji7T+uHLHRnTuki2BYLcbvn 5nxU57eatLbBAjektMrW/CeOWwTJrHJXjuiDksxA5XUKAOJ+82mVBlZ2gQagXaIoK7LO37EJCyq BYs0jY/L2WyptUEDH2C8RZXfxxBRD8JrWQGERRPcsYVBkTPbkMHgt1Q1mcvM2q+1agnaDTPz79m jbOgwGl8CCQQB5LQydifDwz5+WVZtqi6DEdh1TKMziDbYDcMatTNJEZRi/RpckvTl3Cxsm4mAfc PEDXoIAlUB81XDyUFdftidx8NlIdwGsiwScDb0hVC4FIUE6gvOfzuakCyM9+MQ+0U//LobkjEMe +zwQ7oMHRmFrnVI7lrQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-05_05,2026-03-04_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 priorityscore=1501 impostorscore=0 phishscore=0 bulkscore=0 suspectscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603050147 On 05-03-2026 17:03, Konrad Dybcio wrote: > On 3/4/26 7:03 PM, Shivendra Pratap wrote: >> Add PSCI SYSTEM_RESET2 reboot-modes for lemans based boards, for use by >> the psci_reboot_mode driver. >> >> The following modes are defined: >> - bootloader: reboot into fastboot mode for fastboot flashing. >> - edl: reboot into emergency download mode for image loading via >> the Firehose protocol. >> >> Support for these modes is firmware dependent. > > The previous patch only enabled it on a subset of kodiak boards, > the remaining ones do it globally, even though you claim it's fw > dependent.. this changed in in v17 apparently > Thanks. Let me review this and make it board specific wherever required. Will update this in next patch. > My fear is that those may conflict with other methods providing > identical identification names, i.e.: > > psci { > reboot-mode { > mode-bootloader = <0x80010001 0x2>; > mode-edl = <0x80000000 0x1>; > }; > }; > > imem@f000 { > reboot-mode { > compatible = "syscon-reboot-mode"; > offset = <0x65c>; > > mode-normal = <0x77665501>; > mode-bootloader = <0x77665500>; // conflict > mode-recovery = <0x77665502>; > }; > }; > > will the syscon write apply and the (unsupported) PSCI_RESET2 gracefully > fall through? If a SOC/board wants to use "syscon-reboot-mode" / "nvmem-reboot-mode" / psci->reboot-mode, has to be taken care in the DT as per support. Will make it board specific wherever required after re-review of the DTs. thanks, Shivendra