From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F417C43381 for ; Thu, 28 Mar 2019 13:11:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1B29F2173C for ; Thu, 28 Mar 2019 13:11:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="LZIBSxgP"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="LZIBSxgP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727018AbfC1NL6 (ORCPT ); Thu, 28 Mar 2019 09:11:58 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:35674 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725849AbfC1NL5 (ORCPT ); Thu, 28 Mar 2019 09:11:57 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 4B73F6083E; Thu, 28 Mar 2019 13:11:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1553778717; bh=lPWWY36gpiSPZu8B8aHT5/M73OwzVr/dYFR8bY2BPMQ=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=LZIBSxgP1cTaqCzYh5L2QE17XmU9ss5qRPfWyEpfB0ySC9znZd/JufXp30rbNO5iZ r7MmXD9TrwbH0zkN+7jSfBewKlUzNPmpPP4/DqdWGC9Ll7IltcX3sHEjo+7ITGL2Nl 3bQ0cOijqCHPzYSYwXlLJ88Ej+pmZYGHzf5FnIFw= Received: from [10.204.79.83] (blr-c-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: mojha@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id A24066053B; Thu, 28 Mar 2019 13:11:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1553778717; bh=lPWWY36gpiSPZu8B8aHT5/M73OwzVr/dYFR8bY2BPMQ=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=LZIBSxgP1cTaqCzYh5L2QE17XmU9ss5qRPfWyEpfB0ySC9znZd/JufXp30rbNO5iZ r7MmXD9TrwbH0zkN+7jSfBewKlUzNPmpPP4/DqdWGC9Ll7IltcX3sHEjo+7ITGL2Nl 3bQ0cOijqCHPzYSYwXlLJ88Ej+pmZYGHzf5FnIFw= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org A24066053B Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=mojha@codeaurora.org Subject: Re: [PATCH] gpio: mockup: use simple_read_from_buffer() in debugfs read callback To: Bartosz Golaszewski , Linus Walleij Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski References: <20190328110043.13391-1-brgl@bgdev.pl> From: Mukesh Ojha Message-ID: Date: Thu, 28 Mar 2019 18:41:50 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190328110043.13391-1-brgl@bgdev.pl> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/28/2019 4:30 PM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Calling read() for a single byte read will return 2 currently. Use > simple_read_from_buffer() which correctly handles all sizes. > > Fixes: 2a9e27408e12 ("gpio: mockup: rework debugfs interface") > Signed-off-by: Bartosz Golaszewski > --- > drivers/gpio/gpio-mockup.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/drivers/gpio/gpio-mockup.c b/drivers/gpio/gpio-mockup.c > index 74ba8b1d71d8..859585dce5c9 100644 > --- a/drivers/gpio/gpio-mockup.c > +++ b/drivers/gpio/gpio-mockup.c > @@ -219,12 +219,7 @@ static ssize_t gpio_mockup_debugfs_read(struct file *file, > val = gpio_mockup_get(gc, priv->offset); > cnt = snprintf(buf, sizeof(buf), "%d\n", val); why \n is inserted in the buf.. rv variable is unused now. > > - rv = copy_to_user(usr_buf, buf, cnt); > - if (rv) > - return rv; > - > - *ppos += cnt; > - return cnt; > + return simple_read_from_buffer(usr_buf, size, ppos, buf, cnt); Looks good to me. Remove the unused variable. Reviewed-by: Mukesh Ojha -Mukesh > } > > static ssize_t gpio_mockup_debugfs_write(struct file *file,