From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f181.google.com (mail-lj1-f181.google.com [209.85.208.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 43C5B12BF02 for ; Wed, 7 Aug 2024 14:58:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723042697; cv=none; b=dad98Ker+vAYDJx2bFlFOR6HB6jLYhgOEu6Zpp2blBc+d3w8diiQeeIm0g0S9m8VBvHlcvDV2l77PxJXLfhCS9H6nJxmSEbRgemP3SbHypQiRaNG0+beCITwho4qLrTI3FqHZQMlHSNCbYl30PMWei5Atd+9+0KX6OWcEyWkBDM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723042697; c=relaxed/simple; bh=2A9olRXkkurPhWoduGEq4sLP8Qa2x8nAbpkI9q6xYLk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=aC4u86IKs9csqrVGqkgptWaLRL+4qyxv5YZp+tu86yyAKJ9vI4xUvpQ3PmvdVatbLzTB9bouAczlcJHBmCywCT/Af/8EsNkMyiB3xc8Q58fuNF3p5oAOWe6gynB+qrABex/mtaAW8SPSCEHBnGO8/0DXtm7LYRiqwv0zrSzGSSc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=y7VfTSgQ; arc=none smtp.client-ip=209.85.208.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="y7VfTSgQ" Received: by mail-lj1-f181.google.com with SMTP id 38308e7fff4ca-2f149845d81so23429911fa.0 for ; Wed, 07 Aug 2024 07:58:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1723042693; x=1723647493; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ty6wu6NnvFiktV4jQYFBzkKafWYbgDqtBdyrFjL9W0I=; b=y7VfTSgQxyNECRCUtqnqeN9TSSvdBMStgcaktBRfzCSWk3ef9p8Y7bubarYRoZenab R/gOHHGoUn+sFuOh3iHFCLNRoe6sSDlUUXAyKZw14GPCgwA2Xw4Ay+0s4MTHdYW4+Z4m 4nDrx0dp20Bq5qSJjym7yrypx0IrH2Nf+tkswOirN3S5bewKzV6nyg6DjSx9Lv0Igw7Z 200+RF83A2UTwbhkWcN8di1e09LmXbFdLf9cPy7mceK88BabRNnB47j5M8ZCpSpkVAQP qiC5BMFPZ6c7lLO9XkJEEEtV57UlIBDFJa0yQLMkMbUiYqM7NT2eg/EVS1GozLJmjWK1 ULsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723042693; x=1723647493; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ty6wu6NnvFiktV4jQYFBzkKafWYbgDqtBdyrFjL9W0I=; b=UtjzlVtI1Of5OXxJsIH9e4p7Zj3Co+Y9AP9K5xiwc8tojZqPREatDx2uLVG9XYi4Je YO6O42/Y9UhOYuPp4sXYAJwX8YkgRPFGqv6oA5pREjSLdCyJTgupkzJgfcqzLwmAZeto c4ipOeKX+cy2i4yq+5kHqmjy1J8EcsH5nNke+irrLavQu7f8Ha7Fb1aLGLm69l/CzIgv chuwIew9MGIieInRBxpgntnHKDPQrDfRJDnRAxpSpc+BDgnxhOE6BMFYo9exjdT468BV ug7k4LBWJjx9+ZU+VTFQpkb3A6MikAWGYUw26cMbjyhBfS01zJ5SpLtrjNA7fw/535GX SYLQ== X-Forwarded-Encrypted: i=1; AJvYcCUmoXMtnS8k/cliOwkOQqNpZ2dIl5mSG413DPfot85ISA6/prGra+vYk6ls0MTyh8hEVWWweXhCdZ1ehDf86pyvmwJvWS8LM/OSgUcD X-Gm-Message-State: AOJu0YxsAB7ErHOIWnfvi8oSa2DfwlcWHxyRxTDtp6FjPWteGhzcvWcZ DnF6qYmLTR4/+tpi1q9/fRchZPwsj5/UfOA/0L2/7dNMZOl01pl0FYCBNTONwnc= X-Google-Smtp-Source: AGHT+IGXCHlz9/+c8YzxTWD7YCnzLHWWooLICTpK3cTNMLvpZfCquxkonb/+WZc2obkni9AL+ddSPg== X-Received: by 2002:a05:6512:ad1:b0:52d:8356:f6b9 with SMTP id 2adb3069b0e04-530bb39d25bmr14044602e87.38.1723042693166; Wed, 07 Aug 2024 07:58:13 -0700 (PDT) Received: from [192.168.0.25] ([176.61.106.227]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-429058026b0sm33690255e9.35.2024.08.07.07.58.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 07 Aug 2024 07:58:12 -0700 (PDT) Message-ID: Date: Wed, 7 Aug 2024 15:58:11 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm64: dts: qcom: sm8550: camss: Add CAMSS block definition To: Krzysztof Kozlowski , Depeng Shao , andersson@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@quicinc.com, Yongsheng Li References: <20240807123333.2056518-1-quic_depengs@quicinc.com> <1c0ff0fa-73d3-400f-a58d-15fb9b0574d1@kernel.org> <85cc52aa-4593-49f5-9438-1ee3f09d2d71@quicinc.com> <336e5679-f04e-47aa-9655-df88fde9de21@linaro.org> <0fb55319-0bae-4bb0-bce6-ebdbdd68f765@kernel.org> Content-Language: en-US From: Bryan O'Donoghue In-Reply-To: <0fb55319-0bae-4bb0-bce6-ebdbdd68f765@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 07/08/2024 15:51, Krzysztof Kozlowski wrote: > On 07/08/2024 16:17, Bryan O'Donoghue wrote: >> On 07/08/2024 13:53, Depeng Shao wrote: >>> Hi Krzysztof, >>> >>> On 8/7/2024 8:43 PM, Krzysztof Kozlowski wrote: >>>> On 07/08/2024 14:39, Krzysztof Kozlowski wrote: >>>>> On 07/08/2024 14:33, Depeng Shao wrote: >>>>>> Add CAMSS block definition for sm8550. >>>>>> >>>>>> This drop contains definitions for the following components on sm8550: >>>>> >>>>> 1. Subject: there is no prefix camss. There is no such file, directory >>>>> or module. >>>>> >>> >>> Thanks for the comment, will remove this. >>> >>>>> 2. You already sent this, so this should be v2 or v3 or vX. Provide >>>>> changelog under ---. >>>>> >>>>> If there is going to be resend, please fix above. >>>>> >>> >>> Sure, I thought it might be a new series, so I didn't add v*, will add >>> v1, and v2 change log in new version series. >>> >>>>> 3. If this was tested on aim300, I am surprised this being not enabled >>>>> on aim300. >>>> >>> >>> It was tested long times ago, but the patches wasn't sent out for >>> reviewing early due to the team's internal schedule. >>> >>>> One more thing, bindings were not accepted, thus this patch should not >>>> go in. There were no new bindings, so I assume patchset is using >>>> rejected ones. >>>> >>>> It's fine to send it to get some comments, although would be nice to >>>> mention to maintainer that this cannot be picked up as is. :( >>>> >>> >>> Sure, I will resend the dtsi patch until the bindings are accepted, send >>> this patches because you posted the comments in other series. >>> >>> https://lore.kernel.org/all/0324e8e8-2ad4-4ce6-9616-3038b8e02ff9@quicinc.com/ >>> >>> Thanks, >>> Depeng >>> >>> >> >> Recommend >> >> 1. Send out your yaml and dts in one series >> >> 2. Driver series can be posted in parallel > > The binding should go with the driver. Also usually discussion about > driver brings comments, thus changes, to the bindings. > > Sorry, DTSI and DTS should wait till bindings got accepted to media > subsystem. Yes you're right 1. Yaml - bindings 2. dts + driver 3. dtsi In this case @Depeng remember to 1. Link back to the older series in your cover letters 2. Suggested by recommended - publish a complete tree somewhere and link to that tree in your cover letters Its fine IMO to restart the version number of your series when breaking up into smaller series, so long as you remember to link to the previous series and explain in the cover letter whats going on. --- bod