From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 29AED1FDD for ; Tue, 1 Jul 2025 09:02:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751360579; cv=none; b=kch/xNaKxsImWliezv3v4aJ0e8OVjJ34kLaHZYLgATlci1oUd3vJXETlRUigI5QTy4CmZBA07UYhW0jLNaGz5k6AS4spShjV/Sd5L3w+Ks6GtE3BSRACmTJj4iEYRpc7feV3z4Il7qjSnbto+zkBVrTFq9a0kXPe8C0wuJ7ESxM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751360579; c=relaxed/simple; bh=1CRUAXr5GBbRdmumb0+cV0Od7MCxxqW2fhnqqDHHk8w=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=XxDYgVOJqxcs4ejrNr5V4VIZ4Er5seu+PNeZstB8+OhhrpzInGUcJ5eoLwlU3BqVsEnN2AvrCx8/w62jeNWxLtz/7SU3zm9mrJSKUjI3x0yFNlNGMsWwYiwQ8zzntQ7ERB64E84ZtkWBIzoFolevVU0ELC3sDAm1EBSpgJtVkcI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Q+gHXcV8; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Q+gHXcV8" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751360576; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=odFmyP7U2sVYXt+ILmpIyMRKTHdQ4Z+Ben4YpGt3RBA=; b=Q+gHXcV88/pQIu1kcI4uU1ZtbqLwG6jQDQw7WkWsAtQgFx6Ftg1WbMqueMTf7Kw2EiSOJM 1kCyrQKFST4ByxR6QRkZOQMc9SWFVpBuzrkpF269h/VjfptgJJi3KwXYwcK6+8+HWOyEdo ikpEsIXlJUHIO56Q54iyNKaMUFQ0f0c= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-607-LBLGkF0fPuaxYgpmrL4SWA-1; Tue, 01 Jul 2025 05:02:55 -0400 X-MC-Unique: LBLGkF0fPuaxYgpmrL4SWA-1 X-Mimecast-MFC-AGG-ID: LBLGkF0fPuaxYgpmrL4SWA_1751360574 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3a6d1394b07so3450810f8f.3 for ; Tue, 01 Jul 2025 02:02:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751360574; x=1751965374; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=odFmyP7U2sVYXt+ILmpIyMRKTHdQ4Z+Ben4YpGt3RBA=; b=YhFWvuKG2rJQn9KJOkZW2K2rwI5uPYorNuqHBrcJLK9C7+Ww79NM8PfdH2ns7oi/NQ i6HMoyRDEIS4UrkQKm1NIrhOJlMAmEyuqT3ihKya7pSXpBxPPpy0DN6Rx76taI4YRK8M 4Zea1olQVLB7u16qhQXq3y10Ndn+i6DcGSs9z0hGZjuPzWj/0mUWkGvD5gvvd3l4W65v 6xXlHBbWd0+rbDG9oxuN+LgOPeHCT1tO/lOzm1UxtEPAu4hQqWsiMy2IGSBMukQHL4i8 WFxpNOZr3p3SZY8CXJQUxQIVvBJflz04MC2ngSbBXsOmCXmCjjIPscJjQKgJRcwOGNZv qhGA== X-Forwarded-Encrypted: i=1; AJvYcCWHjHHfBLKV533cEoPdpYLasTY0ZmHEYsNzr91Ubkjc3rCPVc1zIKbCElo31D+cfB/rlqKPicFpG1PoHkI=@vger.kernel.org X-Gm-Message-State: AOJu0YyMQEcBrwQcWTaYwU9vq5PuSC12ZNBSCAzXkHajVZZJceJlWdEo wr8Qirq8NXXxQt38umxiglcXlj1xFrc5FKf1xWAvMPPNKoTuUhBRQUHy4fQN/kkFtMMIXet5Q18 MjqJgPxDuR1S7uQrirA1EAbRROaC8Owzdz6WW/J8acX33up2za1xzQwYGxZdXaoWqJw== X-Gm-Gg: ASbGnctrsiTlWVV3adkuO9bcQkKoR6qKntLJ2t8wX0AHq0vVuB0vAs7Mm7weQ8LCdqD otze9Vg0znVEbFZFfw9tPzk8KZOd3oUlKa0+q84ewz0TzcM9/yhRKhVUVAnlMJZdQnw070j1I6g zT5gUvuJoB/ObZLoEkmK0VV8AkUIMmb5yyUj1/KRZg3ARvkLrkNeqpTyktEJeodSOuEzi6z+Nx0 tcIzz3zJFLGv3zR7m5dXpla6KxWaRWU2IdE/09lEEOzm6qH55Wy+KBEFnrL0ITBe5b/baRSIN5S y6lY/QT6Em8pqKNOkEjogKQwP9BadY9auQe5tTViFbJfv/lkL44tO3Fbh0Kx8zi6lh0bkQ== X-Received: by 2002:adf:f6d1:0:b0:3a5:52cc:5e29 with SMTP id ffacd0b85a97d-3a90d0d7317mr11929796f8f.7.1751360573695; Tue, 01 Jul 2025 02:02:53 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGYRKtwQ5aZnc0XqPhfEJjz3LC5qLMurZ/9vUE7Xlx2VhB/BrreyXJkwS9hDRJ79YaRjeUeIA== X-Received: by 2002:adf:f6d1:0:b0:3a5:52cc:5e29 with SMTP id ffacd0b85a97d-3a90d0d7317mr11929762f8f.7.1751360573210; Tue, 01 Jul 2025 02:02:53 -0700 (PDT) Received: from ?IPV6:2a0d:3344:247b:5810:4909:7796:7ec9:5af2? ([2a0d:3344:247b:5810:4909:7796:7ec9:5af2]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4538a4064b1sm161825945e9.29.2025.07.01.02.02.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Jul 2025 02:02:52 -0700 (PDT) Message-ID: Date: Tue, 1 Jul 2025 11:02:50 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v2 0/9] net: Remove unused function parameters in skbuff.c To: Michal Luczaj , Jakub Kicinski Cc: "David S. Miller" , Eric Dumazet , Simon Horman , Neal Cardwell , Kuniyuki Iwashima , David Ahern , Boris Pismenny , John Fastabend , Ayush Sawal , Andrew Lunn , Wenjia Zhang , Jan Karcher , "D. Wythe" , Tony Lu , Wen Gu , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, linux-s390@vger.kernel.org References: <20250626-splice-drop-unused-v2-0-3268fac1af89@rbox.co> <20250630181847.525a0ad6@kernel.org> Content-Language: en-US From: Paolo Abeni In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 7/1/25 9:27 AM, Michal Luczaj wrote: > On 7/1/25 03:18, Jakub Kicinski wrote: >> On Thu, 26 Jun 2025 10:33:33 +0200 Michal Luczaj wrote: >>> Couple of cleanup patches to get rid of unused function parameters around >>> skbuff.c, plus little things spotted along the way. >>> >>> Offshoot of my question in [1], but way more contained. Found by adding >>> "-Wunused-parameter -Wno-error" to KBUILD_CFLAGS and grepping for specific >>> skbuff.c warnings. >> >> I feel a little ambivalent about the removal of the flags arguments. >> I understand that they are unused now, but theoretically the operation >> as a whole has flags so it's not crazy to pass them along.. Dunno. > > I suspect you can say the same about @gfp. Even though they've both became > irrelevant for the functions that define them. But I understand your > hesitation. Should I post v3 without this/these changes? Yes please, I think it would make the series less controversial. Also I feel like the gfp flag removal is less controversial, as is IMHO reasonable that skb_splice_from_iter() would not allocate any memory. Thanks, Paolo