mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Shrikanth Hegde <sshegde@linux.ibm.com>
To: Fushuai Wang <fushuai.wang@linux.dev>, yury.norov@gmail.com
Cc: wangfushuai@baidu.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] virt/steal_governor: Remove redundant delay filed
Date: Wed, 18 Nov 2026 14:34:24 +0530	[thread overview]
Message-ID: <c40ca6b2-a620-46ee-89e2-84a6a5313776@linux.ibm.com> (raw)
In-Reply-To: <20261118072722.1052-1-fushuai.wang@linux.dev>

Hi.

On 11/18/26 12:57 PM, Fushuai Wang wrote:
> From: Fushuai Wang <wangfushuai@baidu.com>
> 
> The 'delay' member in struct steal_governor is just a cache for
> msecs_to_jiffies(interval_ms). The duplicate state is confusing
> and adds no value. Use msecs_to_jiffies() directly at the schedule
> site and remove the 'delay' field.
> 

I guess you haven't seen the below change which is in tip tree.
https://lore.kernel.org/all/179421651800.2093942.14148413791803216183.tip-bot2@tip-bot2/

With that, we don't need the below change, since there is no more redundant field.


> Signed-off-by: Fushuai Wang <wangfushuai@baidu.com>
> ---
>   drivers/virt/steal_governor.c | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/virt/steal_governor.c b/drivers/virt/steal_governor.c
> index 6e31f9923dea..8af6c02c7e77 100644
> --- a/drivers/virt/steal_governor.c
> +++ b/drivers/virt/steal_governor.c
> @@ -38,7 +38,6 @@
>   struct steal_governor {
>   	ktime_t			time;
>   	u64			steal;
> -	unsigned long		delay;
>   	unsigned int		interval_ms;
>   	unsigned int		high_threshold;
>   	unsigned int		low_threshold;
> @@ -252,7 +251,7 @@ static void steal_governor_loop(struct work_struct *work)
>   	}
>   
>   requeue_work:
> -	schedule_delayed_work(&sg_ctx.work, sg_ctx.delay);
> +	schedule_delayed_work(&sg_ctx.work, msecs_to_jiffies(sg_ctx.interval_ms));
>   }
>   
>   static int __init steal_governor_init(void)
> @@ -270,11 +269,10 @@ static int __init steal_governor_init(void)
>   		return -EINVAL;
>   	}
>   
> -	sg_ctx.delay = msecs_to_jiffies(sg_ctx.interval_ms);
>   	INIT_DELAYED_WORK(&sg_ctx.work, steal_governor_loop);
>   	sg_ctx.steal = get_system_steal_time();
>   	sg_ctx.time = ktime_get();
> -	schedule_delayed_work(&sg_ctx.work, sg_ctx.delay);
> +	schedule_delayed_work(&sg_ctx.work, msecs_to_jiffies(sg_ctx.interval_ms));
>   	pr_info("enabled. interval: %ums, high_threshold: %u, low_threshold: %u\n",
>   		sg_ctx.interval_ms, sg_ctx.high_threshold, sg_ctx.low_threshold);
>   


  reply	other threads:[~2026-11-18  9:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18  7:27 Fushuai Wang
2026-11-18  9:04 ` Shrikanth Hegde [this message]
2026-11-18  9:16   ` fushuai.wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c40ca6b2-a620-46ee-89e2-84a6a5313776@linux.ibm.com \
    --to=sshegde@linux.ibm.com \
    --cc=fushuai.wang@linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wangfushuai@baidu.com \
    --cc=yury.norov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®