From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 53D761FE475 for ; Wed, 8 Jan 2025 19:27:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736364434; cv=none; b=EimBq5kGYxsWb/zqkNN2FxazZkcbZFjwOaDDUrOuYthHnvML1CZwsr2XazHE3k5vPQTBk46dLhO+M4VrMKsdInHlueDOStJt7WN0XBt6bfvTDDMgyIeWdrSyjiDj+JOnuKV88GWFyXMZpcanR0Ex5JqxyOlsG9MbAfFRRYTTCGA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736364434; c=relaxed/simple; bh=pw/FsvYE+CnTiDBgvymlSNWc4Q+Zlu4oGKwvOxe+o0c=; h=From:Message-ID:Date:MIME-Version:Subject:To:Cc:References: In-Reply-To:Content-Type; b=GRqh1fnVBPUGjFE0YkJ+ZVEKlXDNnWm8La5ticgh54Tp0SKtN5CHIuSt5fHb8sS2pQ5WyNRe9jOqVkstwYzB1DZGgGou/iRebQqeCuIosXi8Iig8PeUSjo7w3tjVL28S8MnvOJ0PfQna+Qn2ufy1nUEzWNlh7sDb8LONgUk/Bt0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=KtN25z7f; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="KtN25z7f" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1736364431; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gP3aIu1+OB4c7o2rwAtjitLd1P5sRrPYbvM9yHWN2VY=; b=KtN25z7ft1++WVnseLCioBkc6EaRveL2IWRKr6I1IZuUVD61inJ/I83QAwJsUx/Ey+36LC TSd8m5y3NTxVigFWB8pP3TKvTpQXvQdkJ1rfmTsR3PCFzU08U1RfZA2dIWUkKXE7iyaka6 SePeBkV0+qobV2PkGjJjdHZGL9nBtEc= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-210-oo3qIdTXOU6u8yNLjzwCww-1; Wed, 08 Jan 2025 14:27:09 -0500 X-MC-Unique: oo3qIdTXOU6u8yNLjzwCww-1 X-Mimecast-MFC-AGG-ID: oo3qIdTXOU6u8yNLjzwCww Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-6d889fd0fd6so2561716d6.0 for ; Wed, 08 Jan 2025 11:27:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736364429; x=1736969229; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gP3aIu1+OB4c7o2rwAtjitLd1P5sRrPYbvM9yHWN2VY=; b=mToq+tqoCoAuVC1UdPE+RuQMVotrDwamdOJCnDbhKjvXLZOgZWM8ssm0lnxEURmmr1 G0Yi+ZCKMgwhrgigILUQrvH+RakPIgYOEOIi5dbgNbq3sebyTwrJEcF9Tvb/AsVu9zNu 7HDZb/lL8e0rdA5Q3/5EzJ/Xdnn2J6GuLIo1zWbclBAUp5JmG7EdNFRaXVaosZaBLLHO ACwuBhSG6crubXvUVoI2lyaiiH18QfZQxs2ffMYB3Q7x0gOyYD/DHNmUecB43b8zeQBH e8gCsx0R/P8TVCmvpGH4a/IhagF8C/v3UMEmWYxy1dR/pPlEQZH5WtNxdLQtvMo1HDnW it+Q== X-Forwarded-Encrypted: i=1; AJvYcCWrF8V06fQb3fKZbl1NczJdHAZ40z08D1Qf+1yrlZLYmLn6VgxBzBvVvbVQMlzbQ3XqI3+7MZ3Iii3SiNw=@vger.kernel.org X-Gm-Message-State: AOJu0Yz4+I/ynKNTjWyk/JoChCBzPczWsJXhe+HI5GqwZr4WLFmuOlSk z8EJKeXaS1qR0hJuBkS2UTODwkZYOhxbjCF43snap2/OwtlownC72eTQvdOB2TANiWVQD0IuXU9 AdqMy9/spgGSC758qefpoOtbAG8TUcdfSlB+gAJWHICfubQp3KzBlAWMuXbD1PQ== X-Gm-Gg: ASbGncs95z+EFBnAh5mrRkGR0Jlc7e5JlpqOvM1RHIRa7zRvBScBQuAFnlNIlc4as1d ZwV6mdOWjMbwXE+Q7ihO6V6V06ORbIryclIS5nHcrPbiYkRbuIPgKZIu7hjssRz2c86N6NOIDoL Hu9AzyOVZf6Q8DF8xRcvDOpZr9eu7sXlQHhV/w6vSqP3fwSsV4s2bL+2cEsdmp7Y8cUR8F2hPTr q20VT8rS+8t8H4sfjeBvtys9FBKFGAWarJcNEU+V3o5ooE9vQF8DeNiDafksYepeVWpuHBGvYAr jliOgBi7FLz9StXdJ3i3616x X-Received: by 2002:ad4:5c49:0:b0:6d8:88c2:af5f with SMTP id 6a1803df08f44-6dfa3a44bb2mr7841366d6.1.1736364429279; Wed, 08 Jan 2025 11:27:09 -0800 (PST) X-Google-Smtp-Source: AGHT+IEsdEUM/Ng0/IdiFwFJ2tD5qvpbj9umQ3m+xwFAGWmJp3c4NTcSTr78qkCRq6vExpQlKdy+3g== X-Received: by 2002:ad4:5c49:0:b0:6d8:88c2:af5f with SMTP id 6a1803df08f44-6dfa3a44bb2mr7841116d6.1.1736364428965; Wed, 08 Jan 2025 11:27:08 -0800 (PST) Received: from ?IPV6:2601:188:ca00:a00:f844:fad5:7984:7bd7? ([2601:188:ca00:a00:f844:fad5:7984:7bd7]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6dd180ea73esm192292546d6.18.2025.01.08.11.27.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Jan 2025 11:27:08 -0800 (PST) From: Waiman Long X-Google-Original-From: Waiman Long Message-ID: Date: Wed, 8 Jan 2025 14:27:07 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] cgroup/cpuset: remove kernfs active break To: Tejun Heo , Chen Ridong Cc: hannes@cmpxchg.org, mkoutny@suse.com, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250106081904.721655-1-chenridong@huaweicloud.com> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/8/25 11:53 AM, Tejun Heo wrote: > Waiman, what do you think? > This patch looks good me. However, this does raise a question that I overlook when I made hotplug operation synchronous while task transfer, if needed, remained asynchronous. There is a very slight chance where we keep removing tasks added after execution capability is restored. As cgroup v1 is in the process of being deprecated, do you think we still need to do something to address this issue? Cheers, Longman