mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "yukuai (C)" <yukuai3@huawei.com>
To: <airlied@linux.ie>
Cc: <linux-kernel@vger.kernel.org>, <yi.zhang@huawei.com>
Subject: Re: [PATCH] agp: remove set but not used variable 'current_size'
Date: Mon, 7 Jun 2021 17:11:35 +0800	[thread overview]
Message-ID: <c40f9df5-0637-4c47-1f79-ff4b5bedbab1@huawei.com> (raw)
In-Reply-To: <e44124e2-fc8b-e726-8bb2-d39095155d0d@huawei.com>

ping ...

On 2021/05/29 17:05, yukuai (C) wrote:
> ping...
> 
> On 2021/05/14 14:22, Yu Kuai wrote:
>> Fixes gcc '-Wunused-but-set-variable' warning:
>>
>> drivers/char/agp/via-agp.c:131:28: warning: variable ‘current_size’
>> set but not used [-Wunused-but-set-variable]
>>
>> It is never used, and so can be removed.
>>
>> Signed-off-by: Yu Kuai <yukuai3@huawei.com>
>> ---
>>   drivers/char/agp/via-agp.c | 3 ---
>>   1 file changed, 3 deletions(-)
>>
>> diff --git a/drivers/char/agp/via-agp.c b/drivers/char/agp/via-agp.c
>> index 87a92a044570..dc594f4eca38 100644
>> --- a/drivers/char/agp/via-agp.c
>> +++ b/drivers/char/agp/via-agp.c
>> @@ -128,9 +128,6 @@ static int via_fetch_size_agp3(void)
>>   static int via_configure_agp3(void)
>>   {
>>       u32 temp;
>> -    struct aper_size_info_16 *current_size;
>> -
>> -    current_size = A_SIZE_16(agp_bridge->current_size);
>>       /* address to map to */
>>       agp_bridge->gart_bus_addr = pci_bus_address(agp_bridge->dev,
>>

      reply	other threads:[~2021-06-07  9:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-14  6:22 Yu Kuai
2021-05-29  9:05 ` yukuai (C)
2021-06-07  9:11   ` yukuai (C) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c40f9df5-0637-4c47-1f79-ff4b5bedbab1@huawei.com \
    --to=yukuai3@huawei.com \
    --cc=airlied@linux.ie \
    --cc=linux-kernel@vger.kernel.org \
    --cc=yi.zhang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®