From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DFEEC6379F for ; Tue, 21 Feb 2023 14:53:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234194AbjBUOxS (ORCPT ); Tue, 21 Feb 2023 09:53:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44158 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234597AbjBUOxJ (ORCPT ); Tue, 21 Feb 2023 09:53:09 -0500 Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8D9FEE059 for ; Tue, 21 Feb 2023 06:52:58 -0800 (PST) Received: by mail-wm1-x32b.google.com with SMTP id o4-20020a05600c4fc400b003e1f5f2a29cso3827647wmq.4 for ; Tue, 21 Feb 2023 06:52:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arista.com; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=4flrelf56q/oJe/E7sU2PM2CO001TFeEynbBfVMOqMI=; b=TW4K5RWWKJ3o5Vx79Kq3QzNBAAIz5xgZ5XFegj8oUmvhpe72VJ45FRDjWQ8vobE6Fp B8XtcbwbqOzf8sXQeMps5N4cQMHG4GhGrhQzu49+nna+GVNLPh5vX/YPj5sE4tB68cA3 mYUwX1wvTdPzy04ZNbvIkH/BJrRTkzTHFNuPclm+p095AyHFcuPPOTZlW4ANHoipa1TS tuAN1P1aFuDBfQTN7PKmUNCQfbiGSqKB0rnEe/r/6Wjy40+b4YE2F/RMbeW8EYdRW4ZV IO2fpMF/mXs9ma0lXrwyFhUD6PYdI0yVXRzXBwiMzhNrMkWB+qeiVbR2wKDqFdbYn/QL DLpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4flrelf56q/oJe/E7sU2PM2CO001TFeEynbBfVMOqMI=; b=B3JhXHkMTajQ67b9hDxrhq2e6Ny46beuUXD0+Hsv6DY3tw1kLH64HRcFO7UEeLnlZ2 rOnEK0T1JhmdPzitSdna6Oy8Lz7E1TsKRjokcAGlOVvGWVJc3ZKZkiblWwGhamh/aPNN dcWc+nnmtH6TblwJC+Ow5x7nd1GkWTLF/GXfdJ3N8TBpIqOE3oOQ0jsfd871w5qi/7Gt XvFrBidtlpHX0jzlyYr21GfG3+PFUAMclk+i6zLuStdRr8Lg587fEGzJ9lWDsMay8qAf MNc1erv8VR6I1qRzJfHVHtWIrUt07Z9Ya6inXfJPYexyiTaukqujlLYEHCMMsxqjR6Ck i4Pg== X-Gm-Message-State: AO0yUKWLm1epWAnJtYmjvmM2NrHfGR32+6WiNsqHXOODhlkW/DPzachF 81sGj2ZGFFqI505wuxzX9y3Uqw== X-Google-Smtp-Source: AK7set/xqZCuwDpnjxxc1vPFmsVK2UHSxoaT6SmGE+l6AjtIshfzen7HC5pVbj8Hsj/HDQPViIh30A== X-Received: by 2002:a05:600c:2ad6:b0:3df:eb5d:fbf with SMTP id t22-20020a05600c2ad600b003dfeb5d0fbfmr3336047wme.38.1676991176778; Tue, 21 Feb 2023 06:52:56 -0800 (PST) Received: from [10.83.37.24] ([217.173.96.166]) by smtp.gmail.com with ESMTPSA id j16-20020a056000125000b002c5706f7c6dsm1686184wrx.94.2023.02.21.06.52.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Feb 2023 06:52:55 -0800 (PST) Message-ID: Date: Tue, 21 Feb 2023 14:52:49 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH v4 01/21] net/tcp: Prepare tcp_md5sig_pool for TCP-AO Content-Language: en-US To: Herbert Xu Cc: linux-kernel@vger.kernel.org, David Ahern , Eric Dumazet , Paolo Abeni , Jakub Kicinski , "David S. Miller" , Andy Lutomirski , Ard Biesheuvel , Bob Gilligan , David Laight , Dmitry Safonov <0x7f454c46@gmail.com>, Eric Biggers , "Eric W. Biederman" , Francesco Ruggeri , Hideaki YOSHIFUJI , Ivan Delalande , Leonard Crestez , Salam Noureddine , netdev@vger.kernel.org References: <20230215183335.800122-1-dima@arista.com> <20230215183335.800122-2-dima@arista.com> From: Dmitry Safonov In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/21/23 02:43, Herbert Xu wrote: > On Mon, Feb 20, 2023 at 04:57:20PM +0000, Dmitry Safonov wrote: > . >> Do you have a timeline for that work? >> And if you don't mind I keep re-iterating, as I'm trying to address TCP >> reviews and missed functionality/selftests. > > I'm hoping to get it ready for the next merge window. Nice! I'll mark this 1/21 patch as [draft], mentioning your work as it will need to be re-made using per-request keys. Still, I will keep iterating TCP-AO patches set during 6.3 RCs in order to get more reviews/suggestions related to TCP changes. >> 1) before your per-request key patches - it's not possible. >> 2) after your patches - my question would be: "is it better to >> kmalloc(GFP_ATOMIC) in RX/TX for every signed TCP segment, rather than >> pre-allocate it?" >> >> The price of (2) may just well be negligible, but worth measuring before >> switching. > > Please keep in mind that you're already performing crypto which > is usually a lot slower than a kmalloc. In any case, if there is > any optimisation to be done to make the kmalloc faster by using > pools, then that optimisation should go into mm. Fair point. Probably, kmalloc() is negligible. I'll measure as I have a patch for iperf for TCP-MD5/TCP-AO measurements. Thanks, Dmitry