From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE7F072618 for ; Tue, 25 Aug 2026 06:50:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787640649; cv=none; b=OiwpxPOBnfR+fS+juNekglSpFhQUryLPGhzFbNXWalXBTLOp1jP/NW0kKwbfHneJM7SNV9wfcprBueSlb9srGzn5TLBDLptfHRaLAS8116Zd5+dl1VQAjNCjYdCwtSLeuWfUZ0QSESV21PtePzxdQPifX2Ahqn9WmV06ze3Eymg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787640649; c=relaxed/simple; bh=i8VI9BikSJXa+9bQr2dfakd0o8o9kHnUCSJ5vYXXnEw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=KujDxlX789rPS2G+2v9Jy77PKxO+bTgq/Mzo5NjnhecHVJHLQXNDEgv5T4PkaBF+N0sKE2PAP+Q0F2B2g8uxGbzVdCZHuhOVTqwZKuLNvZpvVZNmmVMs0FJCj82RckWoWkEkz7OQQAkMan/yGEuKzFx4Eq2kPJNKRdKE/DEqUqM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=QCrh+/Qa; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=SuBoQ3Oe; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="QCrh+/Qa"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="SuBoQ3Oe" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67P40lE4228259 for ; Tue, 25 Aug 2026 06:50:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= oNl++Du6VHiN6HOj1SJl6WWq3CHouNZ3mdv2us/L06Y=; b=QCrh+/QaYsIen1IX Ylu5f0lZcPYjGYc9jc3pLFpnsV5uYfU/Ol1HyKXxxHvDo3CrjAXmHitvfVyH1Ey0 xSuWiHjwE6+ykf02DLkaWp3yuRm0zujPrd7DEvTN8rNPehtMbuhqrjygy26U4K1N LsvLXnHYLlWiCXxH/dVAg5fvSXD2FFLrnCid1sqBMgAeclQTzo/GXAcEmW/sUSSE 6xeYhMGKjtQnPdVrZaLf66M3JBa8QTb7uktUazVoUe5D9PeqwKlco3oEADdFg6Q4 aLyAyHR4/7mV7a2j0qov37hFqvUFpvWdJpeaHH+E+iRKJ8ISSrZ+GTJ+m4eJyC9L PtGiIg== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g93narhdh-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 25 Aug 2026 06:50:46 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2cc640dfde3so53437155ad.1 for ; Mon, 24 Aug 2026 23:50:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787640641; x=1788245441; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=oNl++Du6VHiN6HOj1SJl6WWq3CHouNZ3mdv2us/L06Y=; b=SuBoQ3OeZzxNRy3YZ6xEl3ZMtBdmofPnBWvMKvRLDKYohf2RtpUSgvMZ0wfdxaL91+ 6iqx6C7Dj1/eXtTEFqvf4zmGnneV6BLQUfb/On7ajDauS8CgRJ/jV7VQIhvmYEdPYs1U zpqfGsK9da+KaobnyCy9Nd9ayaH/ABVhrETtLL/tVQMVZRpvakLuJDom1m0opVnAzKxF XhcmAvIq6cf8+r4IKrFJZNwVdH110rXzKj+2roGzfs6h6Pd/1E4Niv8yGmWBPi8LC/eX bRtbUJMHuxnqT5MYI+o5tWStmJ9q+nMA23lcWaUL7N5hlDkjTS3zvpaMfMUL8B7HX4/a Yxhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787640641; x=1788245441; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=oNl++Du6VHiN6HOj1SJl6WWq3CHouNZ3mdv2us/L06Y=; b=L8apC0ZGGkdkM9GFaBHiATu8IpJhKWz+qPZyOyB8OGV2XgmQ3kwzV3k5Z1XLuvFczz IgQEB+jvRkzJ9kBjFCz7yzYhHWbtKNpgSunZ3NoyqppS1PoHt8UEg+74GBdJphgK8KhS qY8zFv3J0NpjCud39nlCv8w94ed0PHmSjNq6/04FclTd2MC0VP6Y4oBB6BCYRKEU3RCQ Ax+SeQzlAf316VyVyj0ybwe0AYwGwwv04IHUE7muMQhCymgNfz5P1zLAZkek4s/FjSie +NVbr0d4sh7JzGn7TpYlLnexMIWSNy5t5cvMCDKchS27QC9bIkL7mIpNril04yBJSqdM NzWA== X-Forwarded-Encrypted: i=1; AHgh+RqHzfULMgJtcS8dwOBo0FCf3cEob2uXWg13+w/npDBZ56lSNG/vBFbmyEqYWLdUcb05jv9ps5JnuwiS+Gs=@vger.kernel.org X-Gm-Message-State: AFuF++lGceOPhCbQ7WP31H+usih7X8GX0hda6OXWzKQBkrNV4F4+HIDu hLhEVYTm8CCCEKMnARjEnSGM6/FafKrckPtYkLtOPKAVHJzjRKmpQmteKzkmyU+sKwmWYFnxBri H8+1PPT9qvnNybWVT/oIXzA8rHprKxJXZWCg/kCNidyE5i3thTuyJokDfwiZPOGoX/QY= X-Gm-Gg: AR+sD126h6BHWhJfAUKBm7BxeR3vaK6555M/KU8onXO1Sq+JM0N2gV7quY08MA9+JcM MhxbfKsZBG1yFxYv2KJj3eANkwL07/oeqiA7CzSjpf2DeRfrUNlfwAHa3dhiBy//5EC7NK0SY2D H9SJnVa/SFT2PtcUBe3j9xpyGUiQeK9AJE8fthLBezfm0Xysww87FrSk/pTTJAhR4AiWaV02bqz ArYew6mn5ulM4VkiF/pPrmug4HnZqoIluhq8OHCjaE8YTEY3ioJXqWti9g5gesKfg9ugWvWN1Uc C1U8NHOpxzGb14lJmCJ7yK0lgttGoAXBCTtiB4jsJ5S7UqQraaK1HeiKnek0FZFMOpzzl0RNrGJ OoVA+wePbsgsikTlUrWfukmMPYv3EyA71/uUIpNDcQQYYb3FsuIV4dwtQ/YgY6q0q8C05icuU X-Received: by 2002:a17:903:26cc:b0:2d6:f9e2:af7f with SMTP id d9443c01a7336-2d6f9e2b022mr3980605ad.1.1787640641268; Mon, 24 Aug 2026 23:50:41 -0700 (PDT) X-Received: by 2002:a17:903:26cc:b0:2d6:f9e2:af7f with SMTP id d9443c01a7336-2d6f9e2b022mr3979575ad.1.1787640640848; Mon, 24 Aug 2026 23:50:40 -0700 (PDT) Received: from [10.133.33.108] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2d67cbde1fasm23573815ad.56.2026.08.24.23.50.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Aug 2026 23:50:40 -0700 (PDT) Message-ID: Date: Tue, 25 Aug 2026 14:50:35 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RESEND v5 11/25] drm/msm/dp: move link-level teardown from display_disable to display_unprepare To: Dmitry Baryshkov Cc: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Jessica Zhang , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Abhinav Kumar References: <20260629-msm-dp-mst-v5-0-2ed6aee1867a@oss.qualcomm.com> <20260629-msm-dp-mst-v5-11-2ed6aee1867a@oss.qualcomm.com> <4las62mpvcuud6m6yo2mz6hiijv73zt27hnha4tlaejubt25x5@gxralblac3m4> Content-Language: en-US From: Yongxing Mou In-Reply-To: <4las62mpvcuud6m6yo2mz6hiijv73zt27hnha4tlaejubt25x5@gxralblac3m4> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwODI1MDA1NiBTYWx0ZWRfX696Y3TWcCdGe 2pdL3hKqHk0sswB2kMqRlgrJy/JieGXDndcdKdxfJ5i9/L8jywfHIXJbKZhNTOcwiOtxD1pbqOM YKeFlh9wfW8MmkjpMH+/B8NGp6Gvqxg= X-Proofpoint-ORIG-GUID: 58B7iV0UavZAWmVkHMCTj21QECI9Muh- X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODI1MDA1NiBTYWx0ZWRfXz1mjDXCaWnBe kwp7G8vOyERvAJnhJ5ut0D+FC4NPBuez79fqvZ6Nfe4kcDL6qB6trqyOrM+UJU9zzZevQnuou9p eIEi9L1O3tmCrAj9DdXOhHWt77plHa1gLOw4QJ3p1k+bk50yWhg85vB/i0UQCH2vgH702BAMUYO 2Avx77nxD5bz2Z+n1/Su9kOwwpaZMKgmLSqpUHeG4RzrcicRhXGUw8xC24pAvAZDTA/KbUitNDm hzEVBV1Ewn9sSZhjGYFxiOUiRJkf23jXKzpTH3A8L0+gtM1IL0AItSaXrbGuO8B4ZKZVJu+W/vf EfAQngY4asjyeiKSzPYQHGwJss8E9BUF3S8I5y2vbcJKkFNZH1+HRJAoY+r317cUtdZ4vMJVzHu 1v7P8fQw9v+IMC6oFuy8Ir6aYwOcuG111sd0QXUFU++XEmGYjMlYlI50iIi1JQlCNj495cVqR0J WGKTwMw5TwCEYd1Q3MQ== X-Proofpoint-GUID: 58B7iV0UavZAWmVkHMCTj21QECI9Muh- X-Authority-Analysis: v=2.4 cv=W74IkxWk c=1 sm=1 tr=0 ts=6a8d3b46 cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=COk6AnOGAAAA:8 a=EUspDBNiAAAA:8 a=3ssPzueCi6W0KKmKcc8A:9 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-25_01,2026-08-24_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=0 priorityscore=1501 impostorscore=0 clxscore=1015 spamscore=0 lowpriorityscore=0 bulkscore=0 phishscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608250056 On 7/13/2026 2:20 AM, Dmitry Baryshkov wrote: > On Mon, Jun 29, 2026 at 10:14:32PM +0800, Yongxing Mou wrote: >> From: Abhinav Kumar >> >> msm_dp_display_disable() currently mixes stream-level shutdown >> (disable VSC SDP, off pixel clk, clear power_on) with link-level >> teardown (PSM config when sink_count==0, off_link, PHY re-init or >> host PHY exit). >> >> For DP MST the same link is shared across multiple streams, so >> disabling one stream must not tear down the link. Move the >> link-level steps into msm_dp_display_unprepare() so that >> display_disable() handles only the per-stream sequence, mirroring >> the split already present on the prepare path >> (display_prepare_link vs display_set_mode / display_enable). >> >> SST behaviour is unchanged: atomic_post_disable() still calls >> display_disable() followed by display_unprepare() in the same >> order, and the cached dp->panel used inside unprepare is the same >> panel that was previously passed in. >> >> Signed-off-by: Abhinav Kumar >> Signed-off-by: Yongxing Mou >> --- >> drivers/gpu/drm/msm/dp/dp_display.c | 24 ++++++++++++------------ >> 1 file changed, 12 insertions(+), 12 deletions(-) >> >> diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c >> index 1af56c84b82e..1680a67284a7 100644 >> --- a/drivers/gpu/drm/msm/dp/dp_display.c >> +++ b/drivers/gpu/drm/msm/dp/dp_display.c >> @@ -731,18 +731,6 @@ static int msm_dp_display_disable(struct msm_dp_display_private *dp, >> >> msm_dp_ctrl_off_pixel_clk(dp->ctrl, msm_dp_panel->stream_id); >> >> - /* dongle is still connected but sinks are disconnected */ >> - if (dp->link->sink_count == 0) >> - msm_dp_link_psm_config(dp->link, &msm_dp_panel->link_info, true); >> - >> - msm_dp_ctrl_off_link(dp->ctrl, dp->panel); >> - >> - if (dp->link->sink_count == 0) >> - /* re-init the PHY so that we can listen to Dongle disconnect */ >> - msm_dp_ctrl_reinit_phy(dp->ctrl); >> - else >> - msm_dp_display_host_phy_exit(dp); >> - >> msm_dp_display->power_on = false; > > The list is no longer powred on at this point. So, this is wrong. > Got it, here should also move to msm_dp_display_unprepare(). >> >> drm_dbg_dp(dp->drm_dev, "sink count: %d\n", dp->link->sink_count); >> @@ -1533,6 +1521,18 @@ static void msm_dp_display_unprepare(struct msm_dp_display_private *dp) >> { >> struct msm_dp *msm_dp_display = &dp->msm_dp_display; >> >> + /* dongle is still connected but sinks are disconnected */ >> + if (dp->link->sink_count == 0) >> + msm_dp_link_psm_config(dp->link, &dp->panel->link_info, true); >> + >> + msm_dp_ctrl_off_link(dp->ctrl, dp->panel); >> + >> + if (dp->link->sink_count == 0) >> + /* re-init the PHY so that we can listen to Dongle disconnect */ >> + msm_dp_ctrl_reinit_phy(dp->ctrl); >> + else >> + msm_dp_display_host_phy_exit(dp); >> + >> pm_runtime_put_sync(&msm_dp_display->pdev->dev); >> >> drm_dbg_dp(dp->drm_dev, "type=%d Done\n", msm_dp_display->connector_type); >> >> -- >> 2.43.0 >> >