Re: [PATCH 1/2] nouveau/dmem: Fix privileged error in copy engine channel

[Yonatan Maman <ymaman@nvidia.com>]

On 30/09/2024 14:09, Danilo Krummrich wrote:
> External email: Use caution opening links or attachments
> 
> 
> Hi Yonatan,
> 
> On Mon, Sep 23, 2024 at 01:54:56PM +0000, Yonatan Maman wrote:
>> When `nouveau_dmem_copy_one` is called, the following error occurs:
>>
>> [272146.675156] nouveau 0000:06:00.0: fifo: PBDMA9: 00000004 [HCE_PRIV]
>> ch 1 00000300 00003386
>>
>> This indicates that a copy push command triggered a Host Copy Engine
>> Privileged error on channel 1 (Copy Engine channel). To address this
>> issue, modify the Copy Engine channel to allow privileged push commands
>>
>> Fixes: 6de125383a5cc
>> Signed-off-by: Yonatan Maman <Ymaman@Nvidia.com>
>> Signed-off-by: Gal Shalom <GalShalom@Nvidia.com>
> 
> Please read [1] and use scripts/checkpatch.pl and scripts/get_maintainer.pl
> before sending patches.
> 
> In particular, the 'Fixes' tag has a defined format, I recommend:
> 
> ```
> [core]
>          abbrev = 12
> [pretty]
>          fixes = Fixes: %h (\"%s\")
> ```
> 
> in your `.gitconfig`.
> 
> Also make sure so use 'Co-developed-by' if there is a co-author; I see that this
> patch is also signed off by Gal Shalom.
> 
> Please also send the patches to all relevant mailing lists and maintainers to
> avoid your patches not getting the required attention.
> 
> [1] https://docs.kernel.org/process/submitting-patches.html

Thanks for the feedback! I will address these comments and send V2 
patch-set.

> 
>> ---
>>   drivers/gpu/drm/nouveau/nouveau_drm.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/nouveau/nouveau_drm.c b/drivers/gpu/drm/nouveau/nouveau_drm.c
>> index a58c31089613..0a75ce4c5021 100644
>> --- a/drivers/gpu/drm/nouveau/nouveau_drm.c
>> +++ b/drivers/gpu/drm/nouveau/nouveau_drm.c
>> @@ -356,7 +356,7 @@ nouveau_accel_ce_init(struct nouveau_drm *drm)
>>                return;
>>        }
>>
>> -     ret = nouveau_channel_new(drm, device, false, runm, NvDmaFB, NvDmaTT, &drm->cechan);
>> +     ret = nouveau_channel_new(drm, device, true, runm, NvDmaFB, NvDmaTT, &drm->cechan);
>>        if (ret)
>>                NV_ERROR(drm, "failed to create ce channel, %d\n", ret);
>>   }
>> --
>> 2.34.1
>>