From: David Lechner <dlechner@baylibre.com>
To: Marcelo Schmitt <marcelo.schmitt@analog.com>,
lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
marcelo.schmitt1@gmail.com
Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] iio: adc: ad4000: Add timestamp channel
Date: Fri, 15 Nov 2024 11:07:11 -0600 [thread overview]
Message-ID: <c42a5815-78b0-46d0-8592-e9bbeac12e16@baylibre.com> (raw)
In-Reply-To: <7cb2f4f5ca6980e0e5ff4591fb8b7f53124e13bb.1731626099.git.marcelo.schmitt@analog.com>
On 11/14/24 5:50 PM, Marcelo Schmitt wrote:
> The ADC data is pushed to the IIO buffer along with timestamp but no
> timestamp channel was provided to retried the time data.
> Add a timestamp channel to provide sample capture time.
>
> Signed-off-by: Marcelo Schmitt <marcelo.schmitt@analog.com>
> ---
> I was about to reply to the patches the other week but waited thinking I
> would be able to test them on time.
> My initial intent was to provide timestamps for ADC readings, but I didn't
> realize an IIO timestamp channel would be needed (silly me).
> David, do you want a Suggested-by tag in this one?
I supposed that would make more sense than Reported-by: if we are
calling this a feature rather than a bug. Also,
Reviewed-by: David Lechner <dlechner@baylibre.com>
next prev parent reply other threads:[~2024-11-15 17:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-14 23:50 [PATCH 0/4] Timestamp and PulSAR support for ad4000 Marcelo Schmitt
2024-11-14 23:50 ` [PATCH 1/4] dt-bindings: iio: adc: adi,ad4000: Add PulSAR Marcelo Schmitt
2024-11-15 17:06 ` David Lechner
2024-11-18 11:24 ` Marcelo Schmitt
2024-11-18 15:39 ` David Lechner
2024-11-18 18:25 ` Marcelo Schmitt
2024-11-18 18:33 ` David Lechner
2024-11-24 13:11 ` Jonathan Cameron
2024-11-25 18:43 ` Conor Dooley
2024-11-14 23:50 ` [PATCH 2/4] iio: adc: ad4000: Add timestamp channel Marcelo Schmitt
2024-11-15 17:07 ` David Lechner [this message]
2024-11-14 23:51 ` [PATCH 3/4] iio: adc: ad4000: Use device specific timing for SPI transfers Marcelo Schmitt
2024-11-15 17:07 ` David Lechner
2024-11-18 11:34 ` Marcelo Schmitt
2024-11-14 23:51 ` [PATCH 4/4] iio: adc: ad4000: Add support for PulSAR devices Marcelo Schmitt
2024-11-15 17:14 ` David Lechner
2024-11-18 11:37 ` Marcelo Schmitt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c42a5815-78b0-46d0-8592-e9bbeac12e16@baylibre.com \
--to=dlechner@baylibre.com \
--cc=Michael.Hennerich@analog.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.schmitt1@gmail.com \
--cc=marcelo.schmitt@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®