From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA35FC4361B for ; Fri, 11 Dec 2020 18:09:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 83D0423106 for ; Fri, 11 Dec 2020 18:09:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729517AbgLKQ4g (ORCPT ); Fri, 11 Dec 2020 11:56:36 -0500 Received: from smtprelay0012.hostedemail.com ([216.40.44.12]:44428 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2392006AbgLKQz4 (ORCPT ); Fri, 11 Dec 2020 11:55:56 -0500 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay01.hostedemail.com (Postfix) with ESMTP id 98932100E7B4A; Fri, 11 Dec 2020 16:55:15 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: way72_3403e2027402 X-Filterd-Recvd-Size: 2030 Received: from XPS-9350.home (unknown [47.151.137.21]) (Authenticated sender: joe@perches.com) by omf14.hostedemail.com (Postfix) with ESMTPA; Fri, 11 Dec 2020 16:55:14 +0000 (UTC) Message-ID: Subject: Re: [PATCH -next] fs/xfs: convert comma to semicolon From: Joe Perches To: David Laight , 'Eric Sandeen' , Zheng Yongjun , "linux-xfs@vger.kernel.org" , "darrick.wong@oracle.com" , "linux-kernel@vger.kernel.org" Date: Fri, 11 Dec 2020 08:55:12 -0800 In-Reply-To: <5f4ee9cf48a445cea25ba01bc9ffdf13@AcuMS.aculab.com> References: <20201211084112.1931-1-zhengyongjun3@huawei.com> <5f4ee9cf48a445cea25ba01bc9ffdf13@AcuMS.aculab.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.38.1-1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2020-12-11 at 16:17 +0000, David Laight wrote: > From: Eric Sandeen > > Sent: 11 December 2020 15:51 > > > > On 12/11/20 2:41 AM, Zheng Yongjun wrote: > > > Replace a comma between expression statements by a semicolon. > > > > > > Signed-off-by: Zheng Yongjun > > > > hah, that's an old one. Harmless though, AFAICT. > > > > this fixes 91cca5df9bc8 ("[XFS] implement generic xfs_btree_delete/delrec") > > if we dare add that tag ;) > > It doesn't 'fix' anything, it is just stylistic. > Completely harmless in every sense. True, so it's not necessary to add a fixes tag here. The only time a comma->semicolon conversion could 'fix' something is when it's unintentionally used after something like an if statement if (foo) bar(), baz(); where now baz() is performed only when the if condition is true but the indentation indicates that it should always be performed.