From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 121C02EAE5; Mon, 28 Jul 2025 02:49:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753670991; cv=none; b=VWijXYAhQRi6i+Oa0hwwhvZSUncrUMklGzhdHw1765R+mekGOK+rEfGSRzwp0gpi+ZVBsrNUY3SnOLIjrNIIjX8L4X0mxdrjubnwcLek1ywMSOaxzmtsXNpT0mBaUtztH8N8fd1j273jK2pRNdXOKV4koJAxijdkj7nJQBXBcTs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753670991; c=relaxed/simple; bh=AVuRZOvYZsiFfwU6cAIHhxNEFaYF8i+dnfrjAK3EgsQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=g9WD6fLJcQQ6QuLo7fNMWm1XuoT7sAwLsMDAhseYKrdPyxgsH0Dp9kDS3fZ32iM1bVhgkRorcHKJmztVdcz8wnjbUZKl/NpUhzkjDdIJWtRwmjp4AgLc9ZQc2QZiuzqRyvfgIAT9eowN5JuM/WeG6Yku0M1tginqXw3hV6xEOjA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=oPQLvFP3; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="oPQLvFP3" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=as/pGkfaKJZ4VchcYP1ApYHiu/TLHPFvOgtxMx7Fe6k=; b=oPQLvFP38Eb+Qifd2IydHclM2/ F7Quz3N0r9OT54iE+OzE8LA/ZQ+90hyp1bSbA8Tq3IpbntFNshji7Qe/Esu5A3L1WN6HSiqWAi+YZ QNU8eB0FFqjTQvDuv7wf/9OleEljzvLYJXifdMk7sO/0pEF6/DWHjp5gpiO6DSZzzFxs=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1ugDvg-00337A-0n; Mon, 28 Jul 2025 04:49:32 +0200 Date: Mon, 28 Jul 2025 04:49:32 +0200 From: Andrew Lunn To: Tian <27392025k@gmail.com> Cc: irusskikh@marvell.com, netdev@vger.kernel.org, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: atlantic: fix overwritten return value in Aquantia driver Message-ID: References: <20250727231750.25626-1-27392025k@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250727231750.25626-1-27392025k@gmail.com> On Sun, Jul 27, 2025 at 04:17:50PM -0700, Tian wrote: > From: tian <27392025k@gmail.com> > > In hw_atl_utils.c and hw_atl_utils_fw2x.c, a return value is set and then > immediately overwritten by another call, which causes the original result > to be lost. This may hide errors that should be returned to the caller. > > This patch fixes the logic to preserve the intended return values. Please include in the commit message why it is safe to OR together two error codes. Andrew