From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B64953FDBEA for ; Mon, 10 Aug 2026 18:12:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786385536; cv=none; b=F6qBnMYI8lS2mIGax3bYw+bXbAImcqSF+p6Ap5lSK2/VrRsVrQygv9cIGWEGrsaofQ5RQKlUXBP05F9hfzOXjcuU6ZqPQIKmcNd5YVOVKVrVrgyqe+IrnvyLEM6Ef1AGTcOf/wD9TDhLtDiI1SmlbwewcSKVtAAAhLRxbZo7e3A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786385536; c=relaxed/simple; bh=Ig/1w3EhJGHkFtqnBVPKsssBgUok5xYMLMpIf8SMxu4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=G6mGqVEmZKzH73gphGOyuvu+EVmGVpdc4kenUdHjOQoP1HZ2PdW2RpHQpZVuow/oJDGfNp/N0lkNu7eOZOatEphb4J0X9Qx7+HAfqcGKCyKcd8RfRht+J8hpJ++k6pUJcbmQNBib5GLHfo7MLMBCBcSr/BzD577ciGXDca+Hut0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=aeNDYg7d; arc=none smtp.client-ip=209.85.216.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aeNDYg7d" Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-38dfe7eb825so1848671a91.0 for ; Mon, 10 Aug 2026 11:12:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786385534; x=1786990334; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=T/4gAs3IWqMAs/xTmYl6h6Ls6/U+dnIqpId4Zr1VebI=; b=aeNDYg7dbduNaaJJCqTfL8HCAzBZVDhjiKSPrWjc0eTVUDVSRNHwIXqsnvTeYCajfm hgzngL4rpJfGQNuKXj+nNVihw9nqg6g6oVY6BUU8fhJUBgniQRbX3O16htpVPSkCop+G DcPicZkE6tIkcJZoVOSkB7dN114iNLQJQ6vjPkdARv73Zt0CvjJdmhhtf13qn3WtvFfI RTrBS6Qr8Xxz1UYwcI43XWJDv59Jeu5NOstm+EK2dIV8kBWywUdqaa8nSdQFseQlwVOA LYHaHjhUiWNV3wr201tOBHwJQEWce1de44bs7kjYK0TQAvViYqUYktUq/nDuS/BxCX/E Dc6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786385534; x=1786990334; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=T/4gAs3IWqMAs/xTmYl6h6Ls6/U+dnIqpId4Zr1VebI=; b=CEQLpubpCGTgPQeXcF7/8YFVm7CWSOzDSmsXgBygVoqTo5AYdCBps88JP+i8pkWnFc Wd6RmIAJoyZyGSHwqBkGbuLL3pN3wuRuFIwJrospggtGcVbaF+DCYl4GebFMZ3iNA5E+ au/3L9R1vFStgKUQyluk/+kQ9eCLKUiCwZGd1KjGxzp/lResloUj67oQNaNFIldnheZV teaqY7yjrccef7tuLPkaCsojsDQ6DaQxppmao3ag/Xw5yatZtWDF19M8xy+UJEHCh1sj veAbBVnNeiu01zMOZeOM/XIz1k4aBhN1hWts2rYcSeD5qo0B38CqSvB7hNw0zwoc8Qol VWew== X-Forwarded-Encrypted: i=1; AHgh+RpH/g08+qfqm/tvGxJcY46x+NsgtH0r9oDU2qDCJYiirbDxieSBpQBR5MFJurMduq/C2GwjHPEmL7Ht4AI=@vger.kernel.org X-Gm-Message-State: AOJu0YxTDm+4VrNbh+ULN9Xfm1tdjoDW9lQ37xJWOvQ35zw3hYOuRADL W8EKQAPgr+F4i4+O3UkACvJM8pkmdMT2KRZDbnh+MjYBRiV1eYnPVCc4 X-Gm-Gg: AR+sD12G0d0pUNANvMOmO/n9Wrowsd36AFZ6kLjwnhVeQmM9ZBZrj0Ut8QAJnM9Cpgy 0D24Wk3GtVxZFCHGZX6KlkGppeKAtld0WgnQ3+OXwxWzDlgrilW/hseAjtv9ScCzcY3HaNzPxDk Nf2NhGFLUPtu2IW0m217C1s5O+FFgaAEixUOHB2LwAg3KDLC1DkjfZDi0CapNwBw5V+IZ7mkddy VIRU5axk/Z0GTjQoNtXIWrffmRluE4fO/ZFCMZEZf20S/TCfReIKXisoE1Ilqq38wC+Jbi/gVbl 8q/LUsoTgVCssCTrsdh2Q8+RR8hp3rI1WXBI555ZrQyYpxHKt29IxV6FzOiTJN22qFpZSXSMcv8 c8aqUdOtva1U3ARs/PrConiW6FD4LLJSzsbvZvP0b2GTQQ9UPUZUBHoMQzUvxyl9mhIJbONpEBB fybafC9DsolsGtAyYOfFt7LmCja08fY12P0O8XtGQ7Ewj7BOdBh3zjSe8wK52G28LflOWASefcn sI= X-Received: by 2002:a17:90b:2242:b0:37f:c28a:de61 with SMTP id 98e67ed59e1d1-3909d8e4c62mr27811550a91.17.1786385534137; Mon, 10 Aug 2026 11:12:14 -0700 (PDT) Received: from cryptic.lan ([2001:569:7fa9:fa00:b1a9:6513:83c6:1d23]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-392d53b873asm472795a91.17.2026.08.10.11.12.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Aug 2026 11:12:13 -0700 (PDT) From: Allen Pais To: Vinod Koul , Frank Li Cc: Allen Pais , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, Arnd Bergmann , Kees Cook Subject: [PATCH v3 14/34] dmaengine: nbpfaxi: switch callbacks to dmaengine BH Date: Mon, 10 Aug 2026 11:09:15 -0700 Message-ID: X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Replace the per-channel tasklet with the shared dmaengine BH helper. The handler continues to run in softirq context while dmaengine owns the common scheduling and teardown mechanism. Signed-off-by: Allen Pais --- drivers/dma/nbpfaxi.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/dma/nbpfaxi.c b/drivers/dma/nbpfaxi.c index 05d7321629cc..7dd5fc55228d 100644 --- a/drivers/dma/nbpfaxi.c +++ b/drivers/dma/nbpfaxi.c @@ -174,7 +174,6 @@ struct nbpf_desc_page { /** * struct nbpf_channel - one DMAC channel * @dma_chan: standard dmaengine channel object - * @tasklet: channel specific tasklet used for callbacks * @base: register address base * @nbpf: DMAC * @name: IRQ name @@ -200,7 +199,6 @@ struct nbpf_desc_page { */ struct nbpf_channel { struct dma_chan dma_chan; - struct tasklet_struct tasklet; void __iomem *base; struct nbpf_device *nbpf; char name[16]; @@ -1125,9 +1123,10 @@ static struct dma_chan *nbpf_of_xlate(struct of_phandle_args *dma_spec, return dchan; } -static void nbpf_chan_tasklet(struct tasklet_struct *t) +static void nbpf_chan_tasklet(struct dma_chan *c) { - struct nbpf_channel *chan = from_tasklet(chan, t, tasklet); + struct nbpf_channel *chan = container_of(c, struct nbpf_channel, + dma_chan); struct nbpf_desc *desc, *tmp; struct dmaengine_desc_callback cb; @@ -1228,7 +1227,7 @@ static irqreturn_t nbpf_chan_irq(int irq, void *dev) spin_unlock(&chan->lock); if (bh) - tasklet_schedule(&chan->tasklet); + dmaengine_schedule_bh(&chan->dma_chan); return ret; } @@ -1272,7 +1271,7 @@ static int nbpf_chan_probe(struct nbpf_device *nbpf, int n) snprintf(chan->name, sizeof(chan->name), "nbpf %d", n); - tasklet_setup(&chan->tasklet, nbpf_chan_tasklet); + dmaengine_init_bh(&chan->dma_chan, nbpf_chan_tasklet); ret = devm_request_irq(dma_dev->dev, chan->irq, nbpf_chan_irq, IRQF_SHARED, chan->name, chan); @@ -1478,7 +1477,7 @@ static void nbpf_remove(struct platform_device *pdev) devm_free_irq(&pdev->dev, chan->irq, chan); - tasklet_kill(&chan->tasklet); + dmaengine_kill_bh(&chan->dma_chan); } of_dma_controller_free(pdev->dev.of_node); -- 2.43.0