From: Binbin Wu <binbin.wu@linux.intel.com>
To: "Chang S. Bae" <chang.seok.bae@intel.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
pbonzini@redhat.com, seanjc@google.com,
Zhao Liu <zhao1.liu@intel.com>
Subject: Re: [PATCH] KVM: x86: Remove AMX-TF32 enumeration
Date: Mon, 20 Jul 2026 14:11:19 +0800 [thread overview]
Message-ID: <c4343410-c5fc-4171-a120-a3786ea38a20@linux.intel.com> (raw)
In-Reply-To: <20260708210118.402005-1-chang.seok.bae@intel.com>
On 7/9/2026 5:01 AM, Chang S. Bae wrote:
> AMX-TF32 enumeration was added based on the Intel documentation [1]. The
> recent update removed the feature, indicating that the feature is no
> longer planned for hardware implementation.
>
> [1] Intel Architecture Instruction Set Extensions and Future Features
>
> Cc: Zhao Liu <zhao1.liu@intel.com>
> Cc: Binbin Wu <binbin.wu@linux.intel.com>
> Signed-off-by: Chang S. Bae <chang.seok.bae@intel.com>
Reviewed-by: Binbin Wu <binbin.wu@linux.intel.com>
One nit below.
> ---
> Note: The feature first appeared in the September 2025 revision of the
> document and was removed in the June 2026 revision.
IMHO, the note is informative.
Is it better to move it to the body of the changelog?
> ---
> arch/x86/kvm/cpuid.c | 1 -
> arch/x86/kvm/reverse_cpuid.h | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/arch/x86/kvm/cpuid.c b/arch/x86/kvm/cpuid.c
> index 591d2294acd7..759a1c557080 100644
> --- a/arch/x86/kvm/cpuid.c
> +++ b/arch/x86/kvm/cpuid.c
> @@ -1082,7 +1082,6 @@ void kvm_initialize_cpu_caps(void)
> F(AMX_COMPLEX_ALIAS),
> F(AMX_FP16_ALIAS),
> F(AMX_FP8),
> - F(AMX_TF32),
> F(AMX_AVX512),
> F(AMX_MOVRS),
> );
> diff --git a/arch/x86/kvm/reverse_cpuid.h b/arch/x86/kvm/reverse_cpuid.h
> index 2ad25781cefb..1bb13903c5b2 100644
> --- a/arch/x86/kvm/reverse_cpuid.h
> +++ b/arch/x86/kvm/reverse_cpuid.h
> @@ -56,7 +56,6 @@
> #define X86_FEATURE_AMX_COMPLEX_ALIAS KVM_X86_FEATURE(CPUID_1E_1_EAX, 2)
> #define X86_FEATURE_AMX_FP16_ALIAS KVM_X86_FEATURE(CPUID_1E_1_EAX, 3)
> #define X86_FEATURE_AMX_FP8 KVM_X86_FEATURE(CPUID_1E_1_EAX, 4)
> -#define X86_FEATURE_AMX_TF32 KVM_X86_FEATURE(CPUID_1E_1_EAX, 6)
> #define X86_FEATURE_AMX_AVX512 KVM_X86_FEATURE(CPUID_1E_1_EAX, 7)
> #define X86_FEATURE_AMX_MOVRS KVM_X86_FEATURE(CPUID_1E_1_EAX, 8)
>
next prev parent reply other threads:[~2026-07-20 6:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-08 21:01 Chang S. Bae
2026-07-09 2:12 ` Xiaoyao Li
2026-07-09 17:18 ` Chang S. Bae
2026-07-09 11:00 ` Zhao Liu
2026-07-09 17:26 ` Chang S. Bae
2026-07-20 6:11 ` Binbin Wu [this message]
2026-07-20 20:56 ` Chang S. Bae
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c4343410-c5fc-4171-a120-a3786ea38a20@linux.intel.com \
--to=binbin.wu@linux.intel.com \
--cc=chang.seok.bae@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=zhao1.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®