From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA0B0E7F14F for ; Wed, 27 Sep 2023 13:13:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231853AbjI0NNF (ORCPT ); Wed, 27 Sep 2023 09:13:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45688 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231760AbjI0NNE (ORCPT ); Wed, 27 Sep 2023 09:13:04 -0400 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C7CDCF4 for ; Wed, 27 Sep 2023 06:13:02 -0700 (PDT) Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-4056ce55e7eso78338635e9.2 for ; Wed, 27 Sep 2023 06:13:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1695820381; x=1696425181; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=LjEJIhDS4gJpPQVa0J4l2zKN5/ndNnbpVlOxJdWLqKM=; b=c8Y3x1WcwRvo4IaarbstEepAo9/jsgo7oNS1O98KGpfc2N7OiyGXxLML1DpsmS+vyw RUiYh9GcfTkHW7diVTuAlWI/fSOf44j5AQ6M3kxMRToP4hFFatZHXqISzUZd2N4R6y5f IC6nnMigBnsPgwwfEE2UQPyQnaHDCLnO+DcafhBk3EYbhjyslw3/6k55HM8fZk8ohx/n a32Q65WnAZDf3k0sLA+1aKrzpakx7c4Gs8zfVc1QXJCR0L+aL5DqZ87Hq0wFVjuWDT/J I7NOSRSnUlsqig2cKbkYKt76zWwMKAiS6mfv5h4P6VcslmksraXlrbW70Z37MQUqrMnX YJow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695820381; x=1696425181; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=LjEJIhDS4gJpPQVa0J4l2zKN5/ndNnbpVlOxJdWLqKM=; b=gWB9Cqb59McMjuL/TY/6kTIM+XnGGw3GLH17sGQWegorC8nNXK6oJRiTsiru5jXd8g p502ZeYYeHqITTmeDvdjAVQ8insBeiyYYqh+ghEMvMOIm2AfqirqtGLXQDg7NDthmlrR JI1ISLYw2d4P5cZ2PO+nRdTSEaTmpnWx/PDSiShSdmfL5df13XRMpn4CmGiskpCoCnf9 nK2hc85MoCK3T2LZVsu7NOW62JUOidyVUC9+wyFxIZxpbnFf6iczJcnLL4MKZC61oEAX zWv/5P99mu37azFJZMPFwmJzL87lesztlWM6vc+b5QdYvYgRKMHp0DBHkAzx5hOjoUTZ u6vw== X-Gm-Message-State: AOJu0Yy88CuIubRxBRdjZ7zjK98F43kQcwjvv3JBgQOqi/yZNm1zaV+8 BjduQ+eVZga6jOdLiY7Bao5V+g== X-Google-Smtp-Source: AGHT+IEwVtUCx/Tt513h6sD4GTqmeMlw1bFudbkMznlk83J31/qYCbn5yBepxFngnTxWI51kMnSPpA== X-Received: by 2002:a05:600c:2604:b0:3fe:d1e9:e6b8 with SMTP id h4-20020a05600c260400b003fed1e9e6b8mr2086160wma.12.1695820381191; Wed, 27 Sep 2023 06:13:01 -0700 (PDT) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id y1-20020a05600c364100b003fefe70ec9csm1865074wmq.10.2023.09.27.06.13.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Sep 2023 06:13:00 -0700 (PDT) Date: Wed, 27 Sep 2023 16:12:50 +0300 From: Dan Carpenter To: wangweidong.a@awinic.com Cc: lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, perex@perex.cz, tiwai@suse.com, shumingf@realtek.com, rf@opensource.cirrus.com, herve.codina@bootlin.com, arnd@arndb.de, 13916275206@139.com, ryans.lee@analog.com, linus.walleij@linaro.org, ckeepax@opensource.cirrus.com, doug@schmorgal.com, fido_max@inbox.ru, harshit.m.mogalapalli@oracle.com, liweilei@awinic.com, yang.lee@linux.alibaba.com, u.kleine-koenig@pengutronix.de, yijiangtao@awinic.com, colin.i.king@gmail.com, trix@redhat.com, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V5 3/8] ASoC: codecs: Modify the code related to the property Message-ID: References: <20230927121634.94822-1-wangweidong.a@awinic.com> <20230927121634.94822-4-wangweidong.a@awinic.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230927121634.94822-4-wangweidong.a@awinic.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 27, 2023 at 08:16:29PM +0800, wangweidong.a@awinic.com wrote: > From: Weidong Wang > > Remove the "fade-enable" property because other properties > already implement this functionality. > Rename "sound-channel" to "awinic,audio-channel", > this is to be consistent with the "awinic,aw88395.yaml" file This feels like it should be split into two patches. patch 4/9: remove the "fade-enable property". Btw, which other properties implement this. Can you add that to the commit message? patch 5/9: Rename "sound-channel" to "awinic,audio-channel". regards, dan carpenter