From: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org, Chen Ni <nichen@iscas.ac.cn>,
linux-can@vger.kernel.org, Marc Kleine-Budde <mkl@pengutronix.de>
Subject: Re: [PATCH v3] can: ucan: Use two USB endpoint API functions rather than duplicating their implementations
Date: Sun, 29 Jun 2025 16:19:42 +0900 [thread overview]
Message-ID: <c44cf0e9-9510-4fe9-aa67-edeaa1be6253@wanadoo.fr> (raw)
In-Reply-To: <0a675827-33af-4ec4-97dc-2e4523e41194@web.de>
On 28/06/2025 at 16:19, Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sat, 28 Jun 2025 08:56:51 +0200
Your patch doesn't pass the ./script/checkpath.pl script :(
WARNING: From:/Signed-off-by: email address mismatch: 'From: Markus Elfring
<elfring@users.sourceforge.net>' != 'Signed-off-by: Markus Elfring
<Markus.Elfring@web.de>'
total: 0 errors, 1 warnings, 0 checks, 21 lines checked
Please use the same email address:
- To send the patch
- For the patch author
- For the Signed-off-by tag
> * Reuse existing functionality from usb_endpoint_is_bulk_in()
> and usb_endpoint_is_bulk_out() instead of keeping duplicate source code.
>
> * Omit two comment lines which became redundant with this refactoring.
>
> The source code was transformed by using the Coccinelle software.
>
> Reviewed-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
> Signed-off-by: Markus Elfring <Markus.Elfring@web.de>
Yours sincerely,
Vincent Mailhol
next prev parent reply other threads:[~2025-06-29 7:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-28 7:19 Markus Elfring
2025-06-29 7:19 ` Vincent Mailhol [this message]
2025-06-29 7:51 ` [v3] " Markus Elfring
2025-06-29 8:33 ` Vincent Mailhol
2025-06-29 10:34 ` Markus Elfring
2025-06-29 11:38 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c44cf0e9-9510-4fe9-aa67-edeaa1be6253@wanadoo.fr \
--to=mailhol.vincent@wanadoo.fr \
--cc=Markus.Elfring@web.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=nichen@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®