From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932646AbcI1Npm (ORCPT <rfc822;w@1wt.eu>);
        Wed, 28 Sep 2016 09:45:42 -0400
Received: from mail-io0-f195.google.com ([209.85.223.195]:33590 "EHLO
        mail-io0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S932348AbcI1Npd (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 28 Sep 2016 09:45:33 -0400
Subject: Re: [PATCH v5 0/7] Reduce cache miss for snmp_fold_field
To: David Miller <davem@davemloft.net>
References: <1475043748-18161-1-git-send-email-hejianet@gmail.com>
 <20160928.050817.110671274247345232.davem@davemloft.net>
Cc: netdev@vger.kernel.org, linux-sctp@vger.kernel.org,
        linux-kernel@vger.kernel.org, kuznet@ms2.inr.ac.ru, jmorris@namei.org,
        yoshfuji@linux-ipv6.org, kaber@trash.net, vyasevich@gmail.com,
        nhorman@tuxdriver.com, steffen.klassert@secunet.com,
        herbert@gondor.apana.org.au, marcelo.leitner@gmail.com
From: hejianet <hejianet@gmail.com>
Message-ID: <c44daa11-dc57-84fa-35cc-40ee0fe293f3@gmail.com>
Date: Wed, 28 Sep 2016 21:45:32 +0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:45.0)
 Gecko/20100101 Thunderbird/45.3.0
MIME-Version: 1.0
In-Reply-To: <20160928.050817.110671274247345232.davem@davemloft.net>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On 9/28/16 5:08 PM, David Miller wrote:
> From: Jia He <hejianet@gmail.com>
> Date: Wed, 28 Sep 2016 14:22:21 +0800
>
>> v5:
>> - order local variables from longest to shortest line
> I still see many cases where this problem still exists.  Please
> do not resubmit this patch series until you fix all of them.
>
> Patch #2:
>
> -static int snmp_seq_show(struct seq_file *seq, void *v)
> +static int snmp_seq_show_ipstats(struct seq_file *seq, void *v)
>   {
>   	int i;
> +	u64 buff64[IPSTATS_MIB_MAX];
>   	struct net *net = seq->private;
>
> The order should be "net" then "buff64" then "i".
Sorry for my bad eyesight and quick hand :(
B.R.
Jia
>
> +static int snmp_seq_show_tcp_udp(struct seq_file *seq, void *v)
> +{
> +	int i;
> +	struct net *net = seq->private;
> +	unsigned long buff[TCPUDP_MIB_MAX];
>
> The order should be "buff", "net", then "i".
>
> Patch #3:
>
> @@ -192,13 +197,19 @@ static void snmp6_seq_show_item(struct seq_file *seq, void __percpu *pcpumib,
>   				const struct snmp_mib *itemlist)
>   {
>   	int i;
> -	unsigned long val;
> -
>   ...
> +	unsigned long buff[SNMP_MIB_MAX];
>
> The order should be "buff" then "i".
>
> @@ -206,10 +217,13 @@ static void snmp6_seq_show_item64(struct seq_file *seq, void __percpu *mib,
>   				  const struct snmp_mib *itemlist, size_t syncpoff)
>   {
>   	int i;
> +	u64 buff64[SNMP_MIB_MAX];
>
> Likewise.
>
> I cannot be any more explicit in my request than this.
>